From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 974D05661 for ; Wed, 11 Dec 2024 06:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733897074; cv=none; b=YDgi9LErAT3sEACLzfm6ja16k4f9ywdrx8ekwDgk4afZKNCSPfknYU73o0Q5JToNtKQzJtyWX8G34CpcG9ksVQSdogshu8v9R6RkANDVFwkUshcprGezu+aim71NBEM3Xqi3kBOYAGwH3Oj2Br/Gfdk3IwHDh6AFyPU6aq1k2jU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733897074; c=relaxed/simple; bh=+JcUvL8TdkGifcwu1FSpMcUqqJLBbCSXJvpOAQ7m7p8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ocLQowiyWjjob5zIDgpBAjBBK4geMGzTPKgldMEC1dWF5PSeHtfD8oekMSgSpxnqzIvrw1eBn/AdHX60GP5kd0T/yryGJBSd7udEBmrkVhpIKIiRlYa9py9hTJAcVPT2bPaZZdabCfgEFEfq40gj6FQV4pmIjO5yPVCgo/ePrd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OcgFTAhd; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OcgFTAhd" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21649a7bcdcso30282675ad.1 for ; Tue, 10 Dec 2024 22:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733897072; x=1734501872; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=s8IoPSQMtEEL6HOp9R3MHt1lyYtmF6QVYbrckRmNW8I=; b=OcgFTAhdmR9ZoIBLr9C9iLoPKQfLiEVM9DfWyeyDKz6gTbtqhgsAuJnv4D6+AkVWFW IM8mPXXJQH3YV6zD48URahUaNVg87zO5ZUnHTjuaKnrIfKTEvmztGPPnfWkOiHn4ohCB ShBe3xwQrAtxzrEnPNUbF1RYRIE7XMuszH4zo4WM4UiETSC5iqkrwWj00tCP0RxotQre BIA+BLzUWZvheHGJM5r1IPBMuoFPrQeIp/A9LU1VsXRFn9Xl7ycwJTrmTQ7idhQbn74Y 8nrquv5BtzQbAUJgXybcUkvuY3vbRZYlObCb0lPdcJkbLpIqwHFiWYlKDDE0Qeqz1Ahk wLFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733897072; x=1734501872; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s8IoPSQMtEEL6HOp9R3MHt1lyYtmF6QVYbrckRmNW8I=; b=S1xotwNHrJonyXVjsYJIHGRzTBS5yR1Cgzq2qLJOqaN2Hj1qAW0xcj3b65ALRvSik9 vCBPnHrQDRSw0G0W4d1myK5pQQSewTKqPJ7rDa0IhX1+qWiXzDrdHrkP1rROVdYLESWf TimcBe6yk7h6xDe1t9JjMuc9vrFPi9QqUDwodbHu48nh2ekrC2GG/VHHtzcVFviPk6lf cDXHbVqkF532paBJnPgDnTuxB2bBY8MppLoEWtK4LZ1MPyf/CSBDcVEO82KWTxAhAAqy 6DTk6NCMHSFsNJwqvEecxwFV1vMbKAmSRzO8MlbHkMZPS7v4/K1cFTW8W9fhXaVZKkUn 81UQ== X-Forwarded-Encrypted: i=1; AJvYcCVeK++Pjm7qdwgLmRaaU/RRFOumh2SBX8vcOuV989Vjvvb41jI1SCIHRIRoCsutXTAM6/EijCoba1KPU2U=@vger.kernel.org X-Gm-Message-State: AOJu0YyGy8xh3I1sNj7Yuk0B9A0BAJ661w6sxxROs8uLvuEDH5HkemaC +OI9TcxAIFTM6UdAd6jvaJmADAIy+xa3Mk7mBH4S0hle8O0xzf9n1hHvVK+grg== X-Gm-Gg: ASbGncsoozTrbzQTOvi7sJEQVbpjMaJmb1jSEqLzeyAk9hPSktVjEC9Wp1FRxpAoYHQ upPFTkhY7CQcf/JDZXSwIqn/wxZ+uYCKkPnlCG8pRvfubHXqszLr9npD1vcRVjXUxOq92fjBRi3 B3M51CF2Gg0EgohbKyaWuUnYJcix/7CeCAB+TZxKdFl75Cm8Q0ulKOUrrr7E/erXECKsOEbSV0J byHfUOdTmqbRTZ6XW1XlOk2u73a3ktKW27BiKFPaU9OROvIDFC+BVlgh9mXvfU= X-Google-Smtp-Source: AGHT+IGMQiw9EMReovhZtxJ046XhcMh5S83+xfJNwDeGQ8QcJ07MPY4YZJkgMpDk8inAJw3ApdVzrA== X-Received: by 2002:a17:902:e74e:b0:215:9d29:9724 with SMTP id d9443c01a7336-21778590f41mr29160785ad.38.1733897071869; Tue, 10 Dec 2024 22:04:31 -0800 (PST) Received: from thinkpad ([120.60.55.53]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21618d9beafsm81832105ad.6.2024.12.10.22.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 22:04:31 -0800 (PST) Date: Wed, 11 Dec 2024 11:34:18 +0530 From: Manivannan Sadhasivam To: Marc Zyngier Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Alyssa Rosenzweig , Frank Li Subject: Re: [PATCH 0/2] PCI: Convert the Apple controller to host bridge hooks Message-ID: <20241211060418.gpepptv6wlbv7fwt@thinkpad> References: <20241204150145.800408-1-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241204150145.800408-1-maz@kernel.org> On Wed, Dec 04, 2024 at 03:01:43PM +0000, Marc Zyngier wrote: > The Apple PCIe controller requires some additional attention when > enabling an endpoint device, so that the RID gets correctly mapped to > a SID on its way to the IOMMU. > > So far, we have need relying on a custom bus notifier to perform this > task, but Frank Li's series [1] is a better approach as it puts the > complexity in the core code instead of the host controller driver, and > this series builds on that: > > - allow the new {en,dis}able_device() to be provided via pci_ecam_ops > > - convert the Apple PCIe driver to that infrastructure > > Patches on top of 6.13-rc1, plus Frank's v7 series. > > [1] https://lore.kernel.org/r/20241203-imx95_lut-v7-0-d0cd6293225e@nxp.com > Reviewed-by: Manivannan Sadhasivam - Mani > Marc Zyngier (2): > PCI: host-generic: Allow {en,dis}able_device() to be provided via > pci_ecam_ops > PCI: apple: Convert to {en,dis}able_device() callbacks > > drivers/pci/controller/pci-host-common.c | 2 + > drivers/pci/controller/pcie-apple.c | 75 +++++------------------- > include/linux/pci-ecam.h | 4 ++ > 3 files changed, 21 insertions(+), 60 deletions(-) > > -- > 2.39.2 > -- மணிவண்ணன் சதாசிவம்