From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF18521660B for ; Thu, 12 Dec 2024 18:36:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734028604; cv=none; b=BKSQ++/1xQeLYNxzmDaKsLoWGrcenLv7Hyo7akiHAzaD8fiiXmhI/ZkSI4TwGK2iam3KDhpl1RAAdCdJjcv/PfZHM9KAv8jHQNapldjCDQ90NIFTfbj2v1Ogo4gP0KMkLalUCSnKuJR5Mj3gCPXrFetyUAVbYqxJCWTtx8zi2yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734028604; c=relaxed/simple; bh=E6wM/3T38SY7+DkdVv8mz0g9eJS9zIkOcgoxLdEo2xo=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=h4bLqqKpytPRR5FJoudMmiSyyEkUNKDjJpSaUA6hMqagBvFSl23GcVIzrN77ZaOUr2RvuIiTXTKAHjgn3Vp8Yxw1dNvkt2Ark7vEp/D0xkWh929O2Tk+zdON7s65HEeQAmZkwrhmAmhj59s5NEPykrYd992X1mjI2MGLPeZjUCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=OJ5vDW3G; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="OJ5vDW3G" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4361d5dcf5bso10070675e9.3 for ; Thu, 12 Dec 2024 10:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1734028600; x=1734633400; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Fv3fbXAGrIYdfjN2UmggTGBbw/plczA+5BniWAkzYYI=; b=OJ5vDW3GO7vMCzkjwF+2Lwqy1q/6FLmMO8VdLKYr7Rqjkzx0BehtpEAxdCYQJxIwh8 OHLfcB8TXy48cn/3J2E7khLy19BfGoJarg1Ag7IVDKOA7nK6zuiPwXYJiy6GLVfiZZZl riQ/lszscS0jZJTsJsDmGNNMLU7TElzOS5yCoyLsleL7je1jbxfUCCxCV/Cr49Gok7Sf etVHrDk9APXAyaBQdAv/696ppN70OS+di2wgFULS+rQNkcZUkJ1BrHcz/ZQSkwRMVPC6 bT1yYFGcIBVyugGPFjWg1rlXiQ75bxabZ9jOFrZYyCp25RaKTR0MuRFwAkxpDIIWtFkR vGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734028600; x=1734633400; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fv3fbXAGrIYdfjN2UmggTGBbw/plczA+5BniWAkzYYI=; b=WEySixk4tSUZh1SN4X/vzTnS4EQ3gfaEcrs7RXPDcIilctCl5RWtIIumDAcQqiM2mg isM4WixuJnq1i8Rn/00oXxnkXmRBfKrAEvgswPSXPwscZexsVNrC4HkT8lrRbmCfhBvM 3Fv1uYsqSyhac9tp+85Si/11WFZcfc30o6X7EgLxAH3TcsVTYXi2wnWYAJryNc6Sj09+ 038DsD+bZiLpZIYAbgXF4Mf97rEGoQR0zpokVECaiVT2vzlJZtGIN+inVp9BZdKP6HG9 OQf9yIa4wzxnxbURO3229kUMs98onrZOHNYPZjAKDTfEb/kXnFjjb+Cn0+zKk8JTKIsK ihFg== X-Forwarded-Encrypted: i=1; AJvYcCXi6b6wtOhgUqumOvs6vgniY2otlFouRGKOYXxwr74CkPSls4dwVheGqtkOFGRealUNVKMvbTSkUly6qq4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8/yvA03/IYDXNEUbWtjcz8GlxLQ9t8y7wTq0+6t3DEM/tziP/ U6f9TZESBvEWvzdJwBAkUoOvIWq+Z8uGcLjJAaJUJt97BqKhtMangbL+zi7Ir0A= X-Gm-Gg: ASbGnctwWAqH+0qlpKbf1e+y2sBNHC2kUJ1S4ErU9Rr+v3esThs5WFoixuzBwq5yv7u Hlrvde3aRVKwxokewCOdo4D525fPcI2ul4+Conm56ow+/kOelhNbVV0U/H7DpZSrKeESVuB6Ysn 6LqPUJA2VZ1B8nYMZfLerquoucS4NZze9P0vVdtfjJDvCNX3V/b4Y2Kny2M3RBL5DcqC79RTIrN LEhTw9B4AHhT0N+Y/Hf1y+c8SCxZp6GPGeTEG2o1Lb/+Kvn X-Google-Smtp-Source: AGHT+IGhmyt8mpOnXb+dJ711Uf3mlUnOYDVx9MCQVeQjzLSO7tEtY0jrOPhc109rLLEz5hKiOUUacw== X-Received: by 2002:a05:600c:4e49:b0:434:edcf:7474 with SMTP id 5b1f17b1804b1-43622883cd8mr39949565e9.33.1734028600168; Thu, 12 Dec 2024 10:36:40 -0800 (PST) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-436257178e3sm24651995e9.41.2024.12.12.10.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 10:36:38 -0800 (PST) From: Dave Stevenson Subject: [PATCH v3 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset Date: Thu, 12 Dec 2024 18:36:27 +0000 Message-Id: <20241212-dt-bcm2712-fixes-v3-0-44a7f3390331@raspberrypi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIACstW2cC/23NPQ6DMAwF4KugzHWVmBQCU+9RdQjBKRn4UYKiI sTdG+hSiS6Wnq33eWWBvKPA6mxlnqILbhxSyC8ZM50eXgSuTZkhRykEKmhnaEyPpUCw7k0BtG0 4Kc21LAuWapOn45Baj2fKnQvz6JfjQxT79oulccaiAA5Wm6I0Bm2l9N3rMDXk/TK5qxl7tpMRf xjxj8HE5LdKFcRly608M9u2fQDf01M7/QAAAA== To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Eric Anholt , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Ray Jui , Scott Branden , Doug Berger , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Stefan Wahren Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , linux-gpio@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 I missed the DT errors from the recent patchset[1] (DT patches in linux-next via Florian, DRM bindings patches on dri-misc-next) as Rob's bot report got spam filtered, so this is a fixup set. Largely it was changes to number of interrupts or clocks in the bindings, so those are now covered. I've fixed up the missing "interrupt-controller" flags for 2711 and 2712 whilst here. I can't get my head around what is meant to happen with ranges: "soc@107c000000: firmware: 'ranges' is a required property" The meaning seems obvious. However if I add it then I get: "firmware: '#address-cells', '#size-cells', 'dma-ranges', 'ranges' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/arm/bcm/raspberrypi,bcm2835-firmware.yaml# There's obviously some other flag I need to set in the bindings, but I can't work it out. We have similar errors for all the Pi platforms for one or more nodes. Please advise and I'll happily fix them all. Thanks Dave [1] https://lore.kernel.org/linux-arm-kernel/20241025-drm-vc4-2712-support-v2-0-35efa83c8fc0@raspberrypi.com/ Signed-off-by: Dave Stevenson --- Changes in v3: - Fixed up indentation on 1/7. (I fixed it once, but obviously reworked things and lost it). - Link to v2: https://lore.kernel.org/r/20241212-dt-bcm2712-fixes-v2-0-35986e04d0f4@raspberrypi.com Thanks to Stefan and Krzysztof for their reviews. Hopefully I've addressed all points raised in the correct manner. Changes in v2: - Commits have now be merged from drm-misc-next to linux-next, so all commit hashes are valid on linux-next. - 1/7 Removed references to "previous commit". Fixed up indentation. Added maxItems - 2/7 Defined widest constraints - 3/7 Added maxItems and removed reference to Linux - 4/7 Described the errors. Split into two for fix of node name vs addr being wrong. - Added new patch removing "required" for interrupt-controller and interrupt-cells for bcm2836-l1-intc - 5/7 (now 7/7) Removed the intc node for 2712 - it's irrelevant on 64bit systems - 6/7 dropped as updating the binding is the correct answer - 7/7 dropped. simple-bus claims ranges is required, but adding it creates other errors. I'm unclear as to the right solution. - Link to v1: https://lore.kernel.org/r/20241202-dt-bcm2712-fixes-v1-0-fac67cc2f98a@raspberrypi.com --- Dave Stevenson (7): dt-bindings: display: bcm2711-hdmi: Add interrupt details for BCM2712 dt-bindings: display: Fix BCM2835 HVS bindings for BCM2712 dt-bindings: gpio: brcmstb: permit gpio-line-names property dt-bindings: interrupt-controller: brcm,bcm2836-l1-intc: Drop interrupt-controller requirement arm64: dts: broadcom: Rename bcm2712 interrupt controllers arm64: dts: broadcom: Correct hdmi device node names arm64: dts: broadcom: Remove intc controller on BCM2712. .../bindings/display/brcm,bcm2711-hdmi.yaml | 107 ++++++++++++++++++--- .../bindings/display/brcm,bcm2835-hvs.yaml | 83 +++++++++++++--- .../bindings/gpio/brcm,brcmstb-gpio.yaml | 4 + .../interrupt-controller/brcm,bcm2836-l1-intc.yaml | 2 - arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 13 +-- 5 files changed, 170 insertions(+), 39 deletions(-) --- base-commit: 3a6b7ba51f16c093420959ab2bd3476d180547fa change-id: 20241128-dt-bcm2712-fixes-afb0e8a0a476 Best regards, -- Dave Stevenson