From: Prashanth K <quic_prashk@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<cros-qcom-dts-watchers@chromium.org>,
Prashanth K <quic_prashk@quicinc.com>
Subject: [PATCH v2 08/19] arm64: dts: qcom: Disable USB U1/U2 entry for SA8775P
Date: Fri, 13 Dec 2024 15:22:26 +0530 [thread overview]
Message-ID: <20241213095237.1409174-9-quic_prashk@quicinc.com> (raw)
In-Reply-To: <20241213095237.1409174-1-quic_prashk@quicinc.com>
From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Disable U1 and U2 power-saving states to improve stability of USB.
These low-power link states, designed to reduce power consumption
during idle periods, can cause issues in latency-sensitive or high
throughput use cases. Over the years, some of the issues seen are
as follows:
1. In device mode of operation, when UVC is active, enabling U1/U2
is sometimes causing packets drops due to delay in entry/exit of
intermittent these low power states. These packet drops are often
reflected as missed isochronous transfers, as the controller wasn't
able to send packet in that microframe interval and hence glitches
are seen on the final transmitted video output.
2. On QCS6490-Rb3Gen2 Vision kit, ADB connection is heavily unstable
when U1/U2 is enabled. Often when link enters U2, there is a re-
enumeration seen and device is unusable for many use cases.
3. On QCS8300/QCS9100, it is observed that when Link enters U2, when
the cable is disconnected and reconnected to host PC in HS, there
is no link status change interrupt seen and the plug-in in HS doesn't
show up a bus reset and enumeration failure happens.
Disabling these intermittent power states enhances device stability
without affecting power usage.
Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f315a51a7c1..7a50991daaa6 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -3411,6 +3411,8 @@ usb_0_dwc3: usb@a600000 {
iommus = <&apps_smmu 0x080 0x0>;
phys = <&usb_0_hsphy>, <&usb_0_qmpphy>;
phy-names = "usb2-phy", "usb3-phy";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
};
};
@@ -3500,6 +3502,8 @@ usb_1_dwc3: usb@a800000 {
iommus = <&apps_smmu 0x0a0 0x0>;
phys = <&usb_1_hsphy>, <&usb_1_qmpphy>;
phy-names = "usb2-phy", "usb3-phy";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
};
};
@@ -3563,6 +3567,8 @@ usb_2_dwc3: usb@a400000 {
iommus = <&apps_smmu 0x020 0x0>;
phys = <&usb_2_hsphy>;
phy-names = "usb2-phy";
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
};
};
@@ -3570,6 +3576,8 @@ tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0x0 0x01f40000 0x0 0x20000>;
#hwlock-cells = <1>;
+ snps,dis-u1-entry-quirk;
+ snps,dis-u2-entry-quirk;
};
tcsr: syscon@1fc0000 {
--
2.25.1
next prev parent reply other threads:[~2024-12-13 9:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:52 [PATCH v2 00/19] Disable USB U1/U2 entry for QC targets Prashanth K
2024-12-13 9:52 ` [PATCH v2 01/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8350 Prashanth K
2024-12-13 9:52 ` [PATCH v2 02/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8450 Prashanth K
2024-12-13 9:52 ` [PATCH v2 03/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8150 Prashanth K
2024-12-13 9:52 ` [PATCH v2 04/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM6125 Prashanth K
2024-12-13 9:52 ` [PATCH v2 05/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM8250 Prashanth K
2024-12-13 9:52 ` [PATCH v2 06/19] arm64: dts: qcom: Disable USB U1/U2 entry for SM6350 Prashanth K
2024-12-13 9:52 ` [PATCH v2 07/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC7280 Prashanth K
2024-12-13 9:52 ` Prashanth K [this message]
2024-12-14 0:06 ` [PATCH v2 08/19] arm64: dts: qcom: Disable USB U1/U2 entry for SA8775P Konrad Dybcio
2024-12-14 5:31 ` Prashanth K
2024-12-13 9:52 ` [PATCH v2 09/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDM630 Prashanth K
2024-12-13 9:52 ` [PATCH v2 10/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDM845 Prashanth K
2024-12-13 9:52 ` [PATCH v2 11/19] arm64: dts: qcom: Disable USB U1/U2 entry for SDX75 Prashanth K
2024-12-13 9:52 ` [PATCH v2 12/19] ARM: dts: qcom: Disable USB U1/U2 entry for SDX65 Prashanth K
2024-12-13 9:52 ` [PATCH v2 13/19] ARM: dts: qcom: Disable USB U1/U2 entry for SDX55 Prashanth K
2024-12-13 9:52 ` [PATCH v2 14/19] arm64: dts: qcom: Disable USB U1/U2 entry for QCS404 Prashanth K
2024-12-13 9:52 ` [PATCH v2 15/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC7180 Prashanth K
2024-12-13 9:52 ` [PATCH v2 16/19] arm64: dts: qcom: Disable USB U1/U2 entry for X1E80100 Prashanth K
2024-12-13 9:52 ` [PATCH v2 17/19] arm64: dts: qcom: Disable USB U1/U2 entry for QDU1000 Prashanth K
2024-12-13 9:52 ` [PATCH v2 18/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC8280XP Prashanth K
2024-12-13 9:52 ` [PATCH v2 19/19] arm64: dts: qcom: Disable USB U1/U2 entry for SC8180X Prashanth K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213095237.1409174-9-quic_prashk@quicinc.com \
--to=quic_prashk@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®