mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yafang Shao <laoar.shao@gmail.com>,
	mingo@redhat.com, peterz@infradead.org, mkoutny@suse.com,
	hannes@cmpxchg.org
Cc: oe-kbuild-all@lists.linux.dev, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, surenb@google.com,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
Date: Sun, 15 Dec 2024 21:08:36 +0800	[thread overview]
Message-ID: <202412152009.HZ862kna-lkp@intel.com> (raw)
In-Reply-To: <20241215032315.43698-4-laoar.shao@gmail.com>

Hi Yafang,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on peterz-queue/sched/core linus/master v6.13-rc2 next-20241213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/sched-Define-sched_clock_irqtime-as-static-key/20241215-112638
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20241215032315.43698-4-laoar.shao%40gmail.com
patch subject: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
config: arc-randconfig-001-20241215 (https://download.01.org/0day-ci/archive/20241215/202412152009.HZ862kna-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412152009.HZ862kna-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412152009.HZ862kna-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:96:
   kernel/sched/psi.c: In function 'psi_show':
>> kernel/sched/psi.c:1243:42: error: 'PSI_IRQ' undeclared (first use in this function); did you mean 'PSI_IO'?
    1243 |         if (!irqtime_enabled() && res == PSI_IRQ)
         |                                          ^~~~~~~
         |                                          PSI_IO
   kernel/sched/psi.c:1243:42: note: each undeclared identifier is reported only once for each function it appears in


vim +1243 kernel/sched/psi.c

  1233	
  1234	int psi_show(struct seq_file *m, struct psi_group *group, enum psi_res res)
  1235	{
  1236		bool only_full = false;
  1237		int full;
  1238		u64 now;
  1239	
  1240		if (static_branch_likely(&psi_disabled))
  1241			return -EOPNOTSUPP;
  1242	
> 1243		if (!irqtime_enabled() && res == PSI_IRQ)
  1244			return -EOPNOTSUPP;
  1245	
  1246		/* Update averages before reporting them */
  1247		mutex_lock(&group->avgs_lock);
  1248		now = sched_clock();
  1249		collect_percpu_times(group, PSI_AVGS, NULL);
  1250		if (now >= group->avg_next_update)
  1251			group->avg_next_update = update_averages(group, now);
  1252		mutex_unlock(&group->avgs_lock);
  1253	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-12-15 13:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15  3:23 [PATCH v7 0/4] sched: Fix missing irq time when CONFIG_IRQ_TIME_ACCOUNTING is enabled Yafang Shao
2024-12-15  3:23 ` [PATCH v7 1/4] sched: Define sched_clock_irqtime as static key Yafang Shao
2024-12-15  3:23 ` [PATCH v7 2/4] sched: Don't account irq time if sched_clock_irqtime is disabled Yafang Shao
2024-12-15  3:23 ` [PATCH v7 3/4] sched, psi: " Yafang Shao
2024-12-15 13:08   ` kernel test robot [this message]
2024-12-15 13:38     ` Yafang Shao
2024-12-15 13:50   ` kernel test robot
2024-12-15  3:23 ` [PATCH v7 4/4] sched: Fix cgroup irq time for CONFIG_IRQ_TIME_ACCOUNTING Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202412152009.HZ862kna-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bsegall@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=hannes@cmpxchg.org \
    --cc=juri.lelli@redhat.com \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=surenb@google.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®