From: Florian Rommel <mail@florommel.de>
To: nils@nilsfuhler.de
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com, mail@florommel.de
Subject: Re: [PATCH v2] net: ip6: ndisc: fix incorrect forwarding of proxied ns packets
Date: Mon, 16 Dec 2024 18:01:29 +0100 [thread overview]
Message-ID: <20241216170129.531313-1-mail@florommel.de> (raw)
In-Reply-To: <fcb4b7d9-08e1-4a8b-8218-a7301e6930f5@nilsfuhler.de>
What is the status of this? The proposed fix seems to work.
> > I have mixed feeling WRT this patch. It looks like a fix, but it's changing an established behaviour that is there since a lot of time.
> >
> > I think it could go via the net-next tree, without fixes
> > tag to avoid stable backports. As such I guess it deserves a self-test script validating the new behavior.
> >
> That is probably the best option.
> Although I'm not sure whether it would really break something. The
> forwarded packets have a hoplimit of 254 and are therefore not valid
> ndisc packets anymore.
I also can't imagine that anything depends on invalid packets being created?
prev parent reply other threads:[~2024-12-16 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 15:18 Nils Fuhler
2024-08-20 13:13 ` Paolo Abeni
2024-08-21 17:57 ` Nils Fuhler
2024-12-16 17:01 ` Florian Rommel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216170129.531313-1-mail@florommel.de \
--to=mail@florommel.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nils@nilsfuhler.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®