From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: kernel@collabora.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v5 0/3] Provide devm_clk_bulk_get_all_enabled() helper
Date: Tue, 17 Dec 2024 23:41:50 +0200 [thread overview]
Message-ID: <20241217-clk_bulk_ena_fix-v5-0-aafbbb245155@collabora.com> (raw)
Commit 265b07df758a ("clk: Provide managed helper to get and enable bulk
clocks") added devm_clk_bulk_get_all_enable() function, but missed to
return the number of clocks stored in the clk_bulk_data table referenced
by the clks argument.
That is required in case there is a need to iterate these clocks later,
therefore I couldn't see any use case of this parameter and should have
been simply removed from the function declaration.
The first patch in the series provides devm_clk_bulk_get_all_enabled()
variant, which is consistent with devm_clk_bulk_get_all() in terms of
the returned value:
> 0 if one or more clocks have been stored
= 0 if there are no clocks
< 0 if an error occurred
Moreover, the naming is consistent with devm_clk_get_enabled(), i.e. use
the past form of 'enable'.
The next two patches switch existing users of devm_clk_get_enable() to
the new helper - there were only two, as of next-20240913.
The last patch drops the now obsolete devm_clk_bulk_get_all_enable()
helper.
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Changes in v5:
- Rebased series onto next-20241217
- Removed the patch introducing the new helper - merged in v6.13-rc1
- Updated last patch to fix a rebase conflict
- Link to v4: https://lore.kernel.org/r/20241019-clk_bulk_ena_fix-v4-0-57f108f64e70@collabora.com
Changes in v4:
- Dropped usage of gotos in the new helper implementation to further
minimize the diff (Stephen)
- Link to v3: https://lore.kernel.org/r/20241018-clk_bulk_ena_fix-v3-0-57e8bb82460c@collabora.com
Changes in v3:
- Made devm_clk_bulk_get_all_enable() use the new helper, as suggested
by Stephen to improve diff readability
- Rebased series onto next-20241017
- Link to v2: https://lore.kernel.org/r/20240926-clk_bulk_ena_fix-v2-0-9c767510fbb5@collabora.com
Changes in v2:
- Dropped references to 'broken' API in commit descriptions, per Mani's
suggestion
- Added R-b tags from Angelo and Mani
- Link to v1: https://lore.kernel.org/r/20240914-clk_bulk_ena_fix-v1-0-ce3537585c06@collabora.com
---
Cristian Ciocaltea (3):
soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled()
PCI: exynos: Switch to devm_clk_bulk_get_all_enabled()
clk: Drop obsolete devm_clk_bulk_get_all_enable() helper
drivers/pci/controller/dwc/pci-exynos.c | 2 +-
drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
include/linux/clk.h | 9 ---------
3 files changed, 3 insertions(+), 12 deletions(-)
---
base-commit: fdb298fa865b0136f7be842e6c2e6310dede421a
change-id: 20240912-clk_bulk_ena_fix-16ba77358ddf
next reply other threads:[~2024-12-17 21:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 21:41 Cristian Ciocaltea [this message]
2024-12-17 21:41 ` [PATCH v5 1/3] soc: mediatek: pwrap: Switch to devm_clk_bulk_get_all_enabled() Cristian Ciocaltea
2024-12-18 15:35 ` AngeloGioacchino Del Regno
2024-12-23 20:54 ` Stephen Boyd
2024-12-17 21:41 ` [PATCH v5 2/3] PCI: exynos: " Cristian Ciocaltea
2024-12-23 12:56 ` Cristian Ciocaltea
2024-12-23 14:18 ` Krzysztof Wilczyński
2024-12-23 15:03 ` Cristian Ciocaltea
2024-12-23 20:54 ` Stephen Boyd
2024-12-17 21:41 ` [PATCH v5 3/3] clk: Drop obsolete devm_clk_bulk_get_all_enable() helper Cristian Ciocaltea
2024-12-23 20:54 ` Stephen Boyd
2024-12-17 21:46 ` [PATCH v5 0/3] Provide devm_clk_bulk_get_all_enabled() helper Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241217-clk_bulk_ena_fix-v5-0-aafbbb245155@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@collabora.com \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®