mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Brendan Jackman <jackmanb@google.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/bugs: Add force_cpu_bug= cmdline param
Date: Tue, 17 Dec 2024 12:50:39 +0100	[thread overview]
Message-ID: <20241217115039.GF11133@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241217111752.GDZ2Fd4E4XX-w_t6eq@fat_crate.local>

On Tue, Dec 17, 2024 at 12:17:52PM +0100, Borislav Petkov wrote:
> On Mon, Dec 16, 2024 at 06:58:24PM +0100, Brendan Jackman wrote:
> > OK yeah, tainting definitely makes sense, I think that goes quite a
> > long way to avoid bogus bug reports?
> 
> It was my feeble attempt back then to leave enough breadcrumbs so that when
> I see a bug report, I can say: "well, then don't do that then" and mark it as
> invalid. :)
> 
> > I will also update the docs to sound scarier.
> 
> Right.

Perhaps issue a pr_warn() for every bit set? People tend to not like
WARN/ERR in their production logs much :-)

> > So do you think we should allow setting arbitrary cpu features? That
> > seems like a much bigger footgun. But then again, the difference
> > between "big footgun" and "very big footgun" is not that important,
> > either way it needs to be clear to users that this is a scary red
> > button.
> 
> Yeah, with your patch we're half-way there. Might as well do the whole thing
> but again, this is only my opinion. Probably should hear what others have to
> say first...

Given I'm the one that did the retbleed=force thing (and other force
options), I'm in favour.

      reply	other threads:[~2024-12-17 11:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19 18:43 Brendan Jackman
2024-12-16 15:33 ` Brendan Jackman
2024-12-16 17:17 ` Borislav Petkov
2024-12-16 17:58   ` Brendan Jackman
2024-12-17 11:17     ` Borislav Petkov
2024-12-17 11:50       ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241217115039.GF11133@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jackmanb@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®