From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx08-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16CA71F706E; Tue, 17 Dec 2024 17:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734457589; cv=none; b=JeGLLzBUUZDdavIm67ZqbBnamSQg8OXqE0MzwOYGT0fMKOaH7l9Wwk1rE0yWP8OeKiOK0yV24uSI2Zjc7u5kbEj8+Fd9o5Q9IsE4E7xYu33azPbecKGAgmp4N7fQy0HYEG/GUW1bohkn/wKi1EuDJqgRKjF3OYwxRa05qmzI1nw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734457589; c=relaxed/simple; bh=W+chijpnVEp7UHsjvKMeMnGkZo4bfgoAjGNPDvFvKP0=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SIowafRzeY+jErJ8A6uBMQyJjgu28+cuFf+JKJgqM4jQMlykoTwoLy+gQc3+VIsjhg/AlP4TX6euJFfIUzBBI4nxv1QSbjO1DMjI0jP/EHS4xlcJyO029otTaVmABwlCpUH3N3wKk68pe+UWwRg8kxr2QBXYyox162RLAPa4COE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=739eMwp8; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="739eMwp8" Received: from pps.filterd (m0369457.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHD33jT000978; Tue, 17 Dec 2024 18:45:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=selector1; bh=m06eKb+0LXxL2kWMKmXmynUU 1n7kANnjSiqIgxEeFCE=; b=739eMwp8PGdTU/m7CESzZVpZlgISnUYZivGvZ8By bleBOS2Vy9Q6igP0fUEH4yq0yoOZWU2aS9cj5ZiQ3m/Js5Da1e37T8sf4S7QO1wX s9ppyP60om11SWjLrYZxR056RmQYPh/Etd1OjrHFrgG/3Q+oSTZFK6PpJSJtV6kX Aye/fYOxVAgQdpmECEwL+Z5S1pX3r1b/hX7d6dSp/TCSVaaaTfKq3va2kpRnbYAn r2WGO4Zh1AUPVuMZJMaFC8f7WlAvdtPEyA2XslXKXFErAYf1t2DnesZhzfKaUkTp FLcGtIqts97SykceTBx2JU7TJDkniJ3YE+FukDjoIQC9vA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43k5ngaw6t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 18:45:56 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 6E0D140044; Tue, 17 Dec 2024 18:44:24 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 395FC28AF0E; Tue, 17 Dec 2024 18:41:51 +0100 (CET) Received: from gnbcxd0016.gnb.st.com (10.129.178.213) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 17 Dec 2024 18:41:50 +0100 Date: Tue, 17 Dec 2024 18:41:44 +0100 From: Alain Volmat To: Sakari Ailus CC: Hugues Fruchet , Mauro Carvalho Chehab , Maxime Coquelin , Alexandre Torgue , Sakari Ailus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Hans Verkuil , , , , , , Krzysztof Kozlowski Subject: Re: [PATCH v4 02/15] dt-bindings: media: add description of stm32 csi Message-ID: <20241217174144.GA3784949@gnbcxd0016.gnb.st.com> References: <20241212-csi_dcmipp_mp25-v4-0-fbeb55a05ed7@foss.st.com> <20241212-csi_dcmipp_mp25-v4-2-fbeb55a05ed7@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Hi Sakari, On Sun, Dec 15, 2024 at 12:18:42PM +0000, Sakari Ailus wrote: > Hi Alain, > > On Thu, Dec 12, 2024 at 10:17:26AM +0100, Alain Volmat wrote: > > Add the stm32 csi controller description. > > > > Reviewed-by: Krzysztof Kozlowski > > Signed-off-by: Alain Volmat > > --- > > v2: > > - rename into st,stm32mp25-csi.yaml to match compatible > > - correct port / data-lanes (remove useless lines & > > use data-lanes 1 and 2 instead of 0 and 1) > > - correct commit log > > --- > > .../bindings/media/st,stm32mp25-csi.yaml | 125 +++++++++++++++++++++ > > 1 file changed, 125 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > new file mode 100644 > > index 000000000000..33bedfe41924 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > @@ -0,0 +1,125 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/st,stm32mp25-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: STMicroelectronics STM32 CSI controller > > + > > +description: > > + The STM32 CSI controller allows connecting a CSI based > > + camera to the DCMIPP camera pipeline. > > CSI-2 I presume? > > You should also document it here it has D-PHY... > > > + > > +maintainers: > > + - Alain Volmat > > + > > +properties: > > + compatible: > > + enum: > > + - st,stm32mp25-csi > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 3 > > + > > + clock-names: > > + items: > > + - const: pclk > > + - const: txesc > > + - const: csi2phy > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: Digital core power supply (0.91V) > > + > > + vdda18-supply: > > + description: System analog power supply (1.8V) > > + > > + access-controllers: > > + minItems: 1 > > + maxItems: 2 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: > > + Input port node > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + minItems: 1 > > + items: > > + - const: 1 > > + - const: 2 > > + > > + required: > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + Output port node > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + #include > > + csi@48020000 { > > + compatible = "st,stm32mp25-csi"; > > + reg = <0x48020000 0x2000>; > > + interrupts = ; > > + resets = <&rcc CSI_R>; > > + clocks = <&rcc CK_KER_CSI>, <&rcc CK_KER_CSITXESC>, <&rcc CK_KER_CSIPHY>; > > + clock-names = "pclk", "txesc", "csi2phy"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + port@0 { > > + reg = <0>; > > + endpoint { > > + remote-endpoint = <&imx335_ep>; > > + data-lanes = <1 2>; > > + bus-type = ; > > ...and drop bus-type property. > > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + endpoint { > > + remote-endpoint = <&dcmipp_0>; > > + }; > > + }; > > + }; > > + }; > > + > > +... > > all 3 points corrected within the new serie I just pushed on top of this one since it has already been merged. Regards, Alain