From: Conor Dooley <conor@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, upstream@airoha.com
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: add ID for eMMC for EN7581
Date: Wed, 18 Dec 2024 17:04:03 +0000 [thread overview]
Message-ID: <20241218-shimmer-defog-97f86d6ebe98@spud> (raw)
In-Reply-To: <20241218091153.30088-1-ansuelsmth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Wed, Dec 18, 2024 at 10:11:33AM +0100, Christian Marangi wrote:
> Add ID for eMMC for EN7581. This is to control clock selection of eMMC
> between 200MHz and 150MHz.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v2:
> - Drop additional define for EN7581_NUM_CLOCKS
>
> include/dt-bindings/clock/en7523-clk.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
> index 717d23a5e5ae..c4f8a161b981 100644
> --- a/include/dt-bindings/clock/en7523-clk.h
> +++ b/include/dt-bindings/clock/en7523-clk.h
> @@ -12,6 +12,8 @@
> #define EN7523_CLK_CRYPTO 6
> #define EN7523_CLK_PCIE 7
>
Why the gap?
> +#define EN7581_CLK_EMMC 8
> +
> #define EN7523_NUM_CLOCKS 8
Can you delete this please? Your changelog appears to suggest you did,
but I see it still.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-18 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 9:11 Christian Marangi
2024-12-18 9:11 ` [PATCH v2 2/3] clk: en7523: Rework clock handling for different clock numbers Christian Marangi
2024-12-18 9:11 ` [PATCH v2 3/3] clk: en7523: Add clock for eMMC for EN7581 Christian Marangi
2024-12-18 17:04 ` Conor Dooley [this message]
2024-12-18 17:20 ` [PATCH v2 1/3] dt-bindings: clock: add ID " Christian Marangi
2024-12-18 17:45 ` Conor Dooley
2024-12-18 17:46 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218-shimmer-defog-97f86d6ebe98@spud \
--to=conor@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®