From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: linux-sound@vger.kernel.org, vkoul@kernel.org
Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.dev, bard.liao@intel.com
Subject: [PATCH v3 04/14] soundwire: stream: set DEPREPARED state earlier
Date: Wed, 18 Dec 2024 16:01:45 +0800 [thread overview]
Message-ID: <20241218080155.102405-5-yung-chuan.liao@linux.intel.com> (raw)
In-Reply-To: <20241218080155.102405-1-yung-chuan.liao@linux.intel.com>
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
The existing logic is problematic in that we deprepare all the ports,
but still take into account the stream for bit allocation by just
walking through the bus->m_rt list.
This patch sets the state earlier, so that such DEPREPARED streams can
be skipped in the bandwidth allocation (to be implemented in a
follow-up patch).
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
drivers/soundwire/stream.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 7aa4900dcf31..795017c8081a 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -1643,8 +1643,15 @@ static int _sdw_deprepare_stream(struct sdw_stream_runtime *stream)
{
struct sdw_master_runtime *m_rt;
struct sdw_bus *bus;
+ int state = stream->state;
int ret = 0;
+ /*
+ * first mark the state as DEPREPARED so that it is not taken into account
+ * for bit allocation
+ */
+ stream->state = SDW_STREAM_DEPREPARED;
+
list_for_each_entry(m_rt, &stream->master_list, stream_node) {
bus = m_rt->bus;
/* De-prepare port(s) */
@@ -1652,6 +1659,7 @@ static int _sdw_deprepare_stream(struct sdw_stream_runtime *stream)
if (ret < 0) {
dev_err(bus->dev,
"De-prepare port(s) failed: %d\n", ret);
+ stream->state = state;
return ret;
}
@@ -1665,6 +1673,7 @@ static int _sdw_deprepare_stream(struct sdw_stream_runtime *stream)
if (ret < 0) {
dev_err(bus->dev, "Compute params failed: %d\n",
ret);
+ stream->state = state;
return ret;
}
}
@@ -1673,11 +1682,11 @@ static int _sdw_deprepare_stream(struct sdw_stream_runtime *stream)
ret = sdw_program_params(bus, false);
if (ret < 0) {
dev_err(bus->dev, "%s: Program params failed: %d\n", __func__, ret);
+ stream->state = state;
return ret;
}
}
- stream->state = SDW_STREAM_DEPREPARED;
return do_bank_switch(stream);
}
--
2.43.0
next prev parent reply other threads:[~2024-12-18 8:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 8:01 [PATCH v3 00/14] soundwire: add multi-lane support Bard Liao
2024-12-18 8:01 ` [PATCH v3 01/14] soundwire: add lane field in sdw_port_runtime Bard Liao
2024-12-18 8:01 ` [PATCH v3 02/14] soundwire: mipi_disco: read lane mapping properties from ACPI Bard Liao
2024-12-18 8:01 ` [PATCH v3 03/14] soundwire: add lane_used_bandwidth in struct sdw_bus Bard Liao
2024-12-18 8:01 ` Bard Liao [this message]
2024-12-18 8:01 ` [PATCH v3 05/14] soundwire: generic_bandwidth_allocation: skip DEPREPARED streams Bard Liao
2024-12-18 8:01 ` [PATCH v3 06/14] Soundwire: add sdw_slave_get_scale_index helper Bard Liao
2024-12-18 8:01 ` [PATCH v3 07/14] Soundwire: stream: program BUSCLOCK_SCALE Bard Liao
2024-12-18 8:01 ` [PATCH v3 08/14] Soundwire: generic_bandwidth_allocation: set frame shape on fly Bard Liao
2024-12-18 8:01 ` [PATCH v3 09/14] soundwire: generic_bandwidth_allocation: correct clk_freq check in sdw_select_row_col Bard Liao
2024-12-18 8:01 ` [PATCH v3 10/14] soundwire: generic_bandwidth_allocation: check required freq accurately Bard Liao
2024-12-18 8:01 ` [PATCH v3 11/14] soundwire: generic_bandwidth_allocation: select data lane Bard Liao
2024-12-18 8:01 ` [PATCH v3 12/14] soundwire: generic_bandwidth_allocation: add lane in sdw_group_params Bard Liao
2024-12-18 8:01 ` [PATCH v3 13/14] SoundWire: pass stream to compute_params() Bard Liao
2024-12-18 8:01 ` [PATCH v3 14/14] soundwire: generic_bandwidth_allocation: count the bandwidth of active streams only Bard Liao
2024-12-23 9:12 ` [PATCH v3 00/14] soundwire: add multi-lane support Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218080155.102405-5-yung-chuan.liao@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®