mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+a344326c05c98ba19682@syzkaller.appspotmail.com,
	thomas.petazzoni@bootlin.com, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] net: ethtool: Fix suspicious rcu_dereference usage
Date: Wed, 18 Dec 2024 10:07:56 +0100	[thread overview]
Message-ID: <20241218100756.30de216b@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <CANn89iJcQis_1u5PyBn6gPhge1r6SsVicCCywKeVTrjn9o83_g@mail.gmail.com>

On Tue, 17 Dec 2024 18:28:16 +0100
Eric Dumazet <edumazet@google.com> wrote:

> On Tue, Dec 17, 2024 at 6:17 PM Kory Maincent <kory.maincent@bootlin.com>
> wrote:
> >
> > On Tue, 17 Dec 2024 16:47:07 +0100
> > Eric Dumazet <edumazet@google.com> wrote:
> >  
> > > On Tue, Dec 17, 2024 at 3:03 PM Kory Maincent <kory.maincent@bootlin.com>
> > > wrote:  
>  [...]  
> > >
> > > I have to ask : Can you tell how this patch has been tested ?  
> >
> > Oh, it was not at all sufficiently tested. Sorry!
> > I thought I had spotted the issue but I hadn't.
> >  
> > > rcu is not held according to syzbot report.
> > >
> > > If rtnl and rcu are not held, lockdep will still complain.  
> >
> > You are totally right.
> > I may be able to see it with the timestamping kselftest. I will try.  
> 
> syzbot has a repro that you can compile and run.

Oh indeed, thanks for the pointer.

> Make sure to build and use a kernel with
> 
> CONFIG_PROVE_LOCKING=y

Yes I did.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

      reply	other threads:[~2024-12-18  9:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17 14:03 Kory Maincent
2024-12-17 15:47 ` Eric Dumazet
2024-12-17 17:17   ` Kory Maincent
2024-12-17 17:28     ` Eric Dumazet
2024-12-18  9:07       ` Kory Maincent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241218100756.30de216b@kmaincent-XPS-13-7390 \
    --to=kory.maincent@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+a344326c05c98ba19682@syzkaller.appspotmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®