From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E391F8928 for ; Wed, 18 Dec 2024 16:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734539979; cv=none; b=dHDZCtVjrNsM+Cj3ud13KWCuGVznx3eLqMQw+Yl9C9GrNuc4GS3CWP6l1mEQf7kK2iOWkaM90W5i/4Nux/rLLbcnxmDI0UmuUIIPhT2O8sM2Wy//RhRHS2Kwy7pmhrH8IrIt6Nzt3tOr+/ukWMbMHIJ8JtYB92mCyUuOerUqgfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734539979; c=relaxed/simple; bh=z6Q9jYd8xI/UyVdRC0lSiyB1BRG0ohiZTshgvww4294=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jsTTFEKNFp8UF5mvG9Vr957LO+qWvgcMv2IbeYZTAoe0l2togQEETfow3/8BWSesjdqKiqhenyUCQewhjrHJq39nTmAjm4KIio8IDd8Db/6O0iujRvzY+P5q4QLGG0y1vnSTCslB0Tj7S1jPP+AnjSTHrHHxBlGBc52JVLjyoZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=g9bjT7VO; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="g9bjT7VO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KLuQsCHahX9XbtZv3R0A6RtKKOaXAv3nDDYpjozrX7Y=; b=g9bjT7VOgeRNx3cKRZfzO0pB5/ 89Lmo9Op5MlMtA5z8qZPFycn3TE5YJjsec8x6UAqgGspob1+hp8zBOSXLK3ZefTabKhxv1FRM5H3n wsgC2dLPMVORl8gsglIdXbWSjLJ0rB9fbcVmWxL2S/1UJUqlLA5d+J1NsPET6+EzBOoVQnSyrmDpv /vZbiW2YQ4K3BGrHKYBxQYLiPPslsI4+Edyq+eia5GMBn0emdrXsSl8Mm8/lKoZQiwglpzAcfieUB 001PXQZ1dbnK1xDFrWK8iIBL689fQ9m/hvmAFiiM970VIJH7A7qTxHNNPWiahhXbI7m58v5mpeQ1W zzBaA+Gg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tNx54-00000005Isv-08LA; Wed, 18 Dec 2024 16:39:26 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 8C5AF30031E; Wed, 18 Dec 2024 17:39:25 +0100 (CET) Date: Wed, 18 Dec 2024 17:39:25 +0100 From: Peter Zijlstra To: Qi Zheng Cc: tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/15] mm: pgtable: introduce generic __tlb_remove_table() Message-ID: <20241218163925.GJ2354@noisy.programming.kicks-ass.net> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 18, 2024 at 09:04:47PM +0800, Qi Zheng wrote: > diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c > index c73b89811a264..3e002dea6278f 100644 > --- a/arch/s390/mm/pgalloc.c > +++ b/arch/s390/mm/pgalloc.c > @@ -193,13 +193,6 @@ void page_table_free(struct mm_struct *mm, unsigned long *table) > pagetable_dtor_free(ptdesc); > } > > -void __tlb_remove_table(void *table) > -{ > - struct ptdesc *ptdesc = virt_to_ptdesc(table); > - > - pagetable_dtor_free(ptdesc); > -} > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index 709830274b756..69de47c7ef3c5 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > #define MAX_TABLE_BATCH \ > ((PAGE_SIZE - sizeof(struct mmu_table_batch)) / sizeof(void *)) > > +#ifndef __HAVE_ARCH_TLB_REMOVE_TABLE > +static inline void __tlb_remove_table(void *table) > +{ > + struct ptdesc *ptdesc = (struct ptdesc *)table; > + > + pagetable_dtor(ptdesc); > + pagetable_free(ptdesc); > +} > +#endif This is still broken... maybe later patches fix up, let me go check.