From: Gur Stavi <gur.stavi@huawei.com>
To: <andrew@lunn.ch>
Cc: <andrew+netdev@lunn.ch>, <cai.huoqing@linux.dev>,
<corbet@lwn.net>, <davem@davemloft.net>, <edumazet@google.com>,
<gongfan1@huawei.com>, <guoxin09@huawei.com>,
<gur.stavi@huawei.com>, <horms@kernel.org>, <kuba@kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<meny.yossefi@huawei.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <shenchenyang1@hisilicon.com>,
<shijing34@huawei.com>, <wulike1@huawei.com>,
<zhoushuai28@huawei.com>
Subject: Re: [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic
Date: Thu, 19 Dec 2024 11:28:23 +0200 [thread overview]
Message-ID: <20241219092823.2518558-1-gur.stavi@huawei.com> (raw)
In-Reply-To: <03fa6e84-65a9-4563-b289-bd75508234a2@lunn.ch>
> > > > +static int hinic3_sw_init(struct net_device *netdev)
> > > > +{
> > > > + struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
> > > > + struct hinic3_hwdev *hwdev = nic_dev->hwdev;
> > > > + int err;
> > > > +
> > > > + nic_dev->q_params.sq_depth = HINIC3_SQ_DEPTH;
> > > > + nic_dev->q_params.rq_depth = HINIC3_RQ_DEPTH;
> > > > +
> > > > + hinic3_try_to_enable_rss(netdev);
> > > > +
> > > > + eth_hw_addr_random(netdev);
> > >
> > > Is using a random MAC just a temporary thing until more code is added
> > > to access an OTP?
> > >
> >
> > No, using a random MAC is not a temporary solution.
> > This device is designed for cloud environments. VFs are expected to be
> > used by VMs that may migrate from device to device. Therefore the HW does
> > not provide a MAC address to VFs, but rather the VF driver selects a
> > random MAC address and configures it into the (current) device.
>
> If you look at MAC drivers in general, this is unusual. So it would be
> good to add a comment why this unusual behaviour is used.
Ack. Just posted PATCH v1. Will add comment for v2.
next prev parent reply other threads:[~2024-12-19 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 12:04 [RFC net-next v02 0/3] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2024-12-12 12:04 ` [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic Gur Stavi
2024-12-12 17:02 ` Bjorn Helgaas
2024-12-15 8:59 ` Gur Stavi
2024-12-12 17:41 ` Andrew Lunn
2024-12-19 8:55 ` Gur Stavi
2024-12-19 8:46 ` Andrew Lunn
2024-12-19 9:28 ` Gur Stavi [this message]
2024-12-12 12:04 ` [RFC net-next v02 2/3] net: hinic3: management interfaces Gur Stavi
2024-12-12 12:04 ` [RFC net-next v02 3/3] net: hinic3: sw and hw initialization code Gur Stavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219092823.2518558-1-gur.stavi@huawei.com \
--to=gur.stavi@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®