From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: Ryo Takakura <ryotkkr98@gmail.com>,
peterz@infradead.org, clrkwllms@kernel.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
longman@redhat.com, mingo@redhat.com, rostedt@goodmis.org,
tglx@linutronix.de, will@kernel.org
Subject: Re: [PATCH] lockdep: Fix wait context check on softirq for PREEMPT_RT
Date: Fri, 20 Dec 2024 08:15:54 +0100 [thread overview]
Message-ID: <20241220071554.YAD157bS@linutronix.de> (raw)
In-Reply-To: <Z2Sdv6tSEoxiYW4e@boqun-archlinux>
On 2024-12-19 14:27:11 [-0800], Boqun Feng wrote:
> diff --git a/include/linux/bottom_half.h b/include/linux/bottom_half.h
> index fc53e0ad56d9..7191a753e983 100644
> --- a/include/linux/bottom_half.h
> +++ b/include/linux/bottom_half.h
> @@ -4,6 +4,7 @@
>
> #include <linux/instruction_pointer.h>
> #include <linux/preempt.h>
> +#include <linux/lockdep.h>
>
> #if defined(CONFIG_PREEMPT_RT) || defined(CONFIG_TRACE_IRQFLAGS)
> extern void __local_bh_disable_ip(unsigned long ip, unsigned int cnt);
> @@ -15,9 +16,12 @@ static __always_inline void __local_bh_disable_ip(unsigned long ip, unsigned int
> }
> #endif
>
> +extern struct lockdep_map bh_lock_map;
> +
> static inline void local_bh_disable(void)
> {
> __local_bh_disable_ip(_THIS_IP_, SOFTIRQ_DISABLE_OFFSET);
> + lock_map_acquire_read(&bh_lock_map);
> }
Could you put this before __local_bh_disable_ip(), please?
Sebastian
next prev parent reply other threads:[~2024-12-20 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 1:20 Ryo Takakura
2024-12-02 10:32 ` Peter Zijlstra
2024-12-03 7:49 ` Boqun Feng
2024-12-03 11:57 ` Ryo Takakura
2024-12-09 16:09 ` Ryo Takakura
2024-12-19 22:27 ` Boqun Feng
2024-12-20 7:15 ` Sebastian Andrzej Siewior [this message]
2024-12-20 16:10 ` Ryo Takakura
2024-12-20 19:00 ` Boqun Feng
2024-12-21 5:17 ` Ryo Takakura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220071554.YAD157bS@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=boqun.feng@gmail.com \
--cc=clrkwllms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=ryotkkr98@gmail.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®