From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA8B22ACE7; Fri, 20 Dec 2024 17:12:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734714763; cv=none; b=H85a65WntVtna2h+IvU6i0xrQi0lNevyG93PpnziSCB/sdcF79H8fh9SwCRz5eyykXFeTRZa21YwX6zHsPvA/FcwiCB7YG096ouSawNOuB/Z50Z1YxM25yS7wI5f/Kf+s5YI2Cmcw/AQVIKfVzYTxc2BvrzbweXgIj7zwKqpab4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734714763; c=relaxed/simple; bh=6WUe73xeAO9hrX7y0eaEWRwKco3iF5wRHIx+3vUVjNA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Kd1n+iJroeAsE33gdUYmYFRVVBV2gYQbrO+mgr8/sNeXNrGA/CZR0maMJTiYQ5+Itkb7PaGLSN0I+bLotf3SmxHYw6Yte5ZA3x6XCr/j6Bjt7bSPjmu8og1B3ezatZdiUhh17+3inwV2BFewMbHcqjIE3GMLnx4im84exDB31Ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RVc7FO5q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RVc7FO5q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CFA4C4CED3; Fri, 20 Dec 2024 17:12:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734714763; bh=6WUe73xeAO9hrX7y0eaEWRwKco3iF5wRHIx+3vUVjNA=; h=From:To:Cc:Subject:Date:From; b=RVc7FO5qeuad5XBmcZjPSjIl6lvHb620Nr4dwN0mrvQjQ7b389sdqAJPc7DPIIM9C NdPG/ynwynFtD4vuBu4shcSRNoXKGxNyEm1Kk55+MsphQ/9sTbFS9XxxgfQF/CXWmv qZ31bxCyfIOtTV79IeY6em2x1xRQ4QLiPaBOzHe5qqhAf0RRrGSdLQYT0Q/p+KyT9d 1cJVfXVCsSRAHYZCp92oGLbTHvIpYbunNIuuGROK88dgxQfbK2tOu5/Br54XWUduQo pm00wXX93xb0zGX06eQFWG4w9dqgzYTlAtdXHsQEJvtnCCsS+1mv5EOnQ9bjX9rNsw lc2TsXeQ6hsjw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Issam Hamdi , Johannes Berg , Sasha Levin , johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 01/16] wifi: mac80211: fix mbss changed flags corruption on 32 bit systems Date: Fri, 20 Dec 2024 12:12:25 -0500 Message-Id: <20241220171240.511904-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.67 Content-Transfer-Encoding: 8bit From: Issam Hamdi [ Upstream commit 49dba1ded8dd5a6a12748631403240b2ab245c34 ] On 32-bit systems, the size of an unsigned long is 4 bytes, while a u64 is 8 bytes. Therefore, when using or_each_set_bit(bit, &bits, sizeof(changed) * BITS_PER_BYTE), the code is incorrectly searching for a bit in a 32-bit variable that is expected to be 64 bits in size, leading to incorrect bit finding. Solution: Ensure that the size of the bits variable is correctly adjusted for each architecture. Call Trace: ? show_regs+0x54/0x58 ? __warn+0x6b/0xd4 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? report_bug+0x113/0x150 ? exc_overflow+0x30/0x30 ? handle_bug+0x27/0x44 ? exc_invalid_op+0x18/0x50 ? handle_exception+0xf6/0xf6 ? exc_overflow+0x30/0x30 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? exc_overflow+0x30/0x30 ? ieee80211_link_info_change_notify+0xcc/0xd4 [mac80211] ? ieee80211_mesh_work+0xff/0x260 [mac80211] ? cfg80211_wiphy_work+0x72/0x98 [cfg80211] ? process_one_work+0xf1/0x1fc ? worker_thread+0x2c0/0x3b4 ? kthread+0xc7/0xf0 ? mod_delayed_work_on+0x4c/0x4c ? kthread_complete_and_exit+0x14/0x14 ? ret_from_fork+0x24/0x38 ? kthread_complete_and_exit+0x14/0x14 ? ret_from_fork_asm+0xf/0x14 ? entry_INT80_32+0xf0/0xf0 Signed-off-by: Issam Hamdi Link: https://patch.msgid.link/20241125162920.2711462-1-ih@simonwunderlich.de [restore no-op path for no changes] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/mesh.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c index 25223184d6e5..a5e7edd2f2d1 100644 --- a/net/mac80211/mesh.c +++ b/net/mac80211/mesh.c @@ -1173,14 +1173,14 @@ void ieee80211_mbss_info_change_notify(struct ieee80211_sub_if_data *sdata, u64 changed) { struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh; - unsigned long bits = changed; + unsigned long bits[] = { BITMAP_FROM_U64(changed) }; u32 bit; - if (!bits) + if (!changed) return; /* if we race with running work, worst case this work becomes a noop */ - for_each_set_bit(bit, &bits, sizeof(changed) * BITS_PER_BYTE) + for_each_set_bit(bit, bits, sizeof(changed) * BITS_PER_BYTE) set_bit(bit, ifmsh->mbss_changed); set_bit(MESH_WORK_MBSS_CHANGED, &ifmsh->wrkq_flags); wiphy_work_queue(sdata->local->hw.wiphy, &sdata->work); -- 2.39.5