mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hans Zhang <18255117159@163.com>
Cc: manivannan.sadhasivam@linaro.org, kw@linux.com,
	kishon@kernel.org, arnd@arndb.de, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, rockswang7@gmail.com
Subject: Re: [v2] misc: pci_endpoint_test: Fix return resource_size_t from pci_resource_len
Date: Fri, 20 Dec 2024 09:03:56 +0100	[thread overview]
Message-ID: <2024122035-stimulant-angling-3f42@gregkh> (raw)
In-Reply-To: <20241220075253.16791-1-18255117159@163.com>

On Fri, Dec 20, 2024 at 03:52:53PM +0800, Hans Zhang wrote:
> With 8GB BAR2, running pcitest -b 2 fails with "TEST FAILED".
> 
> The return value of the `pci_resource_len` interface is not an integer.
> Using `pcitest` with an 8GB BAR2, the bar_size of integer type will
> overflow.
> Changing the integer to resource_size_t bar_size resolves this issue.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>
> 
> Changes since v1:
> https://lore.kernel.org/linux-pci/20241217121220.19676-1-18255117159@163.com/
> 
> - The patch subject and commit message were modified.
> ---

The "changes" part goes below the --- line, as the documentation shows.

Please fix up.

thanks,

greg k-h

  reply	other threads:[~2024-12-20  8:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  7:52 Hans Zhang
2024-12-20  8:03 ` Greg KH [this message]
2024-12-20 17:53   ` Hans Zhang
2024-12-20  9:22 ` Markus Elfring
2024-12-20 18:02   ` Hans Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024122035-stimulant-angling-3f42@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=18255117159@163.com \
    --cc=arnd@arndb.de \
    --cc=kishon@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=rockswang7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®