From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCD87083F for ; Fri, 20 Dec 2024 07:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734679047; cv=none; b=IGyCnQQ0EZulhNqHVbTrTDHM6CFY1tlkl1zkzpA0JP4D0XyxsQ3EQe9+tpCGw9fiishLb3ooJifMg1E5ZUeoFrfkroPmnZKCccfWv0XYBIHp9lc3uFMZ7/v24mvZbTRWsx3xbccgr0gmuq9BvRtai9KP4yPfR14IsmmUEKGYQ74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734679047; c=relaxed/simple; bh=66JGBWD3zSGOUxKYNNNdHpDHLbswUejsF9b62jRQ/2c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fk4u9FgNiiKaP0l3k0wfFR8svSIPmVC+VUYQ9xCxM3L+lR2HMY7WsmKvLR/Yudcg28TyHyXwBrt8aX6Ivp+kX0xKtJWv+OU3FBN8dW/Rk3nzs93CoWu3HUrUplT+yaVzxmQ6LO8cdOV4LmeCXQ8FzwGO6e8Unnl5KaFUAYDFslc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I/7wh/I0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I/7wh/I0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0566CC4CECD; Fri, 20 Dec 2024 07:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1734679047; bh=66JGBWD3zSGOUxKYNNNdHpDHLbswUejsF9b62jRQ/2c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I/7wh/I0lt6+bE6HwWXUJDuowytp+1ck3929eDvoo/H92RHHzlQolfNDDxDWHv9Nd ymWgCcSWCvcqNVtvpD83ehL9mnq+g8c1/Wltvr6AnJiQb2IHDcYPgcE2Ch32xVeMgC vAgY1Z91KxQQX9BPtw3vhHMibMvYcwBSfmwTULec= Date: Fri, 20 Dec 2024 08:17:23 +0100 From: Greg Kroah-Hartman To: Alyssa Ross Cc: Arnd Bergmann , "open list:VMWARE VMCI DRIVER" , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list Subject: Re: [PATCH RESEND] VMCI: remove unused ioctl definitions Message-ID: <2024122055-fall-publisher-6f76@gregkh> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Dec 20, 2024 at 12:29:57AM +0100, Alyssa Ross wrote: > IOCTL_VMCI_SOCKETS_VERSION and IOCTL_VMCI_SOCKETS_GET_AF_VALUE were > never implemented, because VSOCK ended up being implemented as a > generic mechanism with a static AF value. Likewise, > IOCTL_VMCI_SOCKETS_GET_LOCAL_CID ended up being implemented as > IOCTL_VM_SOCKETS_GET_LOCAL_CID. > > This isn't a UAPI header, so it should be fine to remove the unused > values. I've left a comment noting IOCTL_VM_SOCKETS_GET_LOCAL_CID is > in the VMCI range to avoid unintentional reuse. > > Signed-off-by: Alyssa Ross > --- > Hi misc maintainers! I'm sending this version of the patch to you > because the VMWare VMCI maintainers don't seem to be around any more. > The last message on lore from either of them was in May. Since then, > I've submitted this patch twice, and haven't heard anything in response. > > include/linux/vmw_vmci_defs.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h > index 6fb663b36f72..c2df94696593 100644 > --- a/include/linux/vmw_vmci_defs.h > +++ b/include/linux/vmw_vmci_defs.h > @@ -453,9 +453,7 @@ enum { > #define IOCTL_VMCI_CTX_GET_CPT_STATE _IO(7, 0xb1) > #define IOCTL_VMCI_CTX_SET_CPT_STATE _IO(7, 0xb2) > #define IOCTL_VMCI_GET_CONTEXT_ID _IO(7, 0xb3) > -#define IOCTL_VMCI_SOCKETS_VERSION _IO(7, 0xb4) > -#define IOCTL_VMCI_SOCKETS_GET_AF_VALUE _IO(7, 0xb8) > -#define IOCTL_VMCI_SOCKETS_GET_LOCAL_CID _IO(7, 0xb9) > +/*IOCTL_VM_SOCKETS_GET_LOCAL_CID _IO(7, 0xb9)*/ Why is just this one left as a comment? Shoudn't you just delet them all? thanks, greg k-h