From: Anandu Krishnan E <quic_anane@quicinc.com>
To: <srinivas.kandagatla@linaro.org>, <linux-arm-msm@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <quic_bkumar@quicinc.com>,
<linux-kernel@vger.kernel.org>, <quic_chennak@quicinc.com>,
<dri-devel@lists.freedesktop.org>, <arnd@arndb.de>,
stable <stable@kernel.org>
Subject: [PATCH v2 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios
Date: Mon, 23 Dec 2024 15:31:00 +0530 [thread overview]
Message-ID: <20241223100101.29844-2-quic_anane@quicinc.com> (raw)
In-Reply-To: <20241223100101.29844-1-quic_anane@quicinc.com>
During fastrpc_rpmsg_probe, if secure device node registration
succeeds but non-secure device node registration fails, the secure
device node deregister is not called during error cleanup. Add proper
exit paths to ensure proper cleanup in case of error.
Fixes: 3abe3ab3cdab ("misc: fastrpc: add secure domain support")
Cc: stable <stable@kernel.org>
Signed-off-by: Anandu Krishnan E <quic_anane@quicinc.com>
---
drivers/misc/fastrpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 48d08eeb2d20..ff144f0aa337 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -2344,7 +2344,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
err = fastrpc_device_register(rdev, data, false, domains[domain_id]);
if (err)
- goto fdev_error;
+ goto populate_error;
break;
default:
err = -EINVAL;
--
2.17.1
next prev parent reply other threads:[~2024-12-23 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 10:00 [PATCH v2 0/2] Improve error handling in fastrpc_rpmsg_probe Anandu Krishnan E
2024-12-23 10:01 ` Anandu Krishnan E [this message]
2024-12-23 10:10 ` [PATCH v2 1/2] misc: fastrpc: Deregister device nodes properly in error scenarios Greg KH
2024-12-23 10:30 ` Anandu Krishnan E
2024-12-23 10:19 ` Dmitry Baryshkov
2024-12-23 10:41 ` Anandu Krishnan E
2024-12-23 10:01 ` [PATCH v2 2/2] misc: fastrpc: Add meaningful labels for exit paths Anandu Krishnan E
2024-12-23 10:20 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223100101.29844-2-quic_anane@quicinc.com \
--to=quic_anane@quicinc.com \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®