From: Eric Biggers <ebiggers@kernel.org>
To: Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
Cc: manivannan.sadhasivam@linaro.org,
James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, andersson@kernel.org,
bvanassche@acm.org, linux-arm-msm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Naveen Kumar Goud Arepalli <quic_narepall@quicinc.com>,
Nitin Rawat <quic_nitirawa@quicinc.com>
Subject: Re: [PATCH V6] scsi: ufs: qcom: Enable UFS Shared ICE Feature
Date: Mon, 23 Dec 2024 11:31:30 -0800 [thread overview]
Message-ID: <20241223193130.GA2032@quark.localdomain> (raw)
In-Reply-To: <20241223132033.11706-1-quic_rdwivedi@quicinc.com>
On Mon, Dec 23, 2024 at 06:50:33PM +0530, Ram Kumar Dwivedi wrote:
> #ifdef CONFIG_SCSI_UFS_CRYPTO
> +/**
> + * ufs_qcom_config_ice_allocator() - ICE core allocator configuration
> + *
> + * @host: pointer to qcom specific variant structure.
> + */
> +static void ufs_qcom_config_ice_allocator(struct ufs_qcom_host *host)
> +{
> + struct ufs_hba *hba = host->hba;
> + static const uint8_t val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
> + u32 config;
> +
> + if (!is_ice_config_supported(host))
> + return;
This is the only place that is_ice_config_supported() is called, so the helper
function seems unnecessary vs. just checking UFS_QCOM_CAP_ICE_CONFIG directly.
Also, shouldn't any ICE configuration also be conditional on UFSHCD_CAP_CRYPTO?
Just in case the ICE support got turned off for some reason.
- Eric
next prev parent reply other threads:[~2024-12-23 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 13:20 Ram Kumar Dwivedi
2024-12-23 19:31 ` Eric Biggers [this message]
2024-12-24 15:50 ` Ram Kumar Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223193130.GA2032@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andersson@kernel.org \
--cc=bvanassche@acm.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rdwivedi@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®