From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ethan Carter Edwards <ethan@ethancedwards.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: sparc: change kzalloc to kcalloc
Date: Tue, 24 Dec 2024 09:49:49 +0530 [thread overview]
Message-ID: <20241224041949.ewmo3f5beyuoilsv@vireshk-i7> (raw)
In-Reply-To: <e3fXwH1TSclUunsB_ocTKA411JNgc8KozFJo9rGansdyTkxV-f6sj-TrJWBKXNs-DdlQTF-YEWRl_UcFQ_kQUCCEMsUUgnYQjiFrvWMrtYs=@ethancedwards.com>
On 23-12-24, 14:41, Ethan Carter Edwards wrote:
> Refactor to use kcalloc instead of kzalloc when multiplying
> allocation size by count. This refactor prevents unintentional
> memory overflows. Discovered by checkpatch.pl.
>
> Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
> ---
> drivers/cpufreq/sparc-us2e-cpufreq.c | 2 +-
> drivers/cpufreq/sparc-us3-cpufreq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-us2e-cpufreq.c
> index 8a0cd5312a59..15899dd77c08 100644
> --- a/drivers/cpufreq/sparc-us2e-cpufreq.c
> +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c
> @@ -323,7 +323,7 @@ static int __init us2e_freq_init(void)
> impl = ((ver >> 32) & 0xffff);
>
> if (manuf == 0x17 && impl == 0x13) {
> - us2e_freq_table = kzalloc(NR_CPUS * sizeof(*us2e_freq_table),
> + us2e_freq_table = kcalloc(NR_CPUS, sizeof(*us2e_freq_table),
> GFP_KERNEL);
> if (!us2e_freq_table)
> return -ENOMEM;
> diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us3-cpufreq.c
> index b50f9d13e6d2..de50a2f3b124 100644
> --- a/drivers/cpufreq/sparc-us3-cpufreq.c
> +++ b/drivers/cpufreq/sparc-us3-cpufreq.c
> @@ -171,7 +171,7 @@ static int __init us3_freq_init(void)
> impl == CHEETAH_PLUS_IMPL ||
> impl == JAGUAR_IMPL ||
> impl == PANTHER_IMPL)) {
> - us3_freq_table = kzalloc(NR_CPUS * sizeof(*us3_freq_table),
> + us3_freq_table = kcalloc(NR_CPUS, sizeof(*us3_freq_table),
> GFP_KERNEL);
> if (!us3_freq_table)
> return -ENOMEM;
Applied. Thanks.
Though I failed to apply it directly using git/b4 for some reason, had
to manually make the updates and commit.
--
viresh
prev parent reply other threads:[~2024-12-24 4:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 14:41 Ethan Carter Edwards
2024-12-24 4:19 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241224041949.ewmo3f5beyuoilsv@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=ethan@ethancedwards.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®