From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Arnd Bergmann <arnd@arndb.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
Daniel Gomez <da.gomez@samsung.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-modules@vger.kernel.org,
"Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH RFC 0/2] module: Introduce hash-based integrity checking
Date: Wed, 25 Dec 2024 23:51:58 +0100 [thread overview]
Message-ID: <20241225-module-hashes-v1-0-d710ce7a3fd1@weissschuh.net> (raw)
The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds:
Either the module signing key is generated at build time, which makes
the build unreproducible, or a static key is used, which precludes
rebuilds by third parties and makes the whole build and packaging
process much more complicated.
Introduce a new mechanism to ensure only well-known modules are loaded
by embedding a list of hashes of all modules built as part of the full
kernel build into vmlinux.
To properly test the reproducibility in combination with BTF the patch
"[PATCH bpf-next] kbuild, bpf: Enable reproducible BTF generation" [0]
is also needed.
Questions for current patch:
* Naming
* Can the number of built-in modules be retrieved while building
kernel/module/hashes.o? This would remove the need for the
preallocation step in link-vmlinux.sh.
Further improvements:
* Use a LSM/IMA/Keyring to store and validate hashes
* Make compatible with lockdown
* Use MODULE_SIG_HASH for configuration
* Enable coexistence with MODULE_SIG
* Set mod->sig_ok()
* UAPI for discovery?
[0] https://lore.kernel.org/lkml/20241211-pahole-reproducible-v1-1-22feae19bad9@weissschuh.net/
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (2):
kbuild: add stamp file for vmlinux BTF data
module: Introduce hash-based integrity checking
Makefile | 8 +++++-
include/asm-generic/vmlinux.lds.h | 11 +++++++++
include/linux/module_hashes.h | 17 +++++++++++++
kernel/module/Kconfig | 11 +++++++++
kernel/module/Makefile | 1 +
kernel/module/hashes.c | 51 +++++++++++++++++++++++++++++++++++++++
kernel/module/internal.h | 9 +++++++
kernel/module/main.c | 4 +++
scripts/Makefile.modfinal | 4 +--
scripts/Makefile.vmlinux | 5 ++++
scripts/link-vmlinux.sh | 31 +++++++++++++++++++++++-
scripts/module-hashes.sh | 26 ++++++++++++++++++++
12 files changed, 174 insertions(+), 4 deletions(-)
---
base-commit: f722972b5df307d8c93c706c62d2e27e963c8f66
change-id: 20241225-module-hashes-7a50a7cc2a30
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
next reply other threads:[~2024-12-25 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 22:51 Thomas Weißschuh [this message]
2024-12-25 22:51 ` [PATCH RFC 1/2] kbuild: add stamp file for vmlinux BTF data Thomas Weißschuh
2024-12-25 22:52 ` [PATCH RFC 2/2] module: Introduce hash-based integrity checking Thomas Weißschuh
2025-01-04 1:37 ` Luis Chamberlain
2025-01-04 6:30 ` Thomas Weißschuh
2025-01-08 19:08 ` Luis Chamberlain
2025-01-13 9:15 ` Fabian Grünbichler
2025-01-09 10:52 ` Arnout Engelen
2025-01-10 19:16 ` Luis Chamberlain
2025-01-13 15:09 ` Petr Pavlu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241225-module-hashes-v1-0-d710ce7a3fd1@weissschuh.net \
--to=linux@weissschuh.net \
--cc=arnd@arndb.de \
--cc=da.gomez@samsung.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=petr.pavlu@suse.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®