From: Atharva Tiwari <evepolonium@gmail.com>
Cc: evepolonium@gmail.com, Willy Tarreau <willy@haproxy.com>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] auxdisplay: panel: replace struct with union for display configuration
Date: Wed, 25 Dec 2024 23:11:18 +0530 [thread overview]
Message-ID: <20241225174120.100698-1-evepolonium@gmail.com> (raw)
this patch replaces a struct with a union in the panel.c driver
to better represent display configuration as mentioned in TODO
Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
drivers/auxdisplay/panel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index a731f28455b4..4662f763dac7 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -204,8 +204,7 @@ static struct {
int charset;
int proto;
- /* TODO: use union here? */
- struct {
+ union {
int e;
int rs;
int rw;
--
2.39.5
next reply other threads:[~2024-12-25 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 17:41 Atharva Tiwari [this message]
2024-12-25 17:46 ` Willy TARREAU
2024-12-25 18:06 ` Atharva Tiwari
2024-12-25 22:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241225174120.100698-1-evepolonium@gmail.com \
--to=evepolonium@gmail.com \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ksenija.stanojevic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=willy@haproxy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®