From: Damon Ding <damon.ding@rock-chips.com>
To: heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
rfoss@kernel.org, vkoul@kernel.org,
sebastian.reichel@collabora.com,
cristian.ciocaltea@collabora.com, l.stach@pengutronix.de,
andy.yan@rock-chips.com, hjc@rock-chips.com,
algea.cao@rock-chips.com, kever.yang@rock-chips.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: [PATCH v4 17/17] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board
Date: Thu, 26 Dec 2024 14:33:13 +0800 [thread overview]
Message-ID: <20241226063313.3267515-18-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20241226063313.3267515-1-damon.ding@rock-chips.com>
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board:
- Set pinctrl of pwm12 for backlight
- Enable edp0/hdptxphy0/vp2
- Add aux-bus/panel nodes
The eDP panel model used on this board is LP079QX1_SP0V. Due to the
broken identification, the compatible of panel node is set to
"lg,lp079qx1-sp0v" rather than "edp-panel". The log related to this
issue may be like:
[ 0.623793] panel-simple-dp-aux aux-fdec0000.edp: Unknown panel ETC
0x0000, using conservative timings
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---
Changes in v2:
- Remove brightness-levels and default-brightness-level properties in
backlight node.
- Add the detail DT changes to commit message.
Changes in v3:
- Use aux-bus instead of platform bus for edp-panel.
Changes in v4:
- Add comments related to the use of panel compatible "lg,lp079qx1-sp0v"
in the commit message.
---
.../boot/dts/rockchip/rk3588s-evb1-v10.dts | 52 +++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts
index bc4077575beb..9547ab18e596 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts
@@ -9,6 +9,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
#include <dt-bindings/usb/pd.h>
#include "rk3588s.dtsi"
@@ -238,6 +239,41 @@ &combphy2_psu {
status = "okay";
};
+&edp0 {
+ force-hpd;
+ status = "okay";
+
+ aux-bus {
+ panel {
+ compatible = "lg,lp079qx1-sp0v";
+ backlight = <&backlight>;
+ power-supply = <&vcc3v3_lcd_edp>;
+
+ port {
+ panel_in_edp: endpoint {
+ remote-endpoint = <&edp_out_panel>;
+ };
+ };
+ };
+ };
+};
+
+&edp0_in {
+ edp0_in_vp2: endpoint {
+ remote-endpoint = <&vp2_out_edp0>;
+ };
+};
+
+&edp0_out {
+ edp_out_panel: endpoint {
+ remote-endpoint = <&panel_in_edp>;
+ };
+};
+
+&hdptxphy0 {
+ status = "okay";
+};
+
&i2c3 {
status = "okay";
@@ -399,6 +435,7 @@ usbc0_int: usbc0-int {
};
&pwm12 {
+ pinctrl-0 = <&pwm12m1_pins>;
status = "okay";
};
@@ -1168,3 +1205,18 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 {
};
};
};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vop {
+ status = "okay";
+};
+
+&vp2 {
+ vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 {
+ reg = <ROCKCHIP_VOP2_EP_EDP0>;
+ remote-endpoint = <&edp0_in_vp2>;
+ };
+};
--
2.34.1
prev parent reply other threads:[~2024-12-26 6:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-26 6:32 [PATCH v4 00/17] Add eDP support for RK3588 Damon Ding
2024-12-26 6:32 ` [PATCH v4 01/17] drm/rockchip: analogix_dp: Use formalized struct definition for grf field Damon Ding
2024-12-26 6:32 ` [PATCH v4 02/17] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 Damon Ding
2024-12-27 7:13 ` Krzysztof Kozlowski
2025-01-06 7:28 ` Damon Ding
2024-12-26 6:32 ` [PATCH v4 03/17] drm/rockchip: analogix_dp: " Damon Ding
2024-12-26 6:33 ` [PATCH v4 04/17] phy: phy-rockchip-samsung-hdptx: Swap the definitions of LCPLL_REF and ROPLL_REF Damon Ding
2024-12-30 12:33 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 05/17] phy: phy-rockchip-samsung-hdptx: Supplement some register names with their full version Damon Ding
2024-12-30 12:33 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 06/17] phy: phy-rockchip-samsung-hdptx: Add the '_MASK' suffix to all registers Damon Ding
2024-12-30 12:34 ` Dmitry Baryshkov
2025-01-06 9:09 ` Damon Ding
2024-12-26 6:33 ` [PATCH v4 07/17] phy: phy-rockchip-samsung-hdptx: Add support for eDP mode Damon Ding
2024-12-30 12:45 ` Dmitry Baryshkov
2025-01-07 3:02 ` Damon Ding
2025-01-07 10:55 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 08/17] drm/bridge: analogix_dp: Add support for RK3588 Damon Ding
2024-12-30 12:45 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 09/17] drm/bridge: analogix_dp: Add support for phy configuration Damon Ding
2024-12-29 4:48 ` Dmitry Baryshkov
2024-12-30 12:47 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 10/17] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus Damon Ding
2024-12-27 7:53 ` Krzysztof Kozlowski
2025-01-06 6:50 ` Damon Ding
2024-12-26 6:33 ` [PATCH v4 11/17] drm/bridge: analogix_dp: Add a new member aux to struct analogix_dp_plat_data Damon Ding
2024-12-26 6:33 ` [PATCH v4 12/17] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus Damon Ding
2024-12-30 12:51 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 13/17] drm/bridge: analogix_dp: Convert &analogix_dp_device.aux into a pointer Damon Ding
2024-12-30 13:35 ` Dmitry Baryshkov
[not found] ` <e2a18f8c-dc38-4b12-968e-dd369cb34cb4@rock-chips.com>
2025-01-06 12:09 ` Dmitry Baryshkov
2024-12-26 6:33 ` [PATCH v4 14/17] dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588 HDMI TX Controller Damon Ding
2024-12-26 6:33 ` [PATCH v4 15/17] arm64: dts: rockchip: Fix label name of hdptxphy for RK3588 Damon Ding
2024-12-26 6:33 ` [PATCH v4 16/17] arm64: dts: rockchip: Add eDP0 node " Damon Ding
2024-12-26 6:33 ` Damon Ding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241226063313.3267515-18-damon.ding@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=algea.cao@rock-chips.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®