From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B41614E2E2 for ; Thu, 26 Dec 2024 21:16:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735247805; cv=none; b=gH7GKZoz31cTwXmxd0mSVjJRO3dMLe6Jrwnt2AHC5uCLGGl2kJMEQa9iSH7oKk7LpBZm+9q7m0lR0VI+g+VEaDZ/JB8HNv9Q08UmOubjelxQZSyUO2ChtbtjhncVNVD6g7ti8Xd96t6Pt9xG3b1jJ/JLT0nEyfU6ek7mo6VQxo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735247805; c=relaxed/simple; bh=VRwMCA2zwBkJYhRyo6JEOwDMDKc61F8Xp5wOAWP4wcA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Z/KjAVhixqmi6t0TFWfFlIOC852L9+vGxVOA1QO02jMwqeTdftw4gn7YHA7rLi/qUAkavOerpIQHTsf/VsqNGTLD8ulTPMNxfpWxAdR8dCRVozWmh8vpg5UkUkUKd+zl0LWFPe8IA/Ua0PCKTrjRTqX6yxA/9dfNHD5hKgs/pgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=U2WZLKhh; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="U2WZLKhh" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2161d185f04so62270985ad.3 for ; Thu, 26 Dec 2024 13:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735247802; x=1735852602; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Q6FNZCc0sjlAu9/bhUu0wi3B3hcHiZVxRsWdZ9fDpqQ=; b=U2WZLKhhc145jEbYIu9lN5YVv2iAYPMfC3MlYgCj0RZ9p6AVEuhkcDxncadLXhkbUl N9N2ooZjyDZ+bhAp9vcpy329rnQ5UlJ4mHz0Amy2cfEt/RPJZQs3RPoNDxMGIrCs6fTG fL8qNtTE+8Nm9EWk5fiCL63weZvTxmDzNCFXOqZYI65XeF/JoUQT/w1G7Dw5z19RYVkD 98ysuL+J/vhqDJ3ZKkv3lAdnbBREFftC5XFbWxkfa8y3ETp7s63j7Bm5r7VLosLz/ZTS oPUEEUc4fZUYkW3lfm5StA3aJ8N3T7AhuIrseDIoVUH4hE1LtkTKv39d78RiiyiyDeei P0Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735247802; x=1735852602; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Q6FNZCc0sjlAu9/bhUu0wi3B3hcHiZVxRsWdZ9fDpqQ=; b=hNxVF5KdY3RyKbc7ugDBdqNDcvsrHxLVEkuX/BTUr41zuSHDRs8Gh8XJB3JZU41zz0 OE9Bt65MVeyfh1k706SOrIbWQG1VxapN7i1iQtuFG7fVYzMzD1TQGOC+vz8sx90UjjqA Wak1yXAgyctAeB5n8jq5BM3aBc2zvx3g6K8RT6eVgr9k2n0/W3lTl2io11DLTBPNNx7e kaoc2yGyJp8AGzMP0w64wp+uew8wNxLTUjv3t0/K94QMn/rBDN3yR6K4HGE8yoST70mr tdfdMHBnBSwmakgJY0dSN+0A+hyQFm7bu9J3YoiNVCvtEASRrWcKgR8RISUdmFGhisK3 1bEA== X-Forwarded-Encrypted: i=1; AJvYcCViC8FnCKTYZf9Ax/eX52XJXAPrGgtOOAq+2kk/QEx1SlGs/fIxmz0vQZvnIWMfea121wk2QKmhE4KUhbU=@vger.kernel.org X-Gm-Message-State: AOJu0YxpPjf1W5Qtfws33ob7iRN18rjdN6kEPKxUOb2HLi+7GYvmj1Gh U5wna1DwBZNr+5qo1W5rDlTKDZ2ZOljHZkvkgBz3nT/00erbUEuiiRpwkPzMQCVGNbkEX9SReMZ LQA== X-Google-Smtp-Source: AGHT+IGsluvjCQPIRlC11GbC/0U5YyE5MLWsBDKc3jJjY6kkkDpn4HpS6bMUSx/UCZvtrYHO7zXLvRubfMA= X-Received: from plly7.prod.google.com ([2002:a17:902:7c87:b0:219:21b2:3071]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d4cf:b0:216:2426:767f with SMTP id d9443c01a7336-219e6f25d6bmr291166905ad.49.1735247802375; Thu, 26 Dec 2024 13:16:42 -0800 (PST) Date: Thu, 26 Dec 2024 13:16:38 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20241226211639.1357704-1-surenb@google.com> Subject: [PATCH 1/2] alloc_tag: avoid current->alloc_tag manipulations when profiling is disabled From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, yuzhao@google.com, 00107082@163.com, quic_zhenhuah@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Suren Baghdasaryan , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" When memory allocation profiling is disabled there is no need to update current->alloc_tag and these manipulations add unnecessary overhead. Fix the overhead by skipping these extra updates. Fixes: b951aaff5035 ("mm: enable page allocation tagging") Signed-off-by: Suren Baghdasaryan Cc: stable@vger.kernel.org --- include/linux/alloc_tag.h | 11 ++++++++--- lib/alloc_tag.c | 2 ++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h index 0bbbe537c5f9..a946e0203e6d 100644 --- a/include/linux/alloc_tag.h +++ b/include/linux/alloc_tag.h @@ -224,9 +224,14 @@ static inline void alloc_tag_sub(union codetag_ref *ref, size_t bytes) {} #define alloc_hooks_tag(_tag, _do_alloc) \ ({ \ - struct alloc_tag * __maybe_unused _old = alloc_tag_save(_tag); \ - typeof(_do_alloc) _res = _do_alloc; \ - alloc_tag_restore(_tag, _old); \ + typeof(_do_alloc) _res; \ + if (mem_alloc_profiling_enabled()) { \ + struct alloc_tag * __maybe_unused _old; \ + _old = alloc_tag_save(_tag); \ + _res = _do_alloc; \ + alloc_tag_restore(_tag, _old); \ + } else \ + _res = _do_alloc; \ _res; \ }) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index 7dcebf118a3e..4c373f444eb1 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -29,6 +29,8 @@ EXPORT_SYMBOL(_shared_alloc_tag); DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, mem_alloc_profiling_key); +EXPORT_SYMBOL(mem_alloc_profiling_key); + DEFINE_STATIC_KEY_FALSE(mem_profiling_compressed); struct alloc_tag_kernel_section kernel_tags = { NULL, 0 }; base-commit: 431614f1580a03c1a653340c55ea76bd12a9403f -- 2.47.1.613.gc27f4b7a9f-goog