From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DD9139579 for ; Fri, 27 Dec 2024 22:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735338146; cv=none; b=CvQlIStwu18pPxyeaLrQWH2c7QfyH/fLESONpywV26NvVjNdc0YvZPtJpF5xSXJSlhWJ+A2iUOgLIa1hZ5AVNJAt2hQdQptQees0cx+UrXFAz1jqC6xrS9WiJ1X/bEZif1DDq6r+p6HEfv5NcBKIS1I5g2TTr3bRNmB+u9xw7Qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735338146; c=relaxed/simple; bh=DECJCJ5W2Mfqb3OaAr+45GKnlU5KPuOLJXq8rXrJSbM=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=YCN84PNsr5b2uy0ZBj0j9LD0CWmfK7mVkmg4vucpOIGZOU7yV2XVc9oQC1QuDITK5mVWgfJfGexq8fTxd7VxwlIt1UaAauXStqcrLKhYYIa+uONRKNiDGc2k4OrvQd8YD6ZRLm5R79z8YGC3rDDTvOF8lpSnHs6UNgt2IXa4wAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=z+/LTyGN; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="z+/LTyGN" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2ef6ef86607so10089844a91.0 for ; Fri, 27 Dec 2024 14:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1735338144; x=1735942944; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=S3YIhx1kis3t5L00tJpzKJMiDn2NcWa5gcGaiY7KHn0=; b=z+/LTyGNU8WOILKmX9TZNw7Q+dJCw94ICwJzIn13kXkKY9n5J+pXSowpPKnM/CH5cc Qx2IWMEKBSm4RugZF9AsbU5f3qpEFsnPB0n/3xIJq1PJh3TOQ8ka0wxUCrWIH3fPgK0x OHGdWtmek4XG2l0rK56vY7KNOa0n/oeB76zPwyu598EarHcaWnwEYMyHr0J16yeR/MTe w7/WshbwF+6u2RCcrMyFuqt6zpy65VFeoyLNRDsqw2CMs9vUcmkiFaqwG7QHUxF/b4gB WA5Nb9LvxaG1y/qduahk8B9Y25HK/KjmMnpVQW3vlTM+6Num8k2lA+6RcN2T5LjaA1ij Z55Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735338144; x=1735942944; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=S3YIhx1kis3t5L00tJpzKJMiDn2NcWa5gcGaiY7KHn0=; b=lwVHK4qqsJrg0llLDuDq5DjzNbpwc+nive0KhLIZCPqsqKt9KI2IXpJwfH8BKcA1dV Eva/qt7EeAlQcWiVRZkUEDSKow6pDaS8pcikSkl5QThNVycrDBNA5cj/hUKVrB2UaVVw V3LZFPvIm9e9XyDhPhOPEdL5fa6BdNUXmVgTijIfsTzzRVXkdK7v5CXoUXfigfwRp2dT f6weCwX/p4p4++/Ve2FXItbnp7kiXMbbniox7dxN74foii0dvZLEe8XlS9zqL1MZ09wN Bfut2qtaizo67Np2pXfipivv266dti7jfB0DM5V/scQE+eoHqvojYFE42n7xS+r82S6V ff8w== X-Forwarded-Encrypted: i=1; AJvYcCVz6wNkJLkL++J+JKFArj0mYWntvzavbhNUX8LO4onOq+TaLgnFCQvo+nz4YDtjE0dkGN9fBT6xNB5pKCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsbsp1rk9d9/F9VVkxgS8WHlbWL+zyHuHFJVnVBO+fKmy63mNh y63g0KUgGvh86gUc1PaQ74WgV6c4O0O49zQ+vxaxG1q56C15/r2yhIdnsYcPHrbF5tzP9Jgw3r1 qww== X-Google-Smtp-Source: AGHT+IG8FfIpKjagm1KOnTOA+o2Rfqw8ZqOAcZ8ufVkpQsvDM7z8NwLcXVPzUoRPXoopIKuCEHNMnz7wt6s= X-Received: from pjbqd4.prod.google.com ([2002:a17:90b:3cc4:b0:2ef:8f54:4254]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3a43:b0:2ee:94a0:255c with SMTP id 98e67ed59e1d1-2f4536d25fcmr43028889a91.13.1735338143914; Fri, 27 Dec 2024 14:22:23 -0800 (PST) Date: Fri, 27 Dec 2024 14:22:20 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20241227222220.1726384-1-surenb@google.com> Subject: [PATCH 1/1] tools: fix atomic_set() definition to set the value correctly From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" Currently vma test is failing because of the new vma_assert_attached() assertion. The check is failing because previous refcount_set() inside vma_mark_attached() is a NoOp. Fix the definition of atomic_set() to correctly set the value of the atomic. Fixes: 9325b8b5a1cb ("tools: add skeleton code for userland testing of VMA logic") Signed-off-by: Suren Baghdasaryan --- Applies over mm-unstable tools/testing/shared/linux/maple_tree.h | 2 +- tools/testing/vma/linux/atomic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/shared/linux/maple_tree.h b/tools/testing/shared/linux/maple_tree.h index 06c89bdcc515..f67d47d32857 100644 --- a/tools/testing/shared/linux/maple_tree.h +++ b/tools/testing/shared/linux/maple_tree.h @@ -2,6 +2,6 @@ #define atomic_t int32_t #define atomic_inc(x) uatomic_inc(x) #define atomic_read(x) uatomic_read(x) -#define atomic_set(x, y) do {} while (0) +#define atomic_set(x, y) uatomic_set(x, y) #define U8_MAX UCHAR_MAX #include "../../../../include/linux/maple_tree.h" diff --git a/tools/testing/vma/linux/atomic.h b/tools/testing/vma/linux/atomic.h index 2e2021553196..788c597c4fde 100644 --- a/tools/testing/vma/linux/atomic.h +++ b/tools/testing/vma/linux/atomic.h @@ -6,7 +6,7 @@ #define atomic_t int32_t #define atomic_inc(x) uatomic_inc(x) #define atomic_read(x) uatomic_read(x) -#define atomic_set(x, y) do {} while (0) +#define atomic_set(x, y) uatomic_set(x, y) #define U8_MAX UCHAR_MAX #ifndef atomic_cmpxchg_relaxed -- 2.47.1.613.gc27f4b7a9f-goog