From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDD33198E77 for ; Sat, 28 Dec 2024 18:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735411800; cv=none; b=TI/0oHfSRijrMhNwf9QEQ+jBJKL6VjWGaKd5dGwk/qZDU5BMRTCcsd3/05TC0KKhl4pdLHB7NbuTkY5iiN6qJvKl8h27HvbJpVpxTYeec3UdvqIGYv3OV7jp1Aiw5iQfUhnFxlRwlclJlQQb6O54AaSbe1GIwlCZRnttJVOLRdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735411800; c=relaxed/simple; bh=+Zwsfy6YH5CS10fTclDUEdCV+0IQUSu1rzL9TeANRqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JeSfcwNjm62Qh8U2WWm/0hkdvFCZazZr2su1wqMqjaBJPyAB2VRtpFe33Ql4LmQ2tYKE4vFYYx+SL4wOw/F393taaSBFE10jJJJTQBpRgydmmc3DmqjOiwjEFWQNgH0MhvDsKNVmfeYpOJi2sNwNt2olCI5tdcdcDisinLQSkzM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W/mhpudH; arc=none smtp.client-ip=209.85.219.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W/mhpudH" Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e3f78f5fc07so7668654276.2 for ; Sat, 28 Dec 2024 10:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735411798; x=1736016598; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ubvhjam4awIBMi5vwHaqj7zTIr7vOK16Tu3+fo0j/yY=; b=W/mhpudHY5BJ+Vv4OsRpSfdcI9DyhxiNAX/xzJ+Dx4/qQG2E3mrQIs4Ep2huTwrekg pHCQdZpOBO9gIUeDR/dG9ev6kICh7Tut5hKSmK59AiJFL7Oe2v8rz7WkbJgBnTJ2Xr5P 67AIjCEU+8URoqOd0/Wz+gQTCAzHbUMXrVhBOZvxFXoQ74FbtMf7srhzAkv+lgOmztfi 0t0hXAkldwd2/qgDUGVr0TgbZ1veb6zbKX6SKOT+fnrr6eXfN3z3xXrHckkvRaMcoTG8 3VbKOmu2sb0QwvXkd1KgONjbUmTocoxegnIvxP1nrl1CZI108N920G69iMPSW8SScjGj ZPRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735411798; x=1736016598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubvhjam4awIBMi5vwHaqj7zTIr7vOK16Tu3+fo0j/yY=; b=U//rhXzEgCn/eZQyMit/AO9NQIGNi3+n5TOZLq7wyJCnFvMVbYRKcCJWY4fiewwXrD /jAN4HMo/gnWAEF2cikCnhbTiVQrRIllXRyStpi3RVPOy5gYKNFlP7rdgyrQXLli/Sbo fNsTdlO4shMqxwjbQUHq4c4m1dQQOUPlw26NJhoekeGmfLMqHwchdAdiph07vQpEXAD7 8vOKBOsq6n6ng1mz6S6+Eu3oybXtqQhuiWT1mmLQWQOQKzrLpceQdFzit1y48DC09xeA MCrniVjUkwj4zDEfzXMNs9wnaMDPiNmHv5XuEUtbgX3kboUIlV/tzuzkAimmKht8ck5W vD3w== X-Gm-Message-State: AOJu0Yy1CI3sUsKD8SChFi5p5VTBcol3IoYDy9IoP5MJzKR0ocL6iCQz tezLk/TKDMVBvB/g+RLeL8SfNDglbCOBg1jUqekbV4jh3IPw/yzjdX5zlEPc X-Gm-Gg: ASbGnctu1jM4wxBci/bnj3TgZFvdPGixoYaGcDU+3qRYRHq1L+bhZTAR7TmgK0KaGJW LBR1tHjvFxbIjlsFB+/IUf+Qb+HIWE1S7LohUHeP2pMxuMCUloBzXBqb060bBx8+TYf7ykrV8B9 MdDhf0pXRxPakXtz9f6sgMKwkL3wx/N+uXfYmUFVa2lepBBBCCmhsvflxVAkJBwF9CsIGCupL+R Erv2r4JeZaGwxYyRtL0UNjz+OIKt8k81b02qsEVAPHKvh6hxHf6N+UjRPOwrwwEXIw1rz+CPBWc 32R7kt2+3v/IGd/P X-Google-Smtp-Source: AGHT+IFOOrRjg39+N/+YbDIKjS25mXKDV3xCERSc4aweH33rlFnOKc3HKrVsOs1V9UwfUjO4oOeNyw== X-Received: by 2002:a05:690c:7203:b0:6f0:21d6:449a with SMTP id 00721157ae682-6f3f80e60a1mr233362847b3.6.1735411796540; Sat, 28 Dec 2024 10:49:56 -0800 (PST) Received: from localhost (c-24-129-28-254.hsd1.fl.comcast.net. [24.129.28.254]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6f3e77ee159sm48206467b3.87.2024.12.28.10.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Dec 2024 10:49:55 -0800 (PST) From: Yury Norov To: linux-kernel@vger.kernel.org, Matt Wu Cc: Yury Norov , Rasmus Villemoes Subject: [PATCH 01/14] objpool: rework objpool_pop() Date: Sat, 28 Dec 2024 10:49:33 -0800 Message-ID: <20241228184949.31582-2-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241228184949.31582-1-yury.norov@gmail.com> References: <20241228184949.31582-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function has to track number of iterations to prevent an infinite loop. for_each_cpu_wrap() macro takes care of it, which simplifies user code. Similarly to for_each_possible_cpu() flavor, this patch introduces for_each_possible_cpu_wrap() version of iterator to keep usage of the API simple and coherent. Signed-off-by: Yury Norov --- include/linux/cpumask.h | 6 ++++++ include/linux/objpool.h | 7 +++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h index 9278a50d514f..5cf69a110c1c 100644 --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -1033,11 +1033,17 @@ extern const DECLARE_BITMAP(cpu_all_bits, NR_CPUS); #define for_each_possible_cpu(cpu) for ((cpu) = 0; (cpu) < 1; (cpu)++) #define for_each_online_cpu(cpu) for ((cpu) = 0; (cpu) < 1; (cpu)++) #define for_each_present_cpu(cpu) for ((cpu) = 0; (cpu) < 1; (cpu)++) + +#define for_each_possible_cpu_wrap(cpu, start) \ + for ((void)(start), (cpu) = 0; (cpu) < 1; (cpu)++) #else #define for_each_possible_cpu(cpu) for_each_cpu((cpu), cpu_possible_mask) #define for_each_online_cpu(cpu) for_each_cpu((cpu), cpu_online_mask) #define for_each_enabled_cpu(cpu) for_each_cpu((cpu), cpu_enabled_mask) #define for_each_present_cpu(cpu) for_each_cpu((cpu), cpu_present_mask) + +#define for_each_possible_cpu_wrap(cpu, start) \ + for_each_cpu_wrap((cpu), cpu_possible_mask, (start)) #endif /* Wrappers for arch boot code to manipulate normally-constant masks */ diff --git a/include/linux/objpool.h b/include/linux/objpool.h index cb1758eaa2d3..b713a1fe7521 100644 --- a/include/linux/objpool.h +++ b/include/linux/objpool.h @@ -170,17 +170,16 @@ static inline void *objpool_pop(struct objpool_head *pool) { void *obj = NULL; unsigned long flags; - int i, cpu; + int start, cpu; /* disable local irq to avoid preemption & interruption */ raw_local_irq_save(flags); - cpu = raw_smp_processor_id(); - for (i = 0; i < pool->nr_possible_cpus; i++) { + start = raw_smp_processor_id(); + for_each_possible_cpu_wrap(cpu, start) { obj = __objpool_try_get_slot(pool, cpu); if (obj) break; - cpu = cpumask_next_wrap(cpu, cpu_possible_mask, -1, 1); } raw_local_irq_restore(flags); -- 2.43.0