From: Conor Dooley <conor@kernel.org>
To: Aleksandar Rikalo <arikalo@gmail.com>
Cc: linux-riscv@lists.infradead.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Djordje Todorovic <djordje.todorovic@htecgroup.com>,
Dragan Mladjenovic <Dragan.Mladjenovic@syrmia.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Access time mmio instead of rdtime.
Date: Sun, 29 Dec 2024 15:09:13 +0000 [thread overview]
Message-ID: <20241229-cogwheel-kebab-3cc2b21096c8@spud> (raw)
In-Reply-To: <20241227150056.191794-1-arikalo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Fri, Dec 27, 2024 at 04:00:56PM +0100, Aleksandar Rikalo wrote:
> +#if defined(CONFIG_RISCV_TIME_MMIO)
> + if (!of_property_read_u64(n, "clock-reg", &mmio_addr)) {
This is a non-standard, undocumented property. reg & reg-names are what
you should be using here.
Cheers,
Conor.
> + riscv_time_val = ioremap((long)mmio_addr, 8);
> + if (riscv_time_val) {
> + pr_info("Using mmio time register at 0x%llx\n", mmio_addr);
> + static_branch_enable(&riscv_time_mmio_available);
> + } else {
> + pr_warn("Unable to use mmio time at 0x%llx\n", mmio_addr);
> + }
> + }
> +#endif
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-12-29 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 15:00 Aleksandar Rikalo
2024-12-29 15:09 ` Conor Dooley [this message]
2025-02-05 15:31 ` Palmer Dabbelt
2025-04-09 13:00 ` Djordje Todorovic
2025-04-10 8:53 ` Aleksa Paunovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241229-cogwheel-kebab-3cc2b21096c8@spud \
--to=conor@kernel.org \
--cc=Dragan.Mladjenovic@syrmia.com \
--cc=aou@eecs.berkeley.edu \
--cc=arikalo@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=djordje.todorovic@htecgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®