From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973571B3921 for ; Tue, 31 Dec 2024 19:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735672672; cv=none; b=AkR6VhWd1tLSKIdqPECjIBTkj2lPVIQICMHS/ucxbCL5bC0T6m+fWpySgi0cyXYZFIZ1UYc8E8RLbjg/qJ50AYM5BSTo6sLYImBpxEH8hEuyiB4i/In7h5tlAGUHwedWYCBipoQ8TOp1KyJteuGY+58N3rKrvuM1k4EvmjiKaVA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735672672; c=relaxed/simple; bh=DWHUSsH92NgrmSLJylNKMLusQjrfdMQFMzKChWE3deU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gYAIt5IbPCTzsSyROJ4g0FitRpigyBIX0fcSA2L+ZT7MbPMVK2yqnsOVD2dIJ5agU98jpPtvk8QxqDA38/SaLrXIVce++lt6ZpBPFz3qNu3oWWSBgr3DwFUv2RiHGfKJ1dPvln5X5jTQT/CbyIIGN+suhJLCqOibG/tMJLCeANY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com; spf=pass smtp.mailfrom=googlemail.com; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b=DvOhmNzg; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=googlemail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=googlemail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="DvOhmNzg" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5d3e8f64d5dso17881638a12.3 for ; Tue, 31 Dec 2024 11:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1735672669; x=1736277469; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UlDWSD9D4eFOrxR5d5GrT8K9grdu0sXiJhpdsmzP/Bs=; b=DvOhmNzgkAZ1AQG3VyqHBL6UJ8IQvzVDGRsaCdPYQUdKJJ+z79B5ZjV/GtECn614ek TPOMlntsdPnN92omFNIo+9WVMzJYkKYuX6Q1nBvc4DojMparcX8eA6E+2pthzUHvH+46 1fo8KZ8PsmwDMmFL6EX17qbv3ykFhlFwObWlpfTtFRQvqdjpQO1a5DL83DzgTZV6AODH yREY6X/0I/EwWLeWsf0eWYE4GVx0Aw+wcNBM7C4NOvreTVZSpY62PS8SKAalSiUzjMDI yP907fzWO/WKKPSjBuSExmmVYCXO0kmYMLNv6QuI3nGGQ2sQp5Al//QFzJ0xFxDV1FN+ aGtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735672669; x=1736277469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UlDWSD9D4eFOrxR5d5GrT8K9grdu0sXiJhpdsmzP/Bs=; b=AO1bBKwWFyUlawKo4V9B84heOxyhezAzAMLaUUb99Gxh/v/PGaHAc25P8mr0Riztmm vstK17wWIDFSfL4uJ65y7zmS9+30AA5Fs863J1ViSA94cdkajiC0KRDz3/P2cQ79hkqF 0cRT6UTlLvm19HFsF1DdQ3LpSKRQFowM87k81wVoxHnZkb8UsYpp9Y8mckeUNmubyjRa ElSiWgfeh4ZKGNygr6LCjaQE2fmB2bu/HRbgtXu16jocCohMuqKkwdi3BZHdTEridN4g c0OIlOosdtFluussGmajpzxvDc8YBfNvWI5v5QMin4KetiAA89EZeR5X5SHTU2NJ5ffc eiNQ== X-Forwarded-Encrypted: i=1; AJvYcCUufpvAxTab+6x1XC8pwdLhisnRcsT9OfSMsLNF8NSJMwF6/ZFvKwStKxHJkCQGdOG6pKWqWFR4XnRrJCc=@vger.kernel.org X-Gm-Message-State: AOJu0YzRMO+4uXVba7q9ugSA6+ll+ise5BNCHcaczruBKPGcbR2oSzAu vGgseyhT4LbZuo8LYX4THPFQahw7SQ8O7MYzedHSsnQFKjChmdR3OVI4ZQ== X-Gm-Gg: ASbGncsHw1wqOyyV0SubREX1eJpq+P3JqmKHQ2EZ6xWmuP/VEXJFxgECSjK0l2JF29O cF8FpJO4EuPbhZlg43myr1bjAyY6IaAS7uxSuPuMxogasIlWxKWT71ZQOQF4A3V9vqWC7HWSAiu 2Od4TOCraGnY7X2CM9QmNPaST3BXI+0wMFI+qwY0D4P3IZ68+nJeTLlSNXBjWx64Cfxz2Hiskcs KgzFOkxgW7sB8x+iGszd30zfV+CcYUUZy2ZSvov2hv/FOukBkAMG+G5kX8Hg/738c+srZkSjuho gC55Eo7Irv4y/5tBC8hS4Glpva4jQbWxnBBOxNZxD2NisPa76T3l6cTQBDhfdWKbaHvPqicTtB0 1YIs4EkOQoiMCKIs2Rnv16Xav X-Google-Smtp-Source: AGHT+IF9acAp+7NdPV6IzvYhctAufWO/ZujC2AIYiI0xxmTKMU+ZtZZw5R0wjHlrzSPEmkjGfjvvJA== X-Received: by 2002:a05:6402:1eca:b0:5d6:37ec:60cf with SMTP id 4fb4d7f45d1cf-5d81de48c1cmr44247236a12.27.1735672668726; Tue, 31 Dec 2024 11:17:48 -0800 (PST) Received: from localhost.localdomain (dynamic-2a02-3100-b300-ce00-1e86-0bff-fe2f-57b7.310.pool.telefonica.de. [2a02:3100:b300:ce00:1e86:bff:fe2f:57b7]) by smtp.googlemail.com with ESMTPSA id 4fb4d7f45d1cf-5d80675a3d2sm16311780a12.16.2024.12.31.11.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2024 11:17:48 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, kishon@kernel.org, Martin Blumenstingl Subject: [PATCH 2/2] phy: amlogic: meson8b-usb2: Use the regmap_{clear,set}_bits helpers Date: Tue, 31 Dec 2024 20:17:18 +0100 Message-ID: <20241231191718.2764065-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241231191718.2764065-1-martin.blumenstingl@googlemail.com> References: <20241231191718.2764065-1-martin.blumenstingl@googlemail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These require less code, reduce the chance of typos and overall make the intent clearer. No functional changes. Signed-off-by: Martin Blumenstingl --- drivers/phy/amlogic/phy-meson8b-usb2.c | 28 ++++++++++---------------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c index d9c761b7c15c..a553231a9f7c 100644 --- a/drivers/phy/amlogic/phy-meson8b-usb2.c +++ b/drivers/phy/amlogic/phy-meson8b-usb2.c @@ -165,8 +165,7 @@ static int phy_meson8b_usb2_power_on(struct phy *phy) return ret; } - regmap_update_bits(priv->regmap, REG_CONFIG, REG_CONFIG_CLK_32k_ALTSEL, - REG_CONFIG_CLK_32k_ALTSEL); + regmap_set_bits(priv->regmap, REG_CONFIG, REG_CONFIG_CLK_32k_ALTSEL); regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_REF_CLK_SEL_MASK, FIELD_PREP(REG_CTRL_REF_CLK_SEL_MASK, 0x2)); @@ -175,23 +174,20 @@ static int phy_meson8b_usb2_power_on(struct phy *phy) FIELD_PREP(REG_CTRL_FSEL_MASK, 0x5)); /* reset the PHY */ - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, - REG_CTRL_POWER_ON_RESET); + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); udelay(RESET_COMPLETE_TIME); - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, 0); + regmap_clear_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); udelay(RESET_COMPLETE_TIME); - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_SOF_TOGGLE_OUT, - REG_CTRL_SOF_TOGGLE_OUT); + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_SOF_TOGGLE_OUT); if (priv->dr_mode == USB_DR_MODE_HOST) { - regmap_update_bits(priv->regmap, REG_DBG_UART, - REG_DBG_UART_SET_IDDQ, 0); + regmap_clear_bits(priv->regmap, REG_DBG_UART, + REG_DBG_UART_SET_IDDQ); if (priv->match->host_enable_aca) { - regmap_update_bits(priv->regmap, REG_ADP_BC, - REG_ADP_BC_ACA_ENABLE, - REG_ADP_BC_ACA_ENABLE); + regmap_set_bits(priv->regmap, REG_ADP_BC, + REG_ADP_BC_ACA_ENABLE); udelay(ACA_ENABLE_COMPLETE_TIME); @@ -214,17 +210,15 @@ static int phy_meson8b_usb2_power_off(struct phy *phy) struct phy_meson8b_usb2_priv *priv = phy_get_drvdata(phy); if (priv->dr_mode == USB_DR_MODE_HOST) - regmap_update_bits(priv->regmap, REG_DBG_UART, - REG_DBG_UART_SET_IDDQ, - REG_DBG_UART_SET_IDDQ); + regmap_set_bits(priv->regmap, REG_DBG_UART, + REG_DBG_UART_SET_IDDQ); clk_disable_unprepare(priv->clk_usb); clk_disable_unprepare(priv->clk_usb_general); reset_control_rearm(priv->reset); /* power off the PHY by putting it into reset mode */ - regmap_update_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET, - REG_CTRL_POWER_ON_RESET); + regmap_set_bits(priv->regmap, REG_CTRL, REG_CTRL_POWER_ON_RESET); return 0; } -- 2.47.1