From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792673982; b=hGBIky1nai9lUB7qPhB/BzaLexaVkxvyLTmNnTJsXAIbo7Uf+81PXVXP/3GQTw7tYrK9 ieSGA6BlTszndqgRmswxL+uMdigmpEFuTAzepHdp5/1es/SOtCep7RZJVwmOLyokjtnM2 gCT/hnDoMcik+BTD/oU5VpjHYKDrcj8ct5ZzKuqbq5h7gdZTLfJ/LMwjXpuXP+lHr9wOW r+vtqOBSBHKG13sGNld4Fv5tsCD0STW/so4iTguxnJvWg5esrGSZBSplDwPYvKTCS7fEL jlo5pHg0pX5GsRcwabpkfnqInZqwMu5Z8BSNci8YTFhee7JqO5WgoD6jEvgapcFze8w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792673982; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=TPXltwLQAsPQCNRcrw0xdOwjdfkToTs4/p0KQjsifUY=; b=aeOVL9UbYWhVYAQ2fnaoSAlZJp0ZC/OKZsU2eVMTfGCW+3k/E2//Wf6DMYrVb3M609SZ xCrj8GDcyc9xVZBExO2BI/aEvF8GLJcRD6vfkSqDMmAJeZOCaBvL6Nicx8X3n47UBOZgX 1edZvk0LlJ687gFL9mWB0+vakKQhK7JQvY9SOjvDnmvOjdedlxxm2MPUKohFjsMWSBGD7 gjdNV1AsBlyMmUlxXY5q8XHO642EZYirH+mtrMDUY667SzVPFnqUCZUuGKA0W8lZRSyvc 07a6Y8wVqjKh3vnx3Gcugks7q/1d+FOED6BNzq604FX3xfY2WTJgqgJnEX0z1/+LljQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=v1XCxXeT; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A19606A320 for ; Thu, 22 Oct 2026 12:59:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 89A19606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=v1XCxXeT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=TPXltwLQAsPQCNRcrw0xdOwjdfkToTs4/p0KQjsifUY=; b=v1XCxXeTTh88Gb5Wep8pf/75Ay qdxcfs/BaDOd/U2bmDRjsUjRCcDnvG3bBChvEbrdKDp+HxMZ29uIs0pNUA1AbcnUHe9JgQvASxJtR SUpSSGy3OmZaweb7W4RHB8dgUZrazrBL89k6ON8iD7jD8rAteLooHqSKfKoinnvEnFy7Bg3jDJ5jE MNdIKDaA4ZcEIqIWRCd3MoIqG1v7ndRcDbBpeaOU5sSqldS9FcJdiky4u2q0jtE36dM0zTvQVc4rn wwkoxRxF0wE+G5+A4BTib/UO5bDmTDJfy/Mf2fxuKPwckgm/xXSg+b9xmkRXKyTEyHauy3Qdn6XWh QWA4yw1Q==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Sandy Huang , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chaoyi Chen Cc: dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chaoyi Chen , Cristian Ciocaltea , Sebastian Reichel Subject: Re: [PATCH 1/3] drm/rockchip: vop2: Use drm_format_info_min_pitch() for plane offsets Date: Thu, 22 Oct 2026 14:59:07 +0200 Message-ID: <2024729.6tgchFWduM@diego> In-Reply-To: <20261022071737.508-2-kernel@airkyi.com> References: <20261022071737.508-1-kernel@airkyi.com> <20261022071737.508-2-kernel@airkyi.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Chaoyi, Am Donnerstag, 22. Oktober 2026, 09:17:35 Mitteleurop=C3=A4ische Sommerzeit= schrieb Chaoyi Chen: > From: Chaoyi Chen >=20 > Use the block aware helper instead of cpp[], the latter aliases > char_per_block and is wrong for packed 10-bit formats like NV15, > NV20 and NV30. >=20 > Tested with modetest[0]: >=20 > ``` > modetest -s 86:3840x2160 -P \ > 59@83:3940x2160~96,0,3840,2160+0+0@NV20 -a > ``` >=20 > fb size (3940x2160), src at (96, 0) with size (3840x2160), > dst at (0, 0) with size (3840x2160) >=20 > [0]: https://github.com/windowsair/libdrm/tree/src-pos-support >=20 > Assisted-by: LLM > Signed-off-by: Chaoyi Chen > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/d= rm/rockchip/rockchip_drm_vop2.c > index 4cce3e336f5b..480aa8c8a8d2 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1290,7 +1290,7 @@ static void vop2_plane_atomic_update(struct drm_pla= ne *plane, > =20 > afbc_en =3D drm_is_afbc(fb->modifier); > =20 > - offset =3D (src->x1 >> 16) * fb->format->cpp[0]; > + offset =3D drm_format_info_min_pitch(fb->format, 0, src->x1 >> 16); > =20 > /* > * AFBC HDR_PTR must set to the zero offset of the framebuffer. > @@ -1309,6 +1309,7 @@ static void vop2_plane_atomic_update(struct drm_pla= ne *plane, > int hsub =3D fb->format->hsub; > int vsub =3D fb->format->vsub; > =20 > + offset =3D drm_format_info_min_pitch(fb->format, 1, src->x1 >> 16) / h= sub; > offset =3D (src->x1 >> 16) * fb->format->cpp[1] / hsub; missing removal of the replaced line? Heiko > offset +=3D (src->y1 >> 16) * fb->pitches[1] / vsub; > =20 >=20