From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E64163D for ; Wed, 1 Jan 2025 16:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735749684; cv=none; b=Ko+MkKKk2jdG2xyhJUq33a6ccs8BY0A07HWYg6T69aejTXCJriB2fxWJ9DGoPS6Z+TGKMl20U+d79MYmPWw7VZ0rAvcS9wZuzSWds+nkXO7KBe7wGB8KHK+c1a5ayrKXjXbu4/65UWQ0wk1gZExFSdeow8NqqFnuCh7tvtDFKCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735749684; c=relaxed/simple; bh=c0f8BPIR82R6z0EdnoQ74DmnX07qaVSJ6Ju+mNlbuUU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XLDYW/EVidbSnfKDVFRpQWkaUSB88WV/iGfx00uxuNElBIvTw7M5cZtS8oea8WTYclruikq3Ey0oWBnWA3c327/1ephj2GYXemj/+tAgp2q+LVNHQ0+8nBcZ+Jmer688sNiFxNrhx0WfkBIPCf2RzMOOc5piWQNZoTlfdmgMmnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFJEgRj3; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFJEgRj3" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43635796b48so65185385e9.0 for ; Wed, 01 Jan 2025 08:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735749681; x=1736354481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=673uKSPzcYnBh2TsZV1+vzSMvKs5q5gmZERqpENWy+4=; b=nFJEgRj3Xpd73eKdDHqxNSoIrtSFvHerUIvuQfObkt8+rAzF0+cAtU3uspZlPVoPn7 Gv6k1w/xE7sJ7ouAm6+oKPS8MqKRf1F4rOWRtM34b9ds5MGqtAtM5zZaVaTDfTurimmS J7iid8RYZeUDtMrzUPcGYW6m+zx+hlf7LDE2gXc8ksd1FW+MYtCekXIGHQlbsHm3JBZQ 5v19kIe+3PmIq4Zgg2mRDo/zRyrIoaDzV8jBsHfisHWBU6fN2LmUko992w4+cfR2o+Q/ MIwcCwLylzs1N7fkGv3LpmIYy8Ixa6FbrGXyHGbUxSMaAQeDb+/pTVhif6RaIXn+qX+m V4EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735749681; x=1736354481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=673uKSPzcYnBh2TsZV1+vzSMvKs5q5gmZERqpENWy+4=; b=sEKUWAamlOF356r2XyrYu0xXFax0ypd1mwmamAuieD+hZR1o67GZLIS5x6m5t0WuTX GJ7wxvWY6VqaFVKb1TxomjY5SlY5i54OIF9IJ1G69t+OClYm++/vb9IY2PO8eQQmDgjx 2NBKD7SaAmWixCgwg6cY9DQ1YqGnMd8WqX8YOQ3gOAsctPADyKy+tuiSorMOOdTlZMW8 N3BvOxw4sdS5KFuOlcKFobk60GXLDs0elAaPmN/nLO63ip8k/RBDLI4krAQtG4KDz2pu A5rSpNgwe6c6bB4ip12y6y3LS+dDwa4xG83xcRF9MtHVOUZT4znHfBcFTkwCtTbTP8Cn M+VQ== X-Forwarded-Encrypted: i=1; AJvYcCUY3vLRuA7T9Z3Cxq0Td5GRhvvKrAK19SXvdfcSkAy6u1cvAGqc//ICinYyY+H6d7Z25lHSFe2sRAsoqoo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+oN8gZoFoy86kkfMjkhOv9t/O+YO8pdLQ6SIDxNi2GNc1RQTZ dUowUojQe8fW3OZOl4bUCv6NSzZo/jv0vmqu+NZ4sX/YGFiJfYoE X-Gm-Gg: ASbGncuMi8odgOXMTQwkaPUQmaQkXXlvVXx9P2OV4yNOnzwlQBoP1TO6o0L+Wxkq+cu CK2aDBqRDWj5QiFE6fkOaDmXG7/vedWZgwjdnCWs/iey0gN0GYWqkjCOJLK1glPbWnKdIxtIBdd HbliQu6aZZdHizjOJINHm2jWCdxI6611LZCe6WWUd+/zqAdEbaPk7sQm1Fyb3OWXS9DfRLCKbPk uUvAhlQB2gPV0/NFNfPmKXygg6EB4W4ZFJQE8Wohi9M92f51oXVEaaMm00hU2Ybjlp/2Wngc/2b eYjclFvD6B0Zk3AUk9iH9co= X-Google-Smtp-Source: AGHT+IHQHSCpLv1Uk9ROvVaAadFohvt3o6x+X80bv++kGLPADaDQj6k0S7ZMrKyj9Dk+KcAYYjcUig== X-Received: by 2002:a05:600c:a0a:b0:434:9e17:190c with SMTP id 5b1f17b1804b1-436693f7cc4mr339030115e9.0.1735749680436; Wed, 01 Jan 2025 08:41:20 -0800 (PST) Received: from dsl-u17-10 (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364b0532a6sm449633705e9.1.2025.01.01.08.41.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Jan 2025 08:41:19 -0800 (PST) Date: Wed, 1 Jan 2025 16:41:19 +0000 From: David Laight To: Alexander Usyskin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Lucas De Marchi , Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Karthik Poosa , Reuven Abliyev , Oren Weil , linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write Message-ID: <20250101164119.000d2bd4@dsl-u17-10> In-Reply-To: <20250101153925.865703-7-alexander.usyskin@intel.com> References: <20250101153925.865703-1-alexander.usyskin@intel.com> <20250101153925.865703-7-alexander.usyskin@intel.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 1 Jan 2025 17:39:20 +0200 Alexander Usyskin wrote: > GSC NVM controller HW errors on quad access overlapping 1K border. > Align 64bit read and write to avoid readq/writeq over 1K border. > > Acked-by: Miquel Raynal > Signed-off-by: Alexander Usyskin > --- > drivers/mtd/devices/mtd-intel-dg.c | 35 ++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/mtd/devices/mtd-intel-dg.c b/drivers/mtd/devices/mtd-intel-dg.c > index 76ef7198fff8..230bf444b7fe 100644 > --- a/drivers/mtd/devices/mtd-intel-dg.c > +++ b/drivers/mtd/devices/mtd-intel-dg.c > @@ -238,6 +238,24 @@ static ssize_t idg_write(struct intel_dg_nvm *nvm, u8 region, > len_s -= to_shift; > } > > + if (!IS_ALIGNED(to, sizeof(u64)) && > + ((to ^ (to + len_s)) & GENMASK(31, 10))) { I'm sure that should be (to + len_s - 1). Using GENMASK(31, 10) completely fails to indicate what is being tested. > + /* > + * Workaround reads/writes across 1k-aligned addresses > + * (start u32 before 1k, end u32 after) > + * as this fails on hardware. > + */ > + u32 data; > + > + memcpy(&data, &buf[0], sizeof(u32)); get_unaligned_u32() > + idg_nvm_write32(nvm, to, data); > + if (idg_nvm_error(nvm)) > + return -EIO; > + buf += sizeof(u32); > + to += sizeof(u32); > + len_s -= sizeof(u32); > + } It isn't at all obvious why copying 4 bytes helps. Indeed, if 'to' is 1023 and 'len_s' is 2 it goes terribly wrong. David > + > len8 = ALIGN_DOWN(len_s, sizeof(u64)); > for (i = 0; i < len8; i += sizeof(u64)) { > u64 data; > @@ -295,6 +313,23 @@ static ssize_t idg_read(struct intel_dg_nvm *nvm, u8 region, > from += from_shift; > } > > + if (!IS_ALIGNED(from, sizeof(u64)) && > + ((from ^ (from + len_s)) & GENMASK(31, 10))) { > + /* > + * Workaround reads/writes across 1k-aligned addresses > + * (start u32 before 1k, end u32 after) > + * as this fails on hardware. > + */ > + u32 data = idg_nvm_read32(nvm, from); > + > + if (idg_nvm_error(nvm)) > + return -EIO; > + memcpy(&buf[0], &data, sizeof(data)); > + len_s -= sizeof(u32); > + buf += sizeof(u32); > + from += sizeof(u32); > + } > + > len8 = ALIGN_DOWN(len_s, sizeof(u64)); > for (i = 0; i < len8; i += sizeof(u64)) { > u64 data = idg_nvm_read64(nvm, from + i);