mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shinas Rasheed <srasheed@marvell.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
	<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
	<konguyen@redhat.com>, <horms@kernel.org>,
	<einstein.xue@synaxg.com>,
	"Shinas Rasheed" <srasheed@marvell.com>
Subject: [PATCH net v4 0/4] Fix race conditions in ndo_get_stats64
Date: Thu, 2 Jan 2025 03:22:42 -0800	[thread overview]
Message-ID: <20250102112246.2494230-1-srasheed@marvell.com> (raw)

Fix race conditions in ndo_get_stats64 by checking if netdev is running
before per queue resources are accessed, and remove stats fetch from
firmware which is currently unnecessary

Changes:
V4:
  - Check if netdev is running, as decision for accessing resources
    rather than availing lock implementations, in ndo_get_stats64()

V3: https://lore.kernel.org/all/20241218115111.2407958-1-srasheed@marvell.com/
  - Added warn log that happened due to rcu_read_lock in commit message

V2: https://lore.kernel.org/all/20241216075842.2394606-1-srasheed@marvell.com/
  - Changed sync mechanism to fix race conditions from using an atomic
    set_bit ops to a much simpler synchronize_net()

V1: https://lore.kernel.org/all/20241203072130.2316913-1-srasheed@marvell.com/

Shinas Rasheed (4):
  octeon_ep: fix race conditions in ndo_get_stats64
  octeon_ep: remove firmware stats fetch in ndo_get_stats64
  octeon_ep_vf: fix race conditions in ndo_get_stats64
  octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64

 .../net/ethernet/marvell/octeon_ep/octep_main.c    | 14 ++++----------
 .../ethernet/marvell/octeon_ep_vf/octep_vf_main.c  | 12 ++++--------
 2 files changed, 8 insertions(+), 18 deletions(-)

-- 
2.25.1


             reply	other threads:[~2025-01-02 11:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 11:22 Shinas Rasheed [this message]
2025-01-02 11:22 ` [PATCH net v4 1/4] octeon_ep: fix " Shinas Rasheed
2025-01-04 17:01   ` Jakub Kicinski
2025-01-06  5:57     ` [EXTERNAL] " Shinas Rasheed
2025-01-06 20:57       ` Jakub Kicinski
2025-01-07  6:11         ` Shinas Rasheed
2025-01-02 11:22 ` [PATCH net v4 2/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2025-01-02 11:22 ` [PATCH net v4 3/4] octeon_ep_vf: fix race conditions " Shinas Rasheed
2025-01-02 11:22 ` [PATCH net v4 4/4] octeon_ep_vf: remove firmware stats fetch " Shinas Rasheed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250102112246.2494230-1-srasheed@marvell.com \
    --to=srasheed@marvell.com \
    --cc=einstein.xue@synaxg.com \
    --cc=hgani@marvell.com \
    --cc=horms@kernel.org \
    --cc=kheib@redhat.com \
    --cc=konguyen@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sedara@marvell.com \
    --cc=thaller@redhat.com \
    --cc=vimleshk@marvell.com \
    --cc=wizhao@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®