mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [for-linus][PATCH 0/2] ftrace: Fixes for v6.13
Date: Thu, 02 Jan 2025 17:02:38 -0500	[thread overview]
Message-ID: <20250102220238.225015816@goodmis.org> (raw)

Fixes for ftrace in v6.13:

- Add needed READ_ONCE() around access to the fgraph array element

  The updates to the fgraph array can happen when callbacks are registered
  and unregistered. The __ftrace_return_to_handler() can handle reading
  either the old value or the new value. But once it reads that value
  it must stay consistent otherwise the check that looks to see if the
  value is a stub may show false, but if the compiler decides to re-read
  after that check, it can be true which can cause the code to crash
  later on.

- Make function profiler use the top level ops for filtering again

  When function graph became available for instances, its filter ops became
  independent from the top level set_ftrace_filter. In the process the
  function profiler received its own filter ops as well. But the function
  profiler uses the top level set_ftrace_filter file and does not have one
  of its own. In giving it its own filter ops, it lost any user interface
  it once had. Make it use the top level set_ftrace_filter file again.
  This fixes a regression.

             reply	other threads:[~2025-01-02 22:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 22:02 Steven Rostedt [this message]
2025-01-02 22:02 ` [for-linus][PATCH 1/2] fgraph: Add READ_ONCE() when accessing fgraph_array[] Steven Rostedt
2025-01-02 22:02 ` [for-linus][PATCH 2/2] ftrace: Fix function profilers filtering functionality Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250102220238.225015816@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome