From: Xu Lu <luxu.kernel@bytedance.com>
To: anup@brainfault.org, tglx@linutronix.de, paul.walmsley@sifive.com
Cc: lihangjing@bytedance.com, xieyongji@bytedance.com,
guojinhui.liam@bytedance.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Xu Lu <luxu.kernel@bytedance.com>
Subject: [PATCH] irqchip/riscv-imsic: Support allocating multiple msi-x vectors
Date: Fri, 3 Jan 2025 20:59:26 +0800 [thread overview]
Message-ID: <20250103125926.54203-1-luxu.kernel@bytedance.com> (raw)
This commit modifies alloc and free callback of imsic_base_domain to
support allocating and freeing multiple msi-x vectors at once.
Signed-off-by: Xu Lu <luxu.kernel@bytedance.com>
---
drivers/irqchip/irq-riscv-imsic-platform.c | 54 +++++++++++++---------
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index c708780e8760..d0ea0eb22e2e 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -141,35 +141,45 @@ static struct irq_chip imsic_irq_base_chip = {
IRQCHIP_MASK_ON_SUSPEND,
};
+static void imsic_irq_domain_free(struct irq_domain *domain, unsigned int virq,
+ unsigned int nr_irqs)
+{
+ struct irq_data *d;
+ int i;
+
+ for (i = 0; i < nr_irqs; i++) {
+ d = irq_domain_get_irq_data(domain, virq + i);
+ imsic_vector_free(irq_data_get_irq_chip_data(d));
+ }
+ irq_domain_free_irqs_top(domain, virq, nr_irqs);
+}
+
static int imsic_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,
unsigned int nr_irqs, void *args)
{
struct imsic_vector *vec;
-
- /* Multi-MSI is not supported yet. */
- if (nr_irqs > 1)
- return -EOPNOTSUPP;
-
- vec = imsic_vector_alloc(virq, cpu_online_mask);
- if (!vec)
- return -ENOSPC;
-
- irq_domain_set_info(domain, virq, virq, &imsic_irq_base_chip, vec,
- handle_simple_irq, NULL, NULL);
- irq_set_noprobe(virq);
- irq_set_affinity(virq, cpu_online_mask);
- irq_data_update_effective_affinity(irq_get_irq_data(virq), cpumask_of(vec->cpu));
+ int i, err;
+
+ for (i = 0; i < nr_irqs; i++) {
+ vec = imsic_vector_alloc(virq + i, cpu_online_mask);
+ if (!vec) {
+ err = -ENOSPC;
+ goto error;
+ }
+
+ irq_domain_set_info(domain, virq + i, virq + i, &imsic_irq_base_chip,
+ vec, handle_simple_irq, NULL, NULL);
+ irq_set_noprobe(virq + i);
+ irq_set_affinity(virq + i, cpu_online_mask);
+ irq_data_update_effective_affinity(irq_get_irq_data(virq + i),
+ cpumask_of(vec->cpu));
+ }
return 0;
-}
-
-static void imsic_irq_domain_free(struct irq_domain *domain, unsigned int virq,
- unsigned int nr_irqs)
-{
- struct irq_data *d = irq_domain_get_irq_data(domain, virq);
- imsic_vector_free(irq_data_get_irq_chip_data(d));
- irq_domain_free_irqs_parent(domain, virq, nr_irqs);
+error:
+ imsic_irq_domain_free(domain, virq, i);
+ return err;
}
static int imsic_irq_domain_select(struct irq_domain *domain, struct irq_fwspec *fwspec,
--
2.20.1
next reply other threads:[~2025-01-03 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 12:59 Xu Lu [this message]
2025-01-04 7:49 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103125926.54203-1-luxu.kernel@bytedance.com \
--to=luxu.kernel@bytedance.com \
--cc=anup@brainfault.org \
--cc=guojinhui.liam@bytedance.com \
--cc=lihangjing@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®