From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7770A1D5CCD for ; Sun, 5 Jan 2025 23:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736119223; cv=none; b=ZE0LsZ3cuBu/l9ZF68Pc/pIPnaRfCn0H2zMq1cNv1k12cyz59Gv0zVUpe5FudrU5LEtvJE5ejXdpvVZwNILDZCrSm9/gZyWdtwLG4nY2Z7KMwTV8WVM4NeFyLVN7VmbDjN1mlkuWd4sacSXH0Mam5CSwqDzIPGXibksh0JuYJv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736119223; c=relaxed/simple; bh=WzMajFJpJTIuyi6r17zZM8S5dPL8RCoP8M0/xxnt6CY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IA8NLLxvWcKGutZcLr/mXNYTdKgR/RCOdhAug+MCxQQf1ovgEGSlQ2riK9O/Gn3TfZEIeYXCsyV2xzE+nKCfzi2m+vwz2TWLG0aqs9m1prITzzGQs2Hfc4zLlCB/C14XkVMDbLpjZuXlgKQX/Yas1x6KcT6y96V8wkxcYSWKjqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=VjhLvq11; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VjhLvq11" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E7D5B594; Mon, 6 Jan 2025 00:19:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1736119169; bh=WzMajFJpJTIuyi6r17zZM8S5dPL8RCoP8M0/xxnt6CY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VjhLvq11bERWq8bbI3J27mvIzgjssGJGj9hp5roHipNG81vyLgBCvKCRIcX6MBUXK QDH8beDEH5yFUabL0df3RFnZR7iZRJoeiygGc2wQCMRfXID8Xdu2vbfKJRCVD6+5Rz MBOqDeLLP1bvSKvwkdf3CgkVC/hiwvU6X9Gw1Mi4= Date: Mon, 6 Jan 2025 01:20:18 +0200 From: Laurent Pinchart To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Russell King , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans Verkuil Subject: Re: [PATCH 2/2] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge Message-ID: <20250105232018.GB21164@pendragon.ideasonboard.com> References: <20241215-drm-move-tda998x-v1-0-7817122b1d73@linaro.org> <20241215-drm-move-tda998x-v1-2-7817122b1d73@linaro.org> <20241215123805.GB25852@pendragon.ideasonboard.com> <7wbji44qivubkwrbvrdck7fxsl5oaljugzy4td6xywr2p5ug7p@snrr6en5cuh7> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7wbji44qivubkwrbvrdck7fxsl5oaljugzy4td6xywr2p5ug7p@snrr6en5cuh7> (CC'ing Hans Verkuil) On Mon, Jan 06, 2025 at 12:52:55AM +0200, Dmitry Baryshkov wrote: > On Sun, Dec 15, 2024 at 02:38:05PM +0200, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patch. > > > > On Sun, Dec 15, 2024 at 01:09:08PM +0200, Dmitry Baryshkov wrote: > > > TDA998x is the HDMI bridge driver, incorporating drm_connector and > > > optional drm_encoder (created via the component bind API by the TICLDC > > > and HDLCD drivers). Thus it should be residing together with the other > > > DRM bridge drivers under drivers/gpu/drm/bridge/. > > > > > > TDA9950 is an I2C-CEC translator, being present on-die on the TDA9989 > > > and TDA19989 chips, so it is being instantiated by the TDA998x driver. > > > Move it together with the TDA998x under bridge drivers subdir. > > > > > > Signed-off-by: Dmitry Baryshkov > > > --- > > > MAINTAINERS | 2 +- > > > drivers/gpu/drm/arm/Kconfig | 1 + > > > drivers/gpu/drm/bridge/Kconfig | 2 ++ > > > drivers/gpu/drm/bridge/Makefile | 1 + > > > drivers/gpu/drm/bridge/tda/Kconfig | 13 +++++++++++++ > > > drivers/gpu/drm/bridge/tda/Makefile | 4 ++++ > > > drivers/gpu/drm/{i2c => bridge/tda}/tda9950.c | 0 > > > drivers/gpu/drm/{i2c => bridge/tda}/tda998x_drv.c | 0 > > > > I probably wouldn't have created a tda/ subdirectory in bridge/, but I > > don't mind much either way. > > A possibly better option is to move tsa9950.c to drivers/media/cec/i2c/ > next to ch7332 CEC driver. WDYT? I think that's a question for Hans. I don't mind much either way. > If I don't get any response from Russell within the next few days, I > think I'll post v2 performing these two moves: tda9950 to > drivers/media/cec/i2c and tda998x to drivers/gpu/drm/bridge without the > tda/ subdir. > > > Reviewed-by: Laurent Pinchart -- Regards, Laurent Pinchart