From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-arm-msm@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH v4 3/6] media: venus: venc: Ignore parm smaller than 1fps
Date: Mon, 06 Jan 2025 13:40:09 +0000 [thread overview]
Message-ID: <20250106-fix-cocci-v4-3-3c8eb97995ba@chromium.org> (raw)
In-Reply-To: <20250106-fix-cocci-v4-0-3c8eb97995ba@chromium.org>
The driver uses "whole" fps in all its calculations (e.g. in
load_per_instance()). Return -EINVAL if the user provides a parm that
will result in 0 whole fps.
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Closes: https://lore.kernel.org/linux-media/f11653a7-bc49-48cd-9cdb-1659147453e4@xs4all.nl/T/#m91cd962ac942834654f94c92206e2f85ff7d97f0
Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/qcom/venus/venc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
index c1c543535aaf..bd967d60c883 100644
--- a/drivers/media/platform/qcom/venus/venc.c
+++ b/drivers/media/platform/qcom/venus/venc.c
@@ -411,7 +411,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
us_per_frame = timeperframe->numerator * (u64)USEC_PER_SEC;
do_div(us_per_frame, timeperframe->denominator);
- if (!us_per_frame)
+ if (!us_per_frame || us_per_frame > USEC_PER_SEC)
return -EINVAL;
fps = (u64)USEC_PER_SEC;
--
2.47.1.613.gc27f4b7a9f-goog
next prev parent reply other threads:[~2025-01-06 13:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 13:40 [PATCH v4 0/6] media: Fix coccinelle warning/errors Ricardo Ribalda
2025-01-06 13:40 ` [PATCH v4 1/6] media: dvb-frontends: tda10048: Make the range of z explicit Ricardo Ribalda
2025-01-06 13:40 ` [PATCH v4 2/6] media: venus: vdec: Ignore parm smaller than 1fps Ricardo Ribalda
2025-01-06 14:08 ` Bryan O'Donoghue
2025-01-06 13:40 ` Ricardo Ribalda [this message]
2025-01-06 14:08 ` [PATCH v4 3/6] media: venus: venc: " Bryan O'Donoghue
2025-01-06 13:40 ` [PATCH v4 4/6] media: venus: Remove timeperframe from inst Ricardo Ribalda
2025-01-06 13:40 ` [PATCH v4 5/6] media: venus: venc: Make the range of us_per_frame explicit Ricardo Ribalda
2025-01-06 13:40 ` [PATCH v4 6/6] media: venus: vdec: " Ricardo Ribalda
2025-01-07 9:35 ` Hans Verkuil
2025-01-07 9:54 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106-fix-cocci-v4-3-3c8eb97995ba@chromium.org \
--to=ribalda@chromium.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®