From: Charlie Jenkins <charlie@rivosinc.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Atish Patra <atishp@rivosinc.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Charlie Jenkins <charlie@rivosinc.com>,
Shunsuke Nakamura <nakamura.shun@fujitsu.com>
Subject: [PATCH v3 0/3] perf: Add PERF_EVENT_IOC_INC_EVENT_LIMIT
Date: Mon, 06 Jan 2025 20:07:31 -0800 [thread overview]
Message-ID: <20250106-perf_set_event_limit-v3-0-dbde0e90ddde@rivosinc.com> (raw)
Introduce a new perf ioctl key PERF_EVENT_IOC_INC_EVENT_LIMIT that
functions the same as PERF_EVENT_IOC_REFRESH, except it does not
immediately enable counters.
Also create a libperf API perf_evsel__refresh() to allow libperf users
access to this ioctl key.
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
---
This series is going to cause an issue conflict with another series I
sent [1]. The final patch of this series changes perf_evsel__ioctl() to
accept a unsigned long instead of void *. My preference would be for the
following patch to be squashed onto "libperf: Add perf_evsel__refresh()
function" when applied:
From 66ab7b57c8b5a94c02c8d82204338b0ebca48bc5 Mon Sep 17 00:00:00 2001
From: Charlie Jenkins <charlie@rivosinc.com>
Date: Mon, 6 Jan 2025 20:00:28 -0800
Subject: [PATCH] libperf: Fixup perf_evsel__get_id
This patch should be squashed onto
"libperf: Add perf_evsel__refresh() function" or
"libperf: Add perf_evsel__id() function" when merging.
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
---
tools/lib/perf/evsel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/perf/evsel.c b/tools/lib/perf/evsel.c
index 1cd1680d28d7..8690588c0ba1 100644
--- a/tools/lib/perf/evsel.c
+++ b/tools/lib/perf/evsel.c
@@ -521,7 +521,7 @@ int perf_evsel__period(struct perf_evsel *evsel, u64 period)
static int perf_evsel__get_id(struct perf_evsel *evsel, int cpu_map_idx, int thread, u64 *id)
{
- return perf_evsel__ioctl(evsel, PERF_EVENT_IOC_ID, id, cpu_map_idx, thread);
+ return perf_evsel__ioctl(evsel, PERF_EVENT_IOC_ID, (unsigned long)id, cpu_map_idx, thread);
}
int perf_evsel__id(struct perf_evsel *evsel, u64 *ids[])
--
2.34.1
[1] https://lore.kernel.org/lkml/20250106-perf_evsel_get_id-v3-1-44eca9194f1e@rivosinc.com/T/#u
Changes in v3:
- Use uint64_t instead of __u64 for consistency
- Link to v2: https://lore.kernel.org/r/20240807-perf_set_event_limit-v2-0-823b78d04c76@rivosinc.com
Changes in v2:
- Drop discussion about signal race condition
- Add new patch "libperf: Add perf_evsel__refresh() function"
- This newly added patch was pulled from a different series with
modifications to fit the new ioctl key
-
https://lore.kernel.org/lkml/20240726-overflow_check_libperf-v2-0-7d154dcf6bea@rivosinc.com/
will be updated
- Link to v1: https://lore.kernel.org/r/20240724-perf_set_event_limit-v1-0-e680c93eca55@rivosinc.com
---
Charlie Jenkins (3):
perf: Add PERF_EVENT_IOC_INC_EVENT_LIMIT
perf: Document PERF_EVENT_IOC_INC_EVENT_LIMIT
libperf: Add perf_evsel__refresh() function
include/linux/perf_event.h | 4 +--
include/uapi/linux/perf_event.h | 1 +
kernel/events/core.c | 17 +++++++----
tools/include/uapi/linux/perf_event.h | 1 +
tools/lib/perf/Documentation/libperf.txt | 2 ++
tools/lib/perf/evsel.c | 49 ++++++++++++++++++++++++++------
tools/lib/perf/include/perf/evsel.h | 2 ++
tools/lib/perf/libperf.map | 2 ++
tools/perf/design.txt | 5 ++++
9 files changed, 67 insertions(+), 16 deletions(-)
---
base-commit: ed60738a9b7ede4a4ae797d90be7fde3e10a36c7
change-id: 20240724-perf_set_event_limit-079f1b996376
--
- Charlie
next reply other threads:[~2025-01-07 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 4:07 Charlie Jenkins [this message]
2025-01-07 4:07 ` [PATCH v3 1/3] " Charlie Jenkins
2025-01-13 13:18 ` Peter Zijlstra
2025-01-13 18:59 ` Charlie Jenkins
2025-01-07 4:07 ` [PATCH v3 2/3] perf: Document PERF_EVENT_IOC_INC_EVENT_LIMIT Charlie Jenkins
2025-01-07 4:07 ` [PATCH v3 3/3] libperf: Add perf_evsel__refresh() function Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106-perf_set_event_limit-v3-0-dbde0e90ddde@rivosinc.com \
--to=charlie@rivosinc.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atishp@rivosinc.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nakamura.shun@fujitsu.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®