From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0693786359 for ; Mon, 6 Jan 2025 14:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736175125; cv=none; b=H60qS6mMkYNnlxgrgESz4F+bHDl1hy6ZUFw0XL0Vdz4JckCN/g9RM/42xKLpZ8ZqryOrhk5TvAUj/9tlaxky1t2FUtuYqM+0eUobZegkj+N0sKMZx8+tY4ttK3Gqzj8CrAGUwH5H7KivaMzVH9qwhgrwfQG12YhcXWow7GAMFjo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736175125; c=relaxed/simple; bh=P2Yoy2vCOV6x77FyFR28353Mr6QAvH/ioPjEKxMfKSg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i/harjZej7qvyU2jl0gLuU6V8EvDmuFWT7sSDZnDf9BZq6SLwoiJj9gB9wrlLpR3XZWLr4631k3V+MsJfQRm0CgOU+95KJmtwv6iUFeSdFBb0fSRSgINULcrlMQtW0IPrVe1MGM2J+2xYXtDkAGpPgIqPX9Z+hwP0CHw8Dowg68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xiiAzNIF; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xiiAzNIF" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2166360285dso210468855ad.1 for ; Mon, 06 Jan 2025 06:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736175123; x=1736779923; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RPzQv9JmUmJLzMLrGpE7zH6s1/r5xLoODlrZlCZTRjc=; b=xiiAzNIFsQ/LZ+eSZoNB/F1+mvskQjyjJCKbNXgbRt6csDjlBsrtYIUMu8lRq2U28w YpI3yAe4AYNJ6yqUHG6b2COTMzY+N1cEILcVN+k3JEZdctn80Bnv2oNI66FiDjFSVItF yqMb8/wCszlR8AWDXLB9kHKYceXZIvDG1fEuKkUY6oJlWu2j7KUfiCXcapJrhmltjOel 2uk2ncT/xUWhVsPGijF/8XA6aohJY7InZ9sRT43FBbMrurf5LvZ6+0HUhyekOphSz0nv sBUWeypSkHtLOjWjz1Pk827NJ8EFqhXYDlfo3s+2+5WvAuPiJS4SvyNkSa81DMj0GmA2 /fkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736175123; x=1736779923; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RPzQv9JmUmJLzMLrGpE7zH6s1/r5xLoODlrZlCZTRjc=; b=ofdxJilmJ3tCug6bHNh4dEje4tpMxI26DZM7ziQugE9rG0ZPLKXOQ5x6canGoxdWMH 0GUMrOxYMx4DYP1FMUz5+ETjLyIOpIEFiq6Mlz1p3YktB36Gil4lZxgjMqkV6fgnxxoI 56o8hHTKzfyX9a1QWsEMsNzrNywTJZnCwBFo7URgJeXIgBYcRl3Fi5eYHSuYULT8G1E8 tPqi6a3YYy6PD9jtRI3JGX5y1rgBEx50WEg/OLlvUu0w2RT/1W81nd7aiNM68oyy+HSI Xa8BbigrAW+JzqEp3r9JToZ1wzl1+hVLKllkJBMb4kVmadF2oA6qbQp0aV57wtW7Ve6+ vh8g== X-Forwarded-Encrypted: i=1; AJvYcCWIh4HFGUVpW2d1NvMV0boLhcQ63j+Xmy+W7FvrlMy7uGRKyyaXsUrCHHCtpHuUqJaYp4u/zMTdsAf2DY0=@vger.kernel.org X-Gm-Message-State: AOJu0YzZkVStQIF11vny63U5qF2FjVJfq4uKRVLgi63qmEtvriZM+6T5 cVUFcjDKGNoRyuBKz56+l/dXVkUmGKsIvRHP/dlal/3t8kzLvpQtvqWus+YfWdJThMa3l4LC04E = X-Gm-Gg: ASbGncuiM4qQPhVJCRttlXCd25rCqcz5Dq1Nd0tFRyk+L2b+/iMMInMSAnWz1fXZ1qo Ylg8al/nf4cFlTxmgZ1YObifJ+FxDYbHqKQtgAhIAMFibxwCCIsJdEDLBcN7luXG5AjpV5gBEAr kVwjPLNnG1VLGsG+6mJlSAgrz1iLH2986thyncpFEYpkdr0YyKUMOhW2pHo69XhIJoaqxHetnH1 i8Fnv4XZ8r0LW/sImatyCy1g/JgTZdHJwHu/35IptSFl8UDxp4W55CkIgqlaPFfVfE= X-Google-Smtp-Source: AGHT+IE4mpVT+GjLv3+7pfnCFcTYcja+19fvRAPtd/vCZh5myuA6s94pcYZbmYqV21GyNYKnPHbFfQ== X-Received: by 2002:a17:902:d510:b0:216:48f4:4f1a with SMTP id d9443c01a7336-219e6e9df37mr718707665ad.16.1736175123345; Mon, 06 Jan 2025 06:52:03 -0800 (PST) Received: from thinkpad ([120.60.61.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96e85csm293333705ad.61.2025.01.06.06.52.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 06:52:02 -0800 (PST) Date: Mon, 6 Jan 2025 20:21:59 +0530 From: Manivannan Sadhasivam To: Vivek Pernamitta Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports Message-ID: <20250106145159.oqseq7ysedmrmyey@thinkpad> References: <20250106-msix-v1-1-91d7b7143118@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250106-msix-v1-1-91d7b7143118@quicinc.com> On Mon, Jan 06, 2025 at 10:17:33AM +0530, Vivek Pernamitta wrote: > Enable MSIx if the end point supports. > s/MSIx/MSI-X s/end point/endpoint > Signed-off-by: Vivek Pernamitta > --- > Enable MSIx if the endpoint supports. No need of the comment here. Change LGTM! - Mani > --- > drivers/bus/mhi/host/pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl, > */ > mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events; > > - nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI); > + nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI); > if (nr_vectors < 0) { > dev_err(&pdev->dev, "Error allocating MSI vectors %d\n", > nr_vectors); > > --- > base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 > change-id: 20250106-msix-a4c5488ecafe > > Best regards, > -- > Vivek Pernamitta > -- மணிவண்ணன் சதாசிவம்