From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B39D1DD0FE for ; Mon, 6 Jan 2025 16:16:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180222; cv=none; b=Qfjdemfo3kh+6bjYjHZm99nsFvY0OAFGfhRHIECC0YJAxvz6kvqqWpbMTEEI63tTVdB4Xv2dV4g76l8xFtQ8KW3Ugmj0phi7WiIBt4d6jQfAT6YUvopTjQ4w59LXmT5gYipANQluHORdXkmGwkXur8LrZBHtCyUdBCT2YBHb1K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180222; c=relaxed/simple; bh=jR0rtiAFDgif5wPqwtmomqJBgFXe+11Fti0M+vMT9lQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dwWtO7cv1OkLtd7mF+eRiN1dLCDkNef+Bn3XDtB7zYvaPlgrcCRzpuz19fhM0eZrTSHUlkguBcFguN9A4fVxB3RoE1V3RpwFm8hzrY66qAAWfM0tc9+5a5TTrYPB3eD0MkrnSONUTqrBxjWgmQoCah/GkFldvlIvcTgMUOAHFVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kT59MZLU; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kT59MZLU" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2166022c5caso185317665ad.2 for ; Mon, 06 Jan 2025 08:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736180216; x=1736785016; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ioU53vgoNQ0AoVqbDSui1lqyY/iBOmMjiyD6RqrD6B4=; b=kT59MZLUL7oK48eiJbBsGFtBdciUG9qpVaXUAi4tdUOqnIWzIxl4X+G+ycI6n5jMLF +fcVAjfXyZrCKkiMZTtw86jmp0s5bOgH+zVLnajiMB9WqZk9gNb3gJOxdODeTXNagtr4 0NZG+KjDhtnxqOLMRNvw1+7O/oJ71CCUe37+yI5y6Ho7ORl8AsvbzCtHyVdW1jZ4uCae 1RCYUjI0zWPVeW6tUYPoS+JGzDHyOQSrr5Gt4Ey4WiTpOzW+OfV67+TQg7E4+rgM+9E1 PONn+IsnQ47elDD+qlEpEuVdhKKxaYvFxiHyh785eOWapE742MU2seFByBGR9RCZzpQZ 5hUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736180216; x=1736785016; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ioU53vgoNQ0AoVqbDSui1lqyY/iBOmMjiyD6RqrD6B4=; b=IE/7QHU60PpGUaSpJIhNKNaFXYZfq9G2WB6Ltle6m2z8sp3/5+gvWPx13u6P7VHlZW ze/InBOBKUiEbHBgffifFXLSr2NAeCgoo4ZDuuf8G4p0cTdX8BFJBZTU/ew0FNrsMn+k nAUYmlJtYwNT1DvDUc5eKUQpqYIJlPb7b+AAsi0/1zhuBJLymdX8ivLt6QHj0j4nZMjj vjmI31GAD8VYXYdtMbcSfkChvO8hb9FuspEBY0f3x9ZEmkgba3RYqWGAE9zlPCcZSg+F 6b/2fgyyVtaj2abh7pmjvabI/0pnQeK91VRQ5443zIxPdyEmKRkK0V9HoIBq+XtvCr8R Mgkw== X-Forwarded-Encrypted: i=1; AJvYcCX5nmKX3/gLfge7+QmvzPF43ocBsEI33H9jkshVzwe3PfBlgS3tTgKsZp5nKlBMwDIYiKmPqQXu2t/Y/jE=@vger.kernel.org X-Gm-Message-State: AOJu0YycL60KoTrHwg6Md35/hBA9KzjauAX/lRujTMtDsIk3UzQCsOTK Q5cP2YxpwE6+/s11fC7oi2q+rAKrD47BBrmA8aStUnqCeBvI19xrUpVFx5pZCg== X-Gm-Gg: ASbGncuo5/Le7kl9FwK0QxR2ZisNA4DeXalZP5EP1wjdoqfUrfpuAYgJ5dURgT65OZp xq9TVvBT6rlYwFc6KZYNaKiJO3A5Tld3nPsMIA1/lmk3lKxfY27F39HC0ZVDFrtIqTHRbddzUPR vamKWviaUAwJzdrQSyDB1mjoPROyuJNAEZhdpTWz9B3+ERO8l5r9I896BmR6L3Su/0RHI+Xnr1Q ST6XhroIY9zBDL38z7xjVwuuqkJOamoZcb1xYKjkRuVQpREUVp70MSRmsmImUjkP9I= X-Google-Smtp-Source: AGHT+IE0TclArATGV1Fu9QzdsMBgtnLWVMtYLElP8xxrkxbbzfBsYBkj0d5S+FS+C4fjsFRPAz2wxQ== X-Received: by 2002:a17:903:1209:b0:216:36ff:ba33 with SMTP id d9443c01a7336-219e6ebcfc7mr772797425ad.26.1736180216074; Mon, 06 Jan 2025 08:16:56 -0800 (PST) Received: from thinkpad ([120.60.61.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f4fbcsm294633875ad.174.2025.01.06.08.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 08:16:55 -0800 (PST) Date: Mon, 6 Jan 2025 21:46:39 +0530 From: Manivannan Sadhasivam To: Jianjun Wang Cc: Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Ryder Lee , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Xavier Chang Subject: Re: [PATCH 4/5] PCI: mediatek-gen3: Don't reply AXI slave error Message-ID: <20250106161639.4bgb7rhokoe22xpp@thinkpad> References: <20250103060035.30688-1-jianjun.wang@mediatek.com> <20250103060035.30688-5-jianjun.wang@mediatek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250103060035.30688-5-jianjun.wang@mediatek.com> On Fri, Jan 03, 2025 at 02:00:14PM +0800, Jianjun Wang wrote: > There are some circumstances where the EP device will not respond to > non-posted access from the root port (e.g., MMIO read). In such cases, > the root port will reply with an AXI slave error, which will be treated By 'reply with an AXI slave error', you meant that the root port responds to the MMIO read by the CPU with AXI slave error? If so, please reword it as such to avoid confusion. > as a System Error (SError), causing a kernel panic and preventing us > from obtaining any useful information for further debugging. > > We have added a new bit in the PCIE_AXI_IF_CTRL_REG register to prevent > PCIe AXI0 from replying with a slave error. Setting this bit on an older > platform that does not support this feature will have no effect. > But the issue is still present on the older SoCs, isn't it? If so, please add this info to the comments below. - Mani > By preventing AXI0 from replying with a slave error, we can keep the > kernel alive and debug using the information from AER. > > Signed-off-by: Jianjun Wang > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 4bd3b39eebe2..48f83c2d91f7 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -87,6 +87,9 @@ > #define PCIE_LOW_POWER_CTRL_REG 0x194 > #define PCIE_FORCE_DIS_L0S BIT(8) > > +#define PCIE_AXI_IF_CTRL_REG 0x1a8 > +#define PCIE_AXI0_SLV_RESP_MASK BIT(12) > + > #define PCIE_PIPE4_PIE8_REG 0x338 > #define PCIE_K_FINETUNE_MAX GENMASK(5, 0) > #define PCIE_K_FINETUNE_ERR GENMASK(7, 6) > @@ -469,6 +472,15 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie) > val |= PCIE_FORCE_DIS_L0S; > writel_relaxed(val, pcie->base + PCIE_LOW_POWER_CTRL_REG); > > + /* > + * Prevent PCIe AXI0 from replying a slave error, as it will cause kernel panic > + * and prevent us from getting useful information. > + * Keep the kernel alive and debug using the information from AER. > + */ > + val = readl_relaxed(pcie->base + PCIE_AXI_IF_CTRL_REG); > + val |= PCIE_AXI0_SLV_RESP_MASK; > + writel_relaxed(val, pcie->base + PCIE_AXI_IF_CTRL_REG); > + > /* Disable DVFSRC voltage request */ > val = readl_relaxed(pcie->base + PCIE_MISC_CTRL_REG); > val |= PCIE_DISABLE_DVFSRC_VLT_REQ; > -- > 2.46.0 > -- மணிவண்ணன் சதாசிவம்