From: Zi Yan <ziy@nvidia.com>
To: linux-mm@kvack.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>,
Hugh Dickins <hughd@google.com>,
David Hildenbrand <david@redhat.com>,
Yang Shi <yang@os.amperecomputing.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Yu Zhao <yuzhao@google.com>, John Hubbard <jhubbard@nvidia.com>,
linux-kernel@vger.kernel.org, Zi Yan <ziy@nvidia.com>
Subject: [PATCH v4 03/10] mm/huge_memory: allow split shmem large folio to any order
Date: Mon, 6 Jan 2025 11:55:06 -0500 [thread overview]
Message-ID: <20250106165513.104899-4-ziy@nvidia.com> (raw)
In-Reply-To: <20250106165513.104899-1-ziy@nvidia.com>
Commit 4d684b5f92ba ("mm: shmem: add large folio support for tmpfs") has
added large folio support to shmem. Remove the restriction in
split_huge_page*().
Signed-off-by: Zi Yan <ziy@nvidia.com>
---
mm/huge_memory.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index c89aed1510f1..511b5b23894b 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3287,7 +3287,7 @@ static void __split_huge_page(struct page *page, struct list_head *list,
/* Some pages can be beyond EOF: drop them from page cache */
if (tail->index >= end) {
if (shmem_mapping(folio->mapping))
- nr_dropped++;
+ nr_dropped += new_nr;
else if (folio_test_clear_dirty(tail))
folio_account_cleaned(tail,
inode_to_wb(folio->mapping->host));
@@ -3453,12 +3453,6 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
return -EINVAL;
}
} else if (new_order) {
- /* Split shmem folio to non-zero order not supported */
- if (shmem_mapping(folio->mapping)) {
- VM_WARN_ONCE(1,
- "Cannot split shmem folio to non-0 order");
- return -EINVAL;
- }
/*
* No split if the file system does not support large folio.
* Note that we might still have THPs in such mappings due to
--
2.45.2
next prev parent reply other threads:[~2025-01-06 16:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 16:55 [PATCH v4 00/10] Buddy allocator like folio split Zi Yan
2025-01-06 16:55 ` [PATCH v4 01/10] selftests/mm: use selftests framework to print test result Zi Yan
2025-01-06 16:55 ` [PATCH v4 02/10] selftests/mm: add tests for splitting pmd THPs to all lower orders Zi Yan
2025-01-06 16:55 ` Zi Yan [this message]
2025-01-06 16:55 ` [PATCH v4 04/10] mm/huge_memory: add two new (not yet used) functions for folio_split() Zi Yan
2025-01-06 16:55 ` [PATCH v4 05/10] mm/huge_memory: move folio split common code to __folio_split() Zi Yan
2025-01-06 16:55 ` [PATCH v4 06/10] mm/huge_memory: add buddy allocator like folio_split() Zi Yan
2025-01-06 16:55 ` [PATCH v4 07/10] mm/huge_memory: remove the old, unused __split_huge_page() Zi Yan
2025-01-06 16:55 ` [PATCH v4 08/10] mm/huge_memory: add folio_split() to debugfs testing interface Zi Yan
2025-01-06 16:55 ` [PATCH v4 09/10] mm/truncate: use folio_split() for truncate operation Zi Yan
2025-01-06 16:55 ` [PATCH v4 10/10] selftests/mm: add tests for folio_split(), buddy allocator like split Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106165513.104899-4-ziy@nvidia.com \
--to=ziy@nvidia.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®