From: Karan Tilak Kumar <kartilak@cisco.com>
To: sebaddel@cisco.com
Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com,
mkai2@cisco.com, satishkh@cisco.com, aeasi@cisco.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Karan Tilak Kumar <kartilak@cisco.com>
Subject: [PATCH 2/3] scsi: fnic: Remove extern definition from .c files
Date: Mon, 6 Jan 2025 14:44:50 -0800 [thread overview]
Message-ID: <20250106224451.3597-2-kartilak@cisco.com> (raw)
In-Reply-To: <20250106224451.3597-1-kartilak@cisco.com>
Implement review comments from Martin:
Remove extern definition of fnic_fip_queue from .c files
Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: Arun Easi <aeasi@cisco.com>
Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
---
drivers/scsi/fnic/fip.c | 2 --
drivers/scsi/fnic/fip.h | 2 ++
drivers/scsi/fnic/fnic_fcs.c | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fip.c b/drivers/scsi/fnic/fip.c
index 161075e3bb95..aaf5f768a9bd 100644
--- a/drivers/scsi/fnic/fip.c
+++ b/drivers/scsi/fnic/fip.c
@@ -7,8 +7,6 @@
#include "fip.h"
#include <linux/etherdevice.h>
-extern struct workqueue_struct *fnic_fip_queue;
-
#define FIP_FNIC_RESET_WAIT_COUNT 15
/**
diff --git a/drivers/scsi/fnic/fip.h b/drivers/scsi/fnic/fip.h
index c62993c76dc7..79fee7628870 100644
--- a/drivers/scsi/fnic/fip.h
+++ b/drivers/scsi/fnic/fip.h
@@ -131,6 +131,8 @@ void fnic_fcoe_start_flogi(struct fnic *fnic);
void fnic_fcoe_process_cvl(struct fnic *fnic, struct fip_header *fiph);
void fnic_vlan_discovery_timeout(struct fnic *fnic);
+extern struct workqueue_struct *fnic_fip_queue;
+
#ifdef FNIC_DEBUG
static inline void
fnic_debug_dump_fip_frame(struct fnic *fnic, struct ethhdr *eth,
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index 471d4a7553bf..1e8cd64f9a5c 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -27,7 +27,6 @@
#define MAX_RESET_WAIT_COUNT 64
-extern struct workqueue_struct *fnic_fip_queue;
struct workqueue_struct *fnic_event_queue;
static uint8_t FCOE_ALL_FCF_MAC[6] = FC_FCOE_FLOGI_MAC;
--
2.47.1
next prev parent reply other threads:[~2025-01-06 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 22:44 [PATCH 1/3] scsi: fnic: Remove unnecessary else and unnecessary break in FDLS Karan Tilak Kumar
2025-01-06 22:44 ` Karan Tilak Kumar [this message]
2025-01-06 22:44 ` [PATCH 3/3] scsi: fnic: Remove unnecessary else to fix warning in FDLS FIP Karan Tilak Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106224451.3597-2-kartilak@cisco.com \
--to=kartilak@cisco.com \
--cc=aeasi@cisco.com \
--cc=arulponn@cisco.com \
--cc=djhawar@cisco.com \
--cc=gcboffa@cisco.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mkai2@cisco.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®