From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F522594A4 for ; Tue, 7 Jan 2025 02:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736217171; cv=none; b=DfoQJsdcE7c2weS7ce25EQS0utyvWgo5ef+7lsRHJUNwnTtupLFtemjnGY6WHFu1NSGmasFp6aeA8DM4l/MdOxS570/mUNqoZlysrp9Q8bWzUcL8YMk0nrFvssdejmX7b3DyOuXg3R4dtTKKF6mI7bu/wwDhZxjjxbIj8qIuVFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736217171; c=relaxed/simple; bh=d+uKXaQ5aoFSAXUvVUg8z0pyNWkqnM2vS7sjAT0OzN8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FPMAZV7payOBjKokhfL9c+DUCyxuFAi9g6oSS8w8bmEHiWAj5FyBbHpQd619BduBUx5MOCYOct522gvbG8TpYsZhiv5SRiv95q+r+TAkuJ4cC2JiCAMs/RAJ6HptCcScYL6JafkivTnm6MZ11aJ7NTYXNxGuYb3u+AmNwPm8jQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DAMCIkjG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DAMCIkjG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16B34C4CED2; Tue, 7 Jan 2025 02:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736217171; bh=d+uKXaQ5aoFSAXUvVUg8z0pyNWkqnM2vS7sjAT0OzN8=; h=From:To:Cc:Subject:Date:From; b=DAMCIkjGr7IxM3tQ7Gcl2krixhqd+t/BRBx+tVJ/sQ/Gskm2w0lfF56rcKaL69RiI mzf+BGqCZhYqQRgtLkrZQXrPHtUaNXIEzqQcCZ0ttg1DYjUGnPdy8GhgtzfQgF4Xqq p04RVrUFlPvjjgne75w7nGnu5gbmqETKD1tI6PBBD/jtoCWY8cAun03ymiz/Fma7eJ zphK1K6VEv12UB5AWlJzMA+Bt7p0ZF7Lof5G3YfgoAqabnUFMxeZBvRNWza2vA0hV+ GORXe9jw2Z0eulPy7yhYbb3590Dij9HP25usJnSdLZDp+06ztIxPPzcoNzTZAugT1M yf2/qHm0The8A== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: don't call block truncation for aliased file Date: Tue, 7 Jan 2025 02:32:48 +0000 Message-ID: <20250107023248.3702924-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch should avoid the below warning which does not corrupt the metadata tho. [ 51.508120][ T253] F2FS-fs (dm-59): access invalid blkaddr:36 [ 51.508156][ T253] __f2fs_is_valid_blkaddr+0x330/0x384 [ 51.508162][ T253] f2fs_is_valid_blkaddr_raw+0x10/0x24 [ 51.508163][ T253] f2fs_truncate_data_blocks_range+0x1ec/0x438 [ 51.508177][ T253] f2fs_remove_inode_page+0x8c/0x148 [ 51.508194][ T253] f2fs_evict_inode+0x230/0x76c Fixes: 128d333f0dff ("f2fs: introduce device aliasing file") Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index c04ee1a7ce57..06313e1eb884 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1274,6 +1274,12 @@ int f2fs_remove_inode_page(struct inode *inode) return err; } + /* The aliase file must be truncated successfully. */ + if (unlikely(IS_DEVICE_ALIASING(inode))) { + f2fs_put_dnode(&dn); + return 0; + } + /* remove potential inline_data blocks */ if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) || S_ISLNK(inode->i_mode)) -- 2.47.1.613.gc27f4b7a9f-goog