From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB361F7084 for ; Tue, 7 Jan 2025 20:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736282413; cv=none; b=OtS20CT0mj8iHa8KY/rVGvwB++cXmevweGcbCim0mJ2IdTfFe4xMDPM6oVgx1SW77kMN7RgJfCuq0axAhEbxedoRsASzYNffFVZ4+MtklSWKkgA6S+Dl0Wi3/z0daxaO9j+ESYyAeNm7rDGT+/Q9v8fNi2wMA1Zoe0SSBtpxgiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736282413; c=relaxed/simple; bh=bI8G4azuTQeCZEhyU7iiUi2Rp8UTjMbgoMqwM954kJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fSOY1JmvfV7oRM+qCJ/vqp0jrj6I22vZkEj/WO73MD/uQcyjoa7ajTDBfu/1qVRP7dfB+yOEh1RAdXSX2GX6Zjxp7XZ86lDWYwHnb8Gzapu/gGaAJbIxRz2epKNAQ8JMbRLL7OwmXot7ZmENgNOkpO1Z/ynE1vXxiMwV9WNCeBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O6dPWhbb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O6dPWhbb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736282410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TCpDisLLwvCIGNbT+PhKKopNoYb0ShL8WntNQkEFj2A=; b=O6dPWhbbHoypQeIy80eWyxVregsimtBDt4aVaZ1fJ02+8ewCbdwc8WpKUS7N1L8ckafu1Q 0YQ8ltqHz2VIjbcaEvR1Ociklf6DjUuEjgnRQT0vmBlw6jSF5775k/+2Z9QTUsjwPpqUQa LJST84HIFDm+w/faFKtHUYhJxyndH0k= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-Z-t-OrjgNj2BzkCuhS98dw-1; Tue, 07 Jan 2025 15:40:09 -0500 X-MC-Unique: Z-t-OrjgNj2BzkCuhS98dw-1 X-Mimecast-MFC-AGG-ID: Z-t-OrjgNj2BzkCuhS98dw Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6d8f78fdad0so241922896d6.2 for ; Tue, 07 Jan 2025 12:40:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736282409; x=1736887209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TCpDisLLwvCIGNbT+PhKKopNoYb0ShL8WntNQkEFj2A=; b=FNomItEGg1iSVyh9M0mxeZGMsbeJGmVttyWKNBEuqv3T0bLgPE9kEOXF/JCav3+3k4 0J0Dc1LcCjB0jfDZITtGdso36SVKW7LtkSrV3sOzxukBiop7XMF6at45GrqCaaStpPsV PJ6tGSKJrRQKaEGvh8kAjuxjCGZRH042m8jcL2GRfjzR5b48kpqCa4kfN+1ZKwCpk1yA mMCNTtPNoUSkO08Aod0dTvxI05gKGxSPfr4iuNr9LkiR5dvVSYE9kl+jqGHiARdx36eH u4RObvIZ8Mlpvz2Te5iZ0qZmR1J9AcH++JNtZvaEv26wJS5FaAm8ODC84fTh+MaiOPp2 k7EA== X-Forwarded-Encrypted: i=1; AJvYcCWTqw0q1tHh8DvQSZkcuISVvx2Nxi67M0pesdb8JgVEUoLQaBkZNlbc2YZ2auzKo8dogI3UOaArJ/0mDrI=@vger.kernel.org X-Gm-Message-State: AOJu0YxculT6XaQ9F4n49wTkcsDrbjYVdp8tDVfZLJqxqjQtcYh50+kb 1FESgTQpvhIp0J2y6OWN8O8sjxnVOwGikL7byTyGXJ84QRClmOEqN1vOPthBDRIXDtois8z+M8Q +DJDroC5FUkYXMXa/9G/IthyMbstD5c9qCjQ2iQxyVdGFmKkOUxDZjXR2cwIN/A== X-Gm-Gg: ASbGnctpfn2sg7Swwi60iMk9IUCS+lesHVjo+by8vSrDm6ipOmaVWJwpXODixLNPfXd rOoNO4Zuly2ViFZhajCy17TwCAg+DT1yJwWQOUenZ0ICpjFotcfdxC335ZQViRnBE1s3pvQyxmj 2H7vv+whuwM9TAGtpUiU6U4jlVyM2Yn7Sjt/Ld6OoH/NUlpJSGxNovfH1qDCKZOZkVFmd2cfT4W L8abYxQkJuy16VJc4tnBTm+NT0wJ8sNOMGHlsbh6x9MYnOjr9pZCoCgN3uY2U0y0wD5JiBqc15D olPGyhWdZTl+dujy+1vVffLG/yCj0zs0 X-Received: by 2002:a05:6214:62c:b0:6d8:e641:da29 with SMTP id 6a1803df08f44-6df9b1cb73bmr8045776d6.6.1736282409136; Tue, 07 Jan 2025 12:40:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsmPVbepwscx9u5TPGeWDqEKCt+YxjZ5PHErDxy3KLOftZYeSvZ9Ie5a+UMBDrcG7IfTLdxQ== X-Received: by 2002:a05:6214:62c:b0:6d8:e641:da29 with SMTP id 6a1803df08f44-6df9b1cb73bmr8045476d6.6.1736282408878; Tue, 07 Jan 2025 12:40:08 -0800 (PST) Received: from x1n.redhat.com (pool-99-254-114-190.cpe.net.cable.rogers.com. [99.254.114.190]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181373f6sm184478306d6.62.2025.01.07.12.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 12:40:08 -0800 (PST) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Breno Leitao , Rik van Riel , Muchun Song , Naoya Horiguchi , Roman Gushchin , Ackerley Tng , Andrew Morton , peterx@redhat.com, Oscar Salvador Subject: [PATCH v2 2/7] mm/hugetlb: Stop using avoid_reserve flag in fork() Date: Tue, 7 Jan 2025 15:39:57 -0500 Message-ID: <20250107204002.2683356-3-peterx@redhat.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20250107204002.2683356-1-peterx@redhat.com> References: <20250107204002.2683356-1-peterx@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When fork() and stumble on top of a dma-pinned hugetlb private page, CoW must happen during fork() to guarantee dma coherency. In this specific path, hugetlb pages need to be allocated for the child process. Stop using avoid_reserve=1 flag here: it's not required to be used here, as dest_vma (which is destined to be a MAP_PRIVATE hugetlb vma) will have no private vma resv map, and that will make sure it won't be able to use a vma reservation later. No functional change intended with this change. Said that, it's still wanted to do this, so as to reduce the usage of avoid_reserve to the only one user, which is also why this flag was introduced initially in commit 04f2cbe35699 ("hugetlb: guarantee that COW faults for a process that called mmap(MAP_PRIVATE) on hugetlbfs will succeed"). I don't see whoever else should set it at all. Further patch will clean up resv accounting based on this. Signed-off-by: Peter Xu --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 2bf971f77553..7be8c35d2a83 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -5369,7 +5369,7 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src, spin_unlock(src_ptl); spin_unlock(dst_ptl); /* Do not use reserve as it's private owned */ - new_folio = alloc_hugetlb_folio(dst_vma, addr, 1); + new_folio = alloc_hugetlb_folio(dst_vma, addr, 0); if (IS_ERR(new_folio)) { folio_put(pte_folio); ret = PTR_ERR(new_folio); -- 2.47.0