From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32A711D5170 for ; Tue, 7 Jan 2025 22:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736287325; cv=none; b=SkSxPZVlQTHFelV0UusOD0Xsa9wAVLHCbA8Egt9bcEkNMVCDQ1ry/TdfIaYVNVhWIF+r/UsHxA4guvWpE4GafT4qL0WHLHJ+R3REYoLQREndh7M9apaWa6fTDX/VbV4E4n4g1Q+wNypaIR7/Z6OLh3z63WpfX/C9BeOrEfxhFVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736287325; c=relaxed/simple; bh=yE+k+5yIhBHbG/OX936XoHFBUk0gkIqhen59eUL3Ets=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=EuhJEC+vhhpvhUMbuWaXdj9a5L9IYwEPDKwKtBlOW2uHiCETLg4mafsVlKQxFLenFNekeohmstnqEGnhn06K7BRqG4BUMSeXhVahFbz2PUWgWf+/AQw2Jy8w1iEhSDe/AYNjaGgNE4FfNijTXImjbcRXq23JroL3b1tawod9bzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ctmxSfUy; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ctmxSfUy" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e549eac4ae6so7359716276.1 for ; Tue, 07 Jan 2025 14:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736287322; x=1736892122; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=oHU2qNqeidstEjTgX/H4wyzqiStAgyte6VQxWp6nfVA=; b=ctmxSfUyVoEWi6OdylfyIku5sJOi8nyszTKL0AJ+H0v3ZTIdBg6jeKg0WaEvtnbrsQ WPqd+AclIsLyyyJXBDLIgOo3VVt28oyHXcsKvQyiEMPgJZkbzPJvj2EA6fQtHpMCeM/h o+XdLdXbm2FdAKlksepR1Gdokgfa4YaHizrZXDk0a1T5bP7MCbrdl6XdERNYixh81kMA fqYszGQFI0B2++LaU8buJwsuleUq9mZ+7NMjLV30kFkBzjKUcX1zS3hLMf2CAjp2vqxd jXS4GIAlaO3l8We3t/vZL4na85vQ8hZkVI1eKqGb/PUtqr315AoGFBbRwW7f0J2hKLWd fXxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736287322; x=1736892122; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oHU2qNqeidstEjTgX/H4wyzqiStAgyte6VQxWp6nfVA=; b=CL6ePvhf+REvhQb8RwBCSZrEwbv08HfYTjNXNDj3D+rzbQKJ2ZvRW4t/gUzMZKjsTJ P0NDVfmXrLql6n9mUHQez8pjr8udyoC3tr8unkR0ohyCVozSNz391jEk0K3mzL00ZhHf JsFBeAQcY8ZljTLLGW8TVo7sC7VVwAmleDigf04LAbE8TOjCxsJJosNj1XzGMDuXSt1t gAP0o3uW9+Of9kdr6biyXKayTTrwxKei64tijZVZSgyk3AA3ohtznWJVWoe+YtSUXqRT c37w3/HIWrO5whi7k74UjBHfoFI0DZLxwleOHDVufN1nj3bDuLN/jej+ce6f7a1XfGBy ffdQ== X-Forwarded-Encrypted: i=1; AJvYcCUDzc+WMtCtqLbMQ1N6+ywJPcOXgR8O14zYiNTIy6Y4H8rUZtY8GE9BYjTs27kn2rLuS5YCwom6X2BOjq0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4BfNGU9DnaT3LqvBePQeBdu97d3Mtc2clY3FdbTvD+RPAIvRx JVldBVraekHZeqDag1hkdDpZuMJhv/IQsfS6ATAi7eEpdNGobm13Ug9wqGyFQeRR3w5VkhlTCmD 2C7+T4w== X-Google-Smtp-Source: AGHT+IH3H7Da2sw+0ZheqyYKo8QWiPE//y8aMnfRz56LLXcwKiusIn7qXkdmZ2MQaqbJotRYnsEogmWOmNTG X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:7ae:a887:5504:e3ca]) (user=irogers job=sendgmr) by 2002:a25:cecf:0:b0:e4c:35c4:cf05 with SMTP id 3f1490d57ef6-e54ee1e51a6mr1183276.5.1736287322339; Tue, 07 Jan 2025 14:02:02 -0800 (PST) Date: Tue, 7 Jan 2025 14:01:52 -0800 In-Reply-To: <20250107220152.1213959-1-irogers@google.com> Message-Id: <20250107220152.1213959-4-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250107220152.1213959-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v2 3/3] perf test: Add a runs-per-test flag From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" To detect flakes it is useful to run tests more than once. Add a runs-per-test flag that will run each test multiple times. Signed-off-by: Ian Rogers --- tools/perf/tests/builtin-test.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c index 887f735da900..729740c1e5e5 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -42,6 +42,8 @@ static bool dont_fork; /* Fork the tests in parallel and wait for their completion. */ static bool sequential; +/* Number of times each test is run. */ +static unsigned int runs_per_test = 1; const char *dso_to_test; const char *test_objdump_path = "objdump"; @@ -485,7 +487,7 @@ static int __cmd_test(struct test_suite **suites, int argc, const char *argv[], len = strlen(test_description(*t, i)); if (width < len) width = len; - num_tests++; + num_tests += runs_per_test; } } child_tests = calloc(num_tests, sizeof(*child_tests)); @@ -549,16 +551,18 @@ static int __cmd_test(struct test_suite **suites, int argc, const char *argv[], continue; } - test_suite__for_each_test_case(*t, curr_test_case) { - if (!perf_test__matches(test_description(*t, curr_test_case), - curr_suite, argc, argv)) - continue; - - err = start_test(*t, curr_suite, curr_test_case, - &child_tests[child_test_num++], - width, pass); - if (err) - goto err_out; + for (unsigned int run = 0; run < runs_per_test; run++) { + test_suite__for_each_test_case(*t, curr_test_case) { + if (!perf_test__matches(test_description(*t, curr_test_case), + curr_suite, argc, argv)) + continue; + + err = start_test(*t, curr_suite, curr_test_case, + &child_tests[child_test_num++], + width, pass); + if (err) + goto err_out; + } } } if (!sequential) { @@ -698,6 +702,8 @@ int cmd_test(int argc, const char **argv) "Do not fork for testcase"), OPT_BOOLEAN('S', "sequential", &sequential, "Run the tests one after another rather than in parallel"), + OPT_UINTEGER('r', "runs-per-test", &runs_per_test, + "Run each test the given number of times, default 1"), OPT_STRING('w', "workload", &workload, "work", "workload to run for testing, use '--list-workloads' to list the available ones."), OPT_BOOLEAN(0, "list-workloads", &list_workloads, "List the available builtin workloads to use with -w/--workload"), OPT_STRING(0, "dso", &dso_to_test, "dso", "dso to test"), -- 2.47.1.613.gc27f4b7a9f-goog