From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10D1514F9FD for ; Wed, 8 Jan 2025 17:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736356912; cv=none; b=sRk5ik3Yvk8w9F70ScWtWpTVvDCb3Imswvxd4SkUX//ivksiPxJ0pL15WwT4szxpZuyhD+lErKim4SsriSzCKEQwo0oHzK1mpzKLz1sJAYcsTY5jsy0h3tDY6fPYhYyUSPHjHM5gDjmFB+KSamsX3by4zsOBuVdy39MxYp5jFlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736356912; c=relaxed/simple; bh=bBtlESOrwSq/zlgHChS9VnkzArAlqbgTXlvXI4GdC4k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gQQzY7Dkts3vV+vxdMy1zoSxlf9uhqBHihJheHvry9B4Tetnt8rBqVZL2E93uHFiXvy4l2Mxk/gVBtjfbz6K/rl4oRROVNkSXQrKGslFTSdK4bQxNProta1et4LPxAmp3FoL3Dk5jd6uc3W8ZzL0PTvv1c+J2sya24ov6/nqpRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uLDBL5po; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uLDBL5po" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2164b662090so224172325ad.1 for ; Wed, 08 Jan 2025 09:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736356909; x=1736961709; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QhlLvY/LJFPsKd0vZK8f+ntXmApUkmDSgWg3tI8gkOY=; b=uLDBL5poDu+hNPbf4flgAPMAQ9TNVQ326KkPt0WsbSKOZUCCnH0Vhr0iWau/fq4ajH j8RSCJtN3bxLiwcplCu3jNUFNJPsQUZ1jrE81YytHSfxc5hclSxx8qDfnoQ4HBw0xFnS kOG2cqlc9kqX1gpcpMIQIpOtbdbSKfXI0r+kumO3oMDrOEShcF5oWy5eUbvTnpd/w5aU srROEEc7esgmteRP7vSEXovAq7tAoeqZ6x5UkDUR4PDdllOnWqdeQugl8dZpJtjbzRKQ OapVNwup8dmbxpphhadOhqQa8k7Ld6NOGB7a+/F1Ir54hk+dwze7MhAtijpCJyR1yehK ZBag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736356909; x=1736961709; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QhlLvY/LJFPsKd0vZK8f+ntXmApUkmDSgWg3tI8gkOY=; b=SidMXi/OpJKeukyhdWfP85vjIvTYQDP8CqqCUDQ/TXhzXh8XxGOuoGs2BBc4uboeZy yLFWMNdWRkj4RAJSAxI7enM/xG0z9nQvmf5dNHYZWgTIhFB840cXVHakYDvoQm6chX/m ZeHGALNcPdiuiGFff1AB7MdxbM08swm3Bj/ns9YwI4hfqTojPj1FMofndSqLyntNm0qB YyqLiyzu9Tm9CEA/znqx3gA5ULce4sPn37bpZHzJEQ9AGu8LRR549MkmApiulLizBIGU PHN/lCLy6XqT2psuHrNVJcy95ZY1MOK4uI2rMCTp3Ue0V9yoc9imDpaLkPtnI5JZzoxD +7dw== X-Forwarded-Encrypted: i=1; AJvYcCUaUhXFA+R3+m2wbVyw8JB36CaDoA1Bfxxdv8Fhgf8al1ocn5d42myM901G9OXuc2jGUiElUN9RNjlIOxk=@vger.kernel.org X-Gm-Message-State: AOJu0YzhzozD9umROVLaf0iBm1lND5sXKbY+zlqmb8DTicnjMl7s1t3Y NDIwH3YjnkLt2qPiTnylEN8GhyaUW4RfzkVaBy5RWpOdlVTrhI269ZCU4/VZ5A== X-Gm-Gg: ASbGncsVNh4SJ7JJ2+FSRLpbshygRCQzsYvVMuoFfXsj13aAQowwp6CIe1I1jWoen8H yag1yInVEb6RW35RO4g6tTCeXlDt0TPsUp0clIwYC5fFZN5Gnp4HWIN1F0eHjGbvH+GqhSgQJnK EIs5ZswbNZ71OuSeex1KMG1SD7xUotylYoDAtLd9RY+7JhrkLxZtxhfWHu7UhR9L+CAa29SFy8I UypmajVuqLHSevNU9uqWLX09Tx9UhtpWdFKOS+liY1PtuZrwVcfdrzlv738XBekEGof X-Google-Smtp-Source: AGHT+IFljXVpvzQRAJ50/FIKhBnt62pZLnBANrFqHk/UT1k0QKO94GXBwdjA1EjgYjW3r8Th4loC5g== X-Received: by 2002:a05:6a20:c792:b0:1e1:b35b:5132 with SMTP id adf61e73a8af0-1e88cfd2470mr7055029637.20.1736356909503; Wed, 08 Jan 2025 09:21:49 -0800 (PST) Received: from thinkpad ([117.213.97.234]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad8fb919sm36768138b3a.149.2025.01.08.09.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 09:21:49 -0800 (PST) Date: Wed, 8 Jan 2025 22:51:44 +0530 From: Manivannan Sadhasivam To: Vivek Pernamitta Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] bus: mhi: host: Enable MSI-X if the endpoint supports Message-ID: <20250108172144.73nuhop2ypbfgyxv@thinkpad> References: <20250108-msix-v2-1-dc4466922350@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250108-msix-v2-1-dc4466922350@quicinc.com> On Wed, Jan 08, 2025 at 09:52:07PM +0530, Vivek Pernamitta wrote: > Enable MSI-X if the endpoint supports. > > Signed-off-by: Vivek Pernamitta Applied to mhi-next! - Mani > --- > Changes in v2: > - Updated commit text. > - Link to v1: https://lore.kernel.org/r/20250106-msix-v1-1-91d7b7143118@quicinc.com > --- > drivers/bus/mhi/host/pci_generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl, > */ > mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events; > > - nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI); > + nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI); > if (nr_vectors < 0) { > dev_err(&pdev->dev, "Error allocating MSI vectors %d\n", > nr_vectors); > > --- > base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 > change-id: 20250106-msix-a4c5488ecafe > > Best regards, > -- > Vivek Pernamitta > -- மணிவண்ணன் சதாசிவம்