From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C638E2163AA for ; Thu, 9 Jan 2025 11:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.107.17.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736421277; cv=none; b=A4mfGuVelZNoObK/1EZockFIkcc5NNi1hiE31pH3LMGyAPlNifNMKNERrGrKrXRslAL/5bg+GM/YEWHxpGQ8KFmI2cVFr0iChOLbmjMnYJRdSeVfAK+vw6qIml/0QfArzrNQaJ53rWlqOeDYRVTta3OaFfDfh018EEVkUq6axZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736421277; c=relaxed/simple; bh=62fgegmOBehKRBqA+MCUfJ0wrv4L8CRk12VimLYvli4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JIGB/kZIL3hY2WJMza6oC7ZpRf4NydDJ5D9gMG6ObMGcVTV/vMJx/7wMLDlOdrwYl0M3+mD+rrRnpByKH8nQqlSO/BfSB9kzhxkK685j8CBIUvs8rI6j2ejLQ8NbVPVveFAXnCrPFJalhgkROtl2rJbAfkfRBTYMAMJ2o697wYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io; spf=pass smtp.mailfrom=altlinux.org; arc=none smtp.client-ip=194.107.17.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strace.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 5F03472C8F5; Thu, 9 Jan 2025 14:14:34 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 517307CCB3A; Thu, 9 Jan 2025 13:14:34 +0200 (IST) Date: Thu, 9 Jan 2025 13:14:34 +0200 From: "Dmitry V. Levin" To: Oleg Nesterov Cc: Eugene Syromyatnikov , Mike Frysinger , Renzo Davoli , Davide Berardi , strace-devel@lists.strace.io, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] ptrace_get_syscall_info: factor out ptrace_get_syscall_info_op Message-ID: <20250109111434.GB15384@strace.io> References: <20250107230153.GA30560@strace.io> <20250107230446.GD30633@strace.io> <20250109104147.GB26424@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250109104147.GB26424@redhat.com> On Thu, Jan 09, 2025 at 11:41:47AM +0100, Oleg Nesterov wrote: > On 01/08, Dmitry V. Levin wrote: > > > > +ptrace_get_syscall_info_op(struct task_struct *child) > > { > ... > > case SIGTRAP | 0x80: > > switch (child->ptrace_message) { > > case PTRACE_EVENTMSG_SYSCALL_ENTRY: > > - actual_size = ptrace_get_syscall_info_entry(child, regs, > > - &info); > > - break; > > + return PTRACE_SYSCALL_INFO_ENTRY; > > case PTRACE_EVENTMSG_SYSCALL_EXIT: > > - actual_size = ptrace_get_syscall_info_exit(child, regs, > > - &info); > > - break; > > + return PTRACE_SYSCALL_INFO_EXIT; > > } > > break; > > case SIGTRAP | (PTRACE_EVENT_SECCOMP << 8): > > - actual_size = ptrace_get_syscall_info_seccomp(child, regs, > > - &info); > > + return PTRACE_SYSCALL_INFO_SECCOMP; > > + } > > + > > + return PTRACE_SYSCALL_INFO_NONE; > > Cosmetic, I won't insist, but I'd suggest to do > > default: > return PTRACE_SYSCALL_INFO_SECCOMP; > } > > to make it more symmetric. OK, but I suppose you mean PTRACE_SYSCALL_INFO_NONE here, though. -- ldv