From: Kevin Loughlin <kevinloughlin@google.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
seanjc@google.com, pbonzini@redhat.com,
kevinloughlin@google.com, kirill.shutemov@linux.intel.com,
kai.huang@intel.com, ubizjak@gmail.com, dave.jiang@intel.com,
jgross@suse.com, kvm@vger.kernel.org, thomas.lendacky@amd.com,
pgonda@google.com, sidtelang@google.com, mizhang@google.com,
rientjes@google.com, szy0127@sjtu.edu.cn
Subject: [PATCH v2 0/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency
Date: Thu, 9 Jan 2025 22:55:31 +0000 [thread overview]
Message-ID: <20250109225533.1841097-1-kevinloughlin@google.com> (raw)
AMD CPUs currently execute WBINVD in the host when unregistering SEV
guest memory or when deactivating SEV guests. Such cache maintenance is
performed to prevent data corruption, wherein the encrypted (C=1)
version of a dirty cache line might otherwise only be written back
after the memory is written in a different context (ex: C=0), yielding
corruption. However, WBINVD is performance-costly, especially because
it invalidates processor caches.
Strictly-speaking, unless the SEV ASID is being recycled (meaning all
existing cache lines with the recycled ASID must be flushed), the
cache invalidation triggered by WBINVD is unnecessary; only the
writeback is needed to prevent data corruption in remaining scenarios.
To improve performance in these scenarios, use WBNOINVD when available
instead of WBINVD. WBNOINVD still writes back all dirty lines
(preventing host data corruption by SEV guests) but does *not*
invalidate processor caches.
First, provide helper functions to use WBNOINVD similar to how WBINVD
is invoked. Second, check for WBNOINVD support and execute WBNOINVD if
possible in lieu of WBINVD to avoid cache invalidations.
Changelog
---
v2: rebase to tip @ dffeaed35cef, drop unnecessary Xen changes, reword.
---
Kevin Loughlin (2):
x86, lib: Add WBNOINVD helper functions
KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency
arch/x86/include/asm/smp.h | 7 ++++++
arch/x86/include/asm/special_insns.h | 7 +++++-
arch/x86/kvm/svm/sev.c | 35 +++++++++++++++++-----------
arch/x86/lib/cache-smp.c | 12 ++++++++++
4 files changed, 47 insertions(+), 14 deletions(-)
--
2.47.1.688.g23fc6f90ad-goog
next reply other threads:[~2025-01-09 22:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 22:55 Kevin Loughlin [this message]
2025-01-09 22:55 ` [PATCH v2 1/2] x86, lib: Add WBNOINVD helper functions Kevin Loughlin
2025-01-09 22:55 ` [PATCH v2 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Kevin Loughlin
2025-01-10 8:23 ` Kirill A. Shutemov
2025-01-13 18:47 ` Kevin Loughlin
2025-01-14 7:50 ` Kirill A. Shutemov
2025-01-14 16:12 ` Sean Christopherson
2025-01-17 22:20 ` Kevin Loughlin
2025-01-13 21:46 ` Mingwei Zhang
2025-01-22 0:13 ` [PATCH v3 0/2] " Kevin Loughlin
2025-01-22 0:13 ` [PATCH v3 1/2] x86, lib: Add WBNOINVD helper functions Kevin Loughlin
2025-01-22 0:30 ` Dave Hansen
2025-01-22 0:30 ` Dave Hansen
2025-01-22 1:14 ` Kevin Loughlin
2025-01-22 0:13 ` [PATCH v3 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Kevin Loughlin
2025-01-22 1:34 ` [PATCH v4 0/2] " Kevin Loughlin
2025-01-22 1:34 ` [PATCH v4 1/2] x86, lib: Add WBNOINVD helper functions Kevin Loughlin
2025-01-22 7:32 ` Kirill A. Shutemov
2025-01-22 19:39 ` Tom Lendacky
2025-01-22 23:16 ` Dave Hansen
2025-01-23 0:06 ` Kevin Loughlin
2025-01-23 0:33 ` Dave Hansen
2025-01-23 0:58 ` Kevin Loughlin
2025-01-23 1:17 ` Kevin Loughlin
2025-01-22 1:34 ` [PATCH v4 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Kevin Loughlin
2025-01-23 0:24 ` [PATCH v5 0/2] " Kevin Loughlin
2025-01-23 0:24 ` [PATCH v5 1/2] x86, lib: Add WBNOINVD helper functions Kevin Loughlin
2025-01-23 0:36 ` Dave Hansen
2025-01-23 0:55 ` Kevin Loughlin
2025-01-23 0:24 ` [PATCH v5 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Kevin Loughlin
2025-02-26 1:30 ` Sean Christopherson
2025-02-01 0:02 ` [PATCH v6 0/2] " Kevin Loughlin
2025-02-01 0:02 ` [PATCH v6 1/2] x86, lib: Add WBNOINVD helper functions Kevin Loughlin
2025-02-04 16:59 ` Tom Lendacky
2025-02-26 1:26 ` Sean Christopherson
2025-02-26 14:22 ` Borislav Petkov
2025-02-01 0:02 ` [PATCH v6 2/2] KVM: SEV: Prefer WBNOINVD over WBINVD for cache maintenance efficiency Kevin Loughlin
2025-02-04 17:00 ` Tom Lendacky
2025-02-26 1:35 ` [PATCH v5 0/2] " Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109225533.1841097-1-kevinloughlin@google.com \
--to=kevinloughlin@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=sidtelang@google.com \
--cc=szy0127@sjtu.edu.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®