From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05AA1207676 for ; Fri, 10 Jan 2025 07:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736495107; cv=none; b=ufP1dL3SF1oK/YtTa2dpPhvbRdwBjkGzMfRNzz7P8tku0Zq4epxBeUhrBxp0zCBd0NXSPnbINn1NgRAkMzG55TCWf47mec7D25vgpOinD2AeFnEl2iHemnmG+AGlrbPfTVp2JxPPqp6ipDOqXiCyRu9IreynCEdISTBCx28MjxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736495107; c=relaxed/simple; bh=lc0fMsj53G85FRKZG1yxvV2BB0HDFfT8QSz+PV+hX/I=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=eWYBh8NCOXS9MMQSKEUStg1+eQJyjEInYSXVsNE7o46QZ20/au5cCf/4ZYn+qfHCwYZwnA1GTyKHDYbuXAuSg9a2TmEOcJtm9zcxLXiY5V8lumVI0RhnXOSHHBZd7cWgfFWPljIaun3OdfVlxIECa0EMitorZzKEi55lqgZAiyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ss6QAVNn; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ss6QAVNn" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4361f664af5so20393885e9.1 for ; Thu, 09 Jan 2025 23:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736495104; x=1737099904; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZEI1xXEiy3eHX7ZLavdCZHjpLbi/8PV+p3rxj/veojY=; b=Ss6QAVNnD3SKZOZSNXBKjM2vjLwnMpd5/ktE61HTWfgBXp7h87E/L1EyZOEUbgbok3 y83xvT2mYQS9SPnyah5IGSqcTEssojyLHUlK1jEc4gRyyQl2yjPnrFUX2YffvNNa3wYm ATX/M5/2LMLGxs6ESZ9h/+1beXTGXRNdq9TG28NvsZVxlPxQLFfFMu0AXm75jjsBxA6i JjLOoV/CA3J2soUYTMj3JL6moyxWjkIMA5wHwVCT6WF27F6uJ/V+fTCleXKolDRDPsXE puifJZLK2kxFDHxlCWFaUD0zwBWcn89ZIwhLKCCBxKeQqR4+Ta1uvDufxryKdRK60ZzB Db7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736495104; x=1737099904; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZEI1xXEiy3eHX7ZLavdCZHjpLbi/8PV+p3rxj/veojY=; b=UbP9phsP/jVltQCInAupWUHXmy/h/f6fqO1++ihZHiPEx0Vjp/dSQbCAI3TtksBb1g vW1aCXU4NBXpuf46AHLzqPotzR45fjWwmOLLlUbp0Z7/kWEFbr6BVjgvcX1AO5n961e0 s+uX29WlshaGb7wwly24/PqPZ4WnN0Gw5yfgJjDDpnDMWy6CRvUQgGqeOo59qeP6LOvU +lrPMKRm83or86xCoisw/iaZ1rGkQp6t5aJtvAO3QlkyEC1qfwICLOAsU/Ov5sX2s5gc m1pcmRA1ftl41haRAyJxEpwKTMIGCURqFryEysTY9CzQnUYlA10uFA+FyN19Ujo2WCJ/ 052g== X-Forwarded-Encrypted: i=1; AJvYcCVrRQKP9QTkUpRDigxI2MpGKvjOlOF1ewMJesZTc7fhlfuxUz0B+VrEiJRAZfudg+02dzk5eGEJboocpJg=@vger.kernel.org X-Gm-Message-State: AOJu0YxPeBJGaQET1Q21SgaVuV2mfXa+LGBiPqr9dEWhFFThKOM0cUhL k58HY3IYQeOtHGDIBOTU4NI9rzpg/lyPGYj86NpkZhMrxkNwcln5 X-Gm-Gg: ASbGncvN7nXxVUNCRMb0Pt+FI/jrUawkuG5bJvOnZjKCCayRGk8PX7FYrnpJKqEQmRN fH8S56GJSWUJ0jwSYgj7v3KXO7yEV9L0CuluSwoXnTB7MinH+V6f5NK5Ku4hz97URHMoNrb18Wo 1bPOWhV+UPcg883Idqc7rBKR32q5at04Dl22drm0OmHNBuyMfdcBBdix83ImNsPChjzgYQVRCpy nIqP2C0IYAZ3M1Auf+aZb/PykHEFA3d2HGVM1piW91zAGPBZLCIk0fNt/A2Nw== X-Google-Smtp-Source: AGHT+IGGDp1CS4LIVQFO1s7kZIcIY03EtBwCuCHImR+v3eVBXdZXO+UFRjBaqrAUDU0Yd3vhoReXcQ== X-Received: by 2002:a05:6000:4612:b0:385:dedb:a148 with SMTP id ffacd0b85a97d-38a8732c728mr8125988f8f.46.1736495103960; Thu, 09 Jan 2025 23:45:03 -0800 (PST) Received: from toolbox.. ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e8a326sm78547995e9.35.2025.01.09.23.45.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 23:45:03 -0800 (PST) From: Christian Hewitt To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jernej Skrabec , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] drm/meson: vclk: revert and re-fix vclk calculations Date: Fri, 10 Jan 2025 07:44:56 +0000 Message-Id: <20250110074458.3624094-1-christianshewitt@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Patch 1 reverts a previous fix for loss of HDMI sync when playing YUV420 @ 59.94 media. The patch does resolve a calculation issue. It also makes all fractional rates invalid which is a bigger problem. Patch 2 provides a proper fix after I figured out the actual root cause of the original problem. This time the maths checks out. Apologies to the stable team as the original patch has been applied to a wide range of older and LTS kernels (as far as 5.10). Please let me know if combining the two patches into a single 'fix the previous fix' patch would be preferred? Christian Christian Hewitt (2): Revert "drm/meson: vclk: fix calculation of 59.94 fractional rates" drm/meson: vclk: fix precision in vclk calculations drivers/gpu/drm/meson/meson_encoder_hdmi.c | 42 +++++++++++----------- drivers/gpu/drm/meson/meson_vclk.c | 7 ++-- 2 files changed, 25 insertions(+), 24 deletions(-) -- 2.34.1