mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hao Qin <hao.qin@mediatek.com>
To: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	Luiz Von Dentz <luiz.dentz@gmail.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
	Deren Wu <deren.Wu@mediatek.com>,
	Aaron Hou <aaron.hou@mediatek.com>,
	Chris Lu <chris.lu@mediatek.com>,
	Steve Lee <steve.lee@mediatek.com>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mediatek <linux-mediatek@lists.infradead.org>,
	Hao Qin <hao.qin@mediatek.com>
Subject: [PATCH] Bluetooth: btmtk: Remove resetting mt7921 before downloading the fw
Date: Fri, 10 Jan 2025 17:55:48 +0800	[thread overview]
Message-ID: <20250110095548.12761-1-hao.qin@mediatek.com> (raw)

Remove resetting mt7921 before downloading the fw, as it may cause
command timeout when performing the reset.

Signed-off-by: Hao Qin <hao.qin@mediatek.com>
---
 drivers/bluetooth/btmtk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
index 224eafc27dbe..68846c5bd4f7 100644
--- a/drivers/bluetooth/btmtk.c
+++ b/drivers/bluetooth/btmtk.c
@@ -1329,7 +1329,6 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 		fwname = FIRMWARE_MT7668;
 		break;
 	case 0x7922:
-	case 0x7961:
 	case 0x7925:
 		/* Reset the device to ensure it's in the initial state before
 		 * downloading the firmware to ensure.
@@ -1337,7 +1336,8 @@ int btmtk_usb_setup(struct hci_dev *hdev)
 
 		if (!test_bit(BTMTK_FIRMWARE_LOADED, &btmtk_data->flags))
 			btmtk_usb_subsys_reset(hdev, dev_id);
-
+		fallthrough;
+	case 0x7961:
 		btmtk_fw_get_filename(fw_bin_name, sizeof(fw_bin_name), dev_id,
 				      fw_version, fw_flavor);
 
-- 
2.18.0


             reply	other threads:[~2025-01-10  9:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  9:55 Hao Qin [this message]
2025-01-14 17:20 ` patchwork-bot+bluetooth
  -- strict thread matches above, loose matches on Subject: below --
2024-08-22  5:23 Hao Qin
2024-09-10 17:09 ` Marc Payne
2024-09-12  7:09   ` Chris Lu (陸稚泓)
2024-09-17 19:53     ` marc.payne
     [not found]       ` <9bfbbf24ac2480d94d3455f7e33e4b5502b38ced.camel@mediatek.com>
2024-09-18 13:37         ` Luiz Augusto von Dentz
2024-09-19  3:26           ` Chris Lu (陸稚泓)
2024-09-19 22:25             ` marc.payne
2024-09-20  6:27               ` Chris Lu (陸稚泓)
2024-10-14  9:29                 ` Linux regression tracking (Thorsten Leemhuis)
2024-10-22 10:56                   ` Takashi Iwai
2024-10-30  9:21                     ` Thorsten Leemhuis
2024-10-30 11:03                       ` Chris Lu (陸稚泓)
2024-10-30 11:29                         ` Thorsten Leemhuis
2024-11-01  7:11                           ` Chris Lu (陸稚泓)
2024-11-01 14:22                             ` Thorsten Leemhuis
2024-11-02 10:04                               ` Takashi Iwai
2024-11-11  9:21                                 ` Linux regression tracking (Thorsten Leemhuis)
2025-01-13 22:18                                   ` Sergio Callegari
2025-01-18 16:58                                     ` John Glotzer
2025-01-28  0:04                                       ` Bitterblue Smith
2025-01-29 18:31                                         ` John Glotzer
2024-09-18 16:02         ` marc.payne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250110095548.12761-1-hao.qin@mediatek.com \
    --to=hao.qin@mediatek.com \
    --cc=aaron.hou@mediatek.com \
    --cc=chris.lu@mediatek.com \
    --cc=deren.Wu@mediatek.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=sean.wang@mediatek.com \
    --cc=steve.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®