From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A282940D for ; Sat, 11 Jan 2025 15:31:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736609510; cv=none; b=j6DJPmEON6VSG5kGol0o7O1335qBqk30E0dAUNlmqjR13SPC5Vn9Z5WGC9S5KqI7kynXcnWlc9w8nEsnDhPtZHqpQQk3+9brscuw9R0gb4ryrWr14ShmXnxJT2yxh/UZzrfVf/3LAh1fsaCQr4o3LzPfAV5ZPd3QDyfeUe6cS0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736609510; c=relaxed/simple; bh=ekxFFBOleE1K94YnyfoF4Ve0DsLY3RqwTifUJ16OIE0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=aTjdvZiVEkY+BsXsMN0tGH6ObU9+yx2RMdahjW415WRzkXTrTlrSTD6B49+Fgzyxq9kdPjHqqLGeadO+rxHr/tWUEUOqu2HfXFRIiibdzhi0VZynkZXXGJf/q61H1j5slVF9B0jJEWV0x/dDFy5vsHJ0MfyyvY/jbXA9ufU0ViM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hy583ovm; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hy583ovm" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2162c0f6a39so71181205ad.0 for ; Sat, 11 Jan 2025 07:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736609508; x=1737214308; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=3yf+o4moCsNQBHu+6xUSFsr3GNr9nS49vZol2X3CoWg=; b=hy583ovmBZYceaM129vsD3CG5pyOov+kwvJONEyvSRl0uBKSCG3adRXAtZWNWttm3x 7W51dEWHauD+WJd7gmk1Ul8WTtqRnJSjLlJO1Pph4jZ8Q3THLqLTMKR8fNW8Aii569/o u11NCrI7CKcs3BlCjwhcEnhzntWWyzBJ9oeHVIObtYjygLYkRaGi7GjR+Pmv3rb0uX5N CfxzskhGBafbV+RQAaogvaJuYnCXKJ429mekeTkS7GeAxNDK1wjrtXmq8xPyOpv+otDD ZCuSAdVl2/Ay5XqEIQm46CjZjYNr8MZdTmSrJe56B/gyJzuSTebGmjGBDJUto2ocl+rc Z+6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736609508; x=1737214308; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3yf+o4moCsNQBHu+6xUSFsr3GNr9nS49vZol2X3CoWg=; b=WWW8TstjxFXfiTJlwDMeNr/1ssjZSYIeQuQCYlKxgEJRhd1iZty7F0VXGVduPmtF1A zN94u9jGqdx7HqYiCmAiFqXbX9NHe/guQdeTx3F9Bo3Bc/wFAYV0Hq8NFB36XqLnivt5 cYhS/ler/znsW1Z8b2Xtz5GVwVJt7C1bXHABFukYpJkXEQLj+jpkQfUYU1UR+Z73SYc3 ZrMUdx6/mB5xTevh/0iWTHA8Q2emxIJgeFo1LulRn1Ibeg+jbfFiXlsBDA0eGZjUB9IX dW8bJl30QhKFyh+03i0TxxnweB+ruqZNG4Ptr+tkWJDgu2IlmvFcbwUruUqArtavFwja tCfw== X-Forwarded-Encrypted: i=1; AJvYcCV6d7n+9tylOe2sQ3viKYrshROKoB8pvEsEz95IFfnATPQ/hiFCYYRV7y7sQF5ogsAobvtnLWK0jdEy9u4=@vger.kernel.org X-Gm-Message-State: AOJu0YzJpDlT5ZmSLRNxVepuhKcAS9olErBZGhHOFUgAKWaSmXwc/IwO EuCl9EOjh0NKebJNTJ3h43xFYIQR2KL3kkPS1pw2h3JPiQIfLcNz X-Gm-Gg: ASbGnctMVoCJGIpTXTRc21I/O29TUpxrhjICHzGR6XqH5CwbUemQAy3u/peOTbfo30l 4sIb4zc2NYSbKOuWd0MyQV2eRlNEac5wGaSvWhOpV5HrwMsk2V0UkjgqPaHrjOCbXo5qFuxqQD7 WAivGufrpibHkezSYY/znXSsZGE0JGAZt1YM1QhlkCIvPBJxFrFpGtjX1B5CE6rk1xwJegD0mK1 cqTK9QW27J6QMYe2gryYcwWQjru+8yXFhi5Fvssk0JyEMy6yEjbGJo= X-Google-Smtp-Source: AGHT+IHeDl1/a/r/94jIOxt+peopr3YLU7kN/ZQBg3duiznfbuTUC59j/Qol9V68paJ6ojMnd/GztA== X-Received: by 2002:a05:6a00:8d8e:b0:725:4301:ed5a with SMTP id d2e1a72fcca58-72d324995b4mr15963472b3a.2.1736609507506; Sat, 11 Jan 2025 07:31:47 -0800 (PST) Received: from Emma ([2401:4900:1c96:bd6b:5054:ff:fe53:2787]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d4056a5ddsm3254591b3a.52.2025.01.11.07.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 07:31:46 -0800 (PST) From: Karan Sanghavi Date: Sat, 11 Jan 2025 15:31:30 +0000 Subject: [PATCH v3] mm: shmem: Use signed int for version handling in casefold option Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250111-unsignedcompare1601569-v3-1-c861b4221831@gmail.com> X-B4-Tracking: v=1; b=H4sIANGOgmcC/4XNwQ6CMAwG4FchOzuzFQbMk+9hPIxRoIkMsumiI by7g5MejL39zd+vCwvoCQM7ZQvzGCnQ5FLIDxmzg3E9cmpTZiCgkGn4wwXqHbZ2GmfjUZZCqlJ zoRqlc5CFwo6l49ljR88dvlxTHijcJ//a/0S5bf+SUXLJbWG0zW2ljIJzPxq6HVONbWSEDwaqn wwkBmsldN01ApovZl3XN1hIIOIDAQAA To: Hugh Dickins , Andrew Morton , Gabriel Krisman Bertazi , =?utf-8?q?Andr=C3=A9_Almeida?= , Christian Brauner Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , Karan Sanghavi X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1736609492; l=1683; i=karansanghvi98@gmail.com; s=20241017; h=from:subject:message-id; bh=ekxFFBOleE1K94YnyfoF4Ve0DsLY3RqwTifUJ16OIE0=; b=FprJgiDdJvJlqmLiolLRcJL5obQUlg3wUY4TiQzlHROe3oTPl7k1wIuVFRHrmnVi82dp7uuen sH5mFe67Z5lAHY/EIUPsQr5Ew0+vfXAX+/6kfERTkfLHxJGhy8rqemi X-Developer-Key: i=karansanghvi98@gmail.com; a=ed25519; pk=UAcbefT1C06npNVDJHdgpPqTm4WE9IhaA1fmJb3A37Y= Fixes an issue where the use of an unsigned data type in `shmem_parse_opt_casefold()` caused incorrect evaluation of negative conditions. Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") Reviewed-by: André Almeida Reviewed-by: Gabriel Krisman Bertazi Signed-off-by: Karan Sanghavi --- Coverity Message: CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) unsigned_compare: This less-than-zero comparison of an unsigned value is never true. version < 0U Coverity Link: https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569 --- Changes in v3: - Changed patch subject adn summary log. - Link to v2: https://lore.kernel.org/r/20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com Changes in v2: - Updated the log summary. - Link to v1: https://lore.kernel.org/r/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/shmem.c b/mm/shmem.c index 7987deb2be9b..17a1d4fa8870 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter * bool latest_version) { struct shmem_options *ctx = fc->fs_private; - unsigned int version = UTF8_LATEST; + int version = UTF8_LATEST; struct unicode_map *encoding; char *version_str = param->string + 5; --- base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2 change-id: 20241111-unsignedcompare1601569-05b5932145ef Best regards, -- Karan Sanghavi