mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Peter Xu <peterx@redhat.com>,
	Maxim Levitsky <mlevitsk@redhat.com>,
	 Sean Christopherson <seanjc@google.com>
Subject: [PATCH v2 00/20] KVM: selftests: Fixes and cleanups for dirty_log_test
Date: Fri, 10 Jan 2025 16:29:44 -0800	[thread overview]
Message-ID: <20250111003004.1235645-1-seanjc@google.com> (raw)

Fix a variety of flaws and false failures/passes in dirty_log_test, and
drop code/behavior that adds complexity while adding little-to-no benefit.

Lots of details in the changelogs, and a partial list of complaints[1] in
Maxim's original thread[2].

[1] https://lore.kernel.org/all/Z1vR25ylN5m_DRSy@google.com
[2] https://lore.kernel.org/all/20241211193706.469817-1-mlevitsk@redhat.com

v2:
 - Collect reviews. [Maxim]
 - Expand a few changelogs to be more explicit about the effects. [Maxim]
 - Print the number of writes from each iteration. [Maxim]
 - Fix goofs in the last patch (stale message and changelog). [Maxim]

v1: https://lore.kernel.org/all/20241214010721.2356923-1-seanjc@google.com

Maxim Levitsky (2):
  KVM: selftests: Support multiple write retires in dirty_log_test
  KVM: selftests: Limit dirty_log_test's s390x workaround to s390x

Sean Christopherson (18):
  KVM: selftests: Sync dirty_log_test iteration to guest *before*
    resuming
  KVM: selftests: Drop signal/kick from dirty ring testcase
  KVM: selftests: Drop stale srandom() initialization from
    dirty_log_test
  KVM: selftests: Precisely track number of dirty/clear pages for each
    iteration
  KVM: selftests: Read per-page value into local var when verifying
    dirty_log_test
  KVM: selftests: Continuously reap dirty ring while vCPU is running
  KVM: selftests: Honor "stop" request in dirty ring test
  KVM: selftests: Keep dirty_log_test vCPU in guest until it needs to
    stop
  KVM: selftests: Post to sem_vcpu_stop if and only if vcpu_stop is true
  KVM: selftests: Use continue to handle all "pass" scenarios in
    dirty_log_test
  KVM: selftests: Print (previous) last_page on dirty page value
    mismatch
  KVM: selftests: Collect *all* dirty entries in each dirty_log_test
    iteration
  KVM: sefltests: Verify value of dirty_log_test last page isn't bogus
  KVM: selftests: Ensure guest writes min number of pages in
    dirty_log_test
  KVM: selftests: Tighten checks around prev iter's last dirty page in
    ring
  KVM: selftests: Set per-iteration variables at the start of each
    iteration
  KVM: selftests: Fix an off-by-one in the number of dirty_log_test
    iterations
  KVM: selftests: Allow running a single iteration of dirty_log_test

 tools/testing/selftests/kvm/dirty_log_test.c | 521 +++++++++----------
 1 file changed, 246 insertions(+), 275 deletions(-)


base-commit: 10485c4bc3caad3e93a6a4e99003e8ffffcd826a
-- 
2.47.1.613.gc27f4b7a9f-goog


             reply	other threads:[~2025-01-11  0:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11  0:29 Sean Christopherson [this message]
2025-01-11  0:29 ` [PATCH v2 01/20] KVM: selftests: Support multiple write retires in dirty_log_test Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 02/20] KVM: selftests: Sync dirty_log_test iteration to guest *before* resuming Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 03/20] KVM: selftests: Drop signal/kick from dirty ring testcase Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 04/20] KVM: selftests: Drop stale srandom() initialization from dirty_log_test Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 05/20] KVM: selftests: Precisely track number of dirty/clear pages for each iteration Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 06/20] KVM: selftests: Read per-page value into local var when verifying dirty_log_test Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 07/20] KVM: selftests: Continuously reap dirty ring while vCPU is running Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 08/20] KVM: selftests: Limit dirty_log_test's s390x workaround to s390x Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 09/20] KVM: selftests: Honor "stop" request in dirty ring test Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 10/20] KVM: selftests: Keep dirty_log_test vCPU in guest until it needs to stop Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 11/20] KVM: selftests: Post to sem_vcpu_stop if and only if vcpu_stop is true Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 12/20] KVM: selftests: Use continue to handle all "pass" scenarios in dirty_log_test Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 13/20] KVM: selftests: Print (previous) last_page on dirty page value mismatch Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 14/20] KVM: selftests: Collect *all* dirty entries in each dirty_log_test iteration Sean Christopherson
2025-01-11  0:29 ` [PATCH v2 15/20] KVM: sefltests: Verify value of dirty_log_test last page isn't bogus Sean Christopherson
2025-01-11  0:30 ` [PATCH v2 16/20] KVM: selftests: Ensure guest writes min number of pages in dirty_log_test Sean Christopherson
2025-01-11  0:30 ` [PATCH v2 17/20] KVM: selftests: Tighten checks around prev iter's last dirty page in ring Sean Christopherson
2025-01-11  0:30 ` [PATCH v2 18/20] KVM: selftests: Set per-iteration variables at the start of each iteration Sean Christopherson
2025-01-11  0:30 ` [PATCH v2 19/20] KVM: selftests: Fix an off-by-one in the number of dirty_log_test iterations Sean Christopherson
2025-01-11  0:30 ` [PATCH v2 20/20] KVM: selftests: Allow running a single iteration of dirty_log_test Sean Christopherson
2025-01-20 20:34 ` [PATCH v2 00/20] KVM: selftests: Fixes and cleanups for dirty_log_test Maxim Levitsky
2025-02-15  0:50 ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250111003004.1235645-1-seanjc@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlevitsk@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®